[INFO] updating cached repository xTibor/gba-assembler [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/xTibor/gba-assembler [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/xTibor/gba-assembler" "work/ex/clippy-test-run/sources/stable/gh/xTibor/gba-assembler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/xTibor/gba-assembler'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/xTibor/gba-assembler" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/xTibor/gba-assembler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/xTibor/gba-assembler'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8a03ae96356e14fcab7241c2fb537350baac278c [INFO] sha for GitHub repo xTibor/gba-assembler: 8a03ae96356e14fcab7241c2fb537350baac278c [INFO] validating manifest of xTibor/gba-assembler on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of xTibor/gba-assembler on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing xTibor/gba-assembler [INFO] finished frobbing xTibor/gba-assembler [INFO] frobbed toml for xTibor/gba-assembler written to work/ex/clippy-test-run/sources/stable/gh/xTibor/gba-assembler/Cargo.toml [INFO] started frobbing xTibor/gba-assembler [INFO] finished frobbing xTibor/gba-assembler [INFO] frobbed toml for xTibor/gba-assembler written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/xTibor/gba-assembler/Cargo.toml [INFO] crate xTibor/gba-assembler has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting xTibor/gba-assembler against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/xTibor/gba-assembler:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a2943e6066b4df8f0303254ffc0734ae113c5a57d791bf23f121b3f3b4979329 [INFO] running `"docker" "start" "-a" "a2943e6066b4df8f0303254ffc0734ae113c5a57d791bf23f121b3f3b4979329"` [INFO] [stderr] Compiling pest v1.0.0-beta.15 [INFO] [stderr] Compiling syn v0.10.8 [INFO] [stderr] Compiling pest_derive v1.0.0-beta.15 [INFO] [stderr] Checking gba-assembler v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused imports: `Input`, `Span` [INFO] [stderr] --> src/main.rs:7:20 [INFO] [stderr] | [INFO] [stderr] 7 | use pest::inputs::{Input, Span}; [INFO] [stderr] | ^^^^^ ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `pest::iterators::Pair` [INFO] [stderr] --> src/main.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use pest::iterators::Pair; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Input`, `Span` [INFO] [stderr] --> src/main.rs:7:20 [INFO] [stderr] | [INFO] [stderr] 7 | use pest::inputs::{Input, Span}; [INFO] [stderr] | ^^^^^ ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `pest::iterators::Pair` [INFO] [stderr] --> src/main.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use pest::iterators::Pair; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:140:10 [INFO] [stderr] | [INFO] [stderr] 140 | / match pair.as_rule() { [INFO] [stderr] 141 | | Rule::op => { [INFO] [stderr] 142 | | let op = pair.into_inner().next().unwrap(); [INFO] [stderr] 143 | | match op.as_rule() { [INFO] [stderr] ... | [INFO] [stderr] 159 | | _ => {}, [INFO] [stderr] 160 | | } [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 140 | if let Rule::op = pair.as_rule() { [INFO] [stderr] 141 | let op = pair.into_inner().next().unwrap(); [INFO] [stderr] 142 | match op.as_rule() { [INFO] [stderr] 143 | Rule::op_cmp_3 => { [INFO] [stderr] 144 | result.push(Op::Cmp3(Register::R0, Register::R1)); [INFO] [stderr] 145 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:140:10 [INFO] [stderr] | [INFO] [stderr] 140 | / match pair.as_rule() { [INFO] [stderr] 141 | | Rule::op => { [INFO] [stderr] 142 | | let op = pair.into_inner().next().unwrap(); [INFO] [stderr] 143 | | match op.as_rule() { [INFO] [stderr] ... | [INFO] [stderr] 159 | | _ => {}, [INFO] [stderr] 160 | | } [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 140 | if let Rule::op = pair.as_rule() { [INFO] [stderr] 141 | let op = pair.into_inner().next().unwrap(); [INFO] [stderr] 142 | match op.as_rule() { [INFO] [stderr] 143 | Rule::op_cmp_3 => { [INFO] [stderr] 144 | result.push(Op::Cmp3(Register::R0, Register::R1)); [INFO] [stderr] 145 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.62s [INFO] running `"docker" "inspect" "a2943e6066b4df8f0303254ffc0734ae113c5a57d791bf23f121b3f3b4979329"` [INFO] running `"docker" "rm" "-f" "a2943e6066b4df8f0303254ffc0734ae113c5a57d791bf23f121b3f3b4979329"` [INFO] [stdout] a2943e6066b4df8f0303254ffc0734ae113c5a57d791bf23f121b3f3b4979329