[INFO] updating cached repository xSke/aoc18 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/xSke/aoc18 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/xSke/aoc18" "work/ex/clippy-test-run/sources/stable/gh/xSke/aoc18"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/xSke/aoc18'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/xSke/aoc18" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/xSke/aoc18"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/xSke/aoc18'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a4fb9047ae1464585d7b5ab93da6b1c8e56751d5 [INFO] sha for GitHub repo xSke/aoc18: a4fb9047ae1464585d7b5ab93da6b1c8e56751d5 [INFO] validating manifest of xSke/aoc18 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of xSke/aoc18 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing xSke/aoc18 [INFO] finished frobbing xSke/aoc18 [INFO] frobbed toml for xSke/aoc18 written to work/ex/clippy-test-run/sources/stable/gh/xSke/aoc18/Cargo.toml [INFO] started frobbing xSke/aoc18 [INFO] finished frobbing xSke/aoc18 [INFO] frobbed toml for xSke/aoc18 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/xSke/aoc18/Cargo.toml [INFO] crate xSke/aoc18 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting xSke/aoc18 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/xSke/aoc18:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f61a27ffadf8b4786d5d05d1984493a20b188cc9119609fd7589dfbaf92faf1d [INFO] running `"docker" "start" "-a" "f61a27ffadf8b4786d5d05d1984493a20b188cc9119609fd7589dfbaf92faf1d"` [INFO] [stderr] Checking nodrop v0.1.13 [INFO] [stderr] Compiling encoding_rs v0.8.13 [INFO] [stderr] Checking smallvec v0.6.7 [INFO] [stderr] Compiling parking_lot_core v0.4.0 [INFO] [stderr] Checking clicolors-control v0.3.0 [INFO] [stderr] Checking termios v0.3.1 [INFO] [stderr] Checking number_prefix v0.2.8 [INFO] [stderr] Checking arrayvec v0.4.8 [INFO] [stderr] Checking parking_lot_core v0.3.1 [INFO] [stderr] Checking crossbeam-epoch v0.6.1 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking parking_lot v0.7.0 [INFO] [stderr] Checking crossbeam-deque v0.6.2 [INFO] [stderr] Checking tokio-reactor v0.1.7 [INFO] [stderr] Checking tokio-threadpool v0.1.9 [INFO] [stderr] Checking console v0.7.0 [INFO] [stderr] Checking tokio-uds v0.2.4 [INFO] [stderr] Checking tokio-udp v0.1.3 [INFO] [stderr] Checking tokio-tcp v0.1.2 [INFO] [stderr] Checking indicatif v0.10.1 [INFO] [stderr] Checking tokio-fs v0.1.4 [INFO] [stderr] Checking tokio v0.1.13 [INFO] [stderr] Checking hyper v0.12.16 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] Checking reqwest v0.9.5 [INFO] [stderr] Checking aoc18 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/day11.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | let a = if x > 0 && y > 0 { self.grid[y-1][x-1] } else { 0 }; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/day11.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | let b = if y > 0 { self.grid[y-1][x+w-1] } else { 0 }; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/day11.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | let c = if x > 0 { self.grid[y+h-1][x-1] } else { 0 }; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/day11.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | let d = self.grid[y+h-1][x+w-1]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/day11.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | let a = if x > 0 && y > 0 { self.grid[y-1][x-1] } else { 0 }; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/day11.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | let b = if y > 0 { self.grid[y-1][x+w-1] } else { 0 }; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/day11.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | let c = if x > 0 { self.grid[y+h-1][x-1] } else { 0 }; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/day11.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | let d = self.grid[y+h-1][x+w-1]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day1.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | / return (input [INFO] [stderr] 5 | | .lines() [INFO] [stderr] 6 | | .fold(0, |acc, line| acc + line.parse::().unwrap()) [INFO] [stderr] 7 | | .to_string(), ()); [INFO] [stderr] | |__________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 4 | (input [INFO] [stderr] 5 | .lines() [INFO] [stderr] 6 | .fold(0, |acc, line| acc + line.parse::().unwrap()) [INFO] [stderr] 7 | .to_string(), ()) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day2.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day3.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/day4.rs:54:16 [INFO] [stderr] | [INFO] [stderr] 54 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 55 | | if rest == "falls asleep" { [INFO] [stderr] 56 | | guards.get_mut(¤t_guard).unwrap().0 [INFO] [stderr] 57 | | .push(SleepSpan(minute, minute)); [INFO] [stderr] ... | [INFO] [stderr] 62 | | } [INFO] [stderr] 63 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 54 | } else if rest == "falls asleep" { [INFO] [stderr] 55 | guards.get_mut(¤t_guard).unwrap().0 [INFO] [stderr] 56 | .push(SleepSpan(minute, minute)); [INFO] [stderr] 57 | } else if rest == "wakes up" { [INFO] [stderr] 58 | guards.get_mut(¤t_guard).unwrap().0 [INFO] [stderr] 59 | .iter_mut().last().unwrap() [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/day5.rs:11:16 [INFO] [stderr] | [INFO] [stderr] 11 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 12 | | if are_pairs(stack[stack.len() - 1], c) { [INFO] [stderr] 13 | | stack.pop(); [INFO] [stderr] 14 | | } else { [INFO] [stderr] 15 | | stack.push(c); [INFO] [stderr] 16 | | } [INFO] [stderr] 17 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 11 | } else if are_pairs(stack[stack.len() - 1], c) { [INFO] [stderr] 12 | stack.pop(); [INFO] [stderr] 13 | } else { [INFO] [stderr] 14 | stack.push(c); [INFO] [stderr] 15 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day7.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | return (task as usize) - 65 + 60; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(task as usize) - 65 + 60` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day1.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | / return (input [INFO] [stderr] 5 | | .lines() [INFO] [stderr] 6 | | .fold(0, |acc, line| acc + line.parse::().unwrap()) [INFO] [stderr] 7 | | .to_string(), ()); [INFO] [stderr] | |__________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 4 | (input [INFO] [stderr] 5 | .lines() [INFO] [stderr] 6 | .fold(0, |acc, line| acc + line.parse::().unwrap()) [INFO] [stderr] 7 | .to_string(), ()) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day2.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day3.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/day4.rs:54:16 [INFO] [stderr] | [INFO] [stderr] 54 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 55 | | if rest == "falls asleep" { [INFO] [stderr] 56 | | guards.get_mut(¤t_guard).unwrap().0 [INFO] [stderr] 57 | | .push(SleepSpan(minute, minute)); [INFO] [stderr] ... | [INFO] [stderr] 62 | | } [INFO] [stderr] 63 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 54 | } else if rest == "falls asleep" { [INFO] [stderr] 55 | guards.get_mut(¤t_guard).unwrap().0 [INFO] [stderr] 56 | .push(SleepSpan(minute, minute)); [INFO] [stderr] 57 | } else if rest == "wakes up" { [INFO] [stderr] 58 | guards.get_mut(¤t_guard).unwrap().0 [INFO] [stderr] 59 | .iter_mut().last().unwrap() [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/day5.rs:11:16 [INFO] [stderr] | [INFO] [stderr] 11 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 12 | | if are_pairs(stack[stack.len() - 1], c) { [INFO] [stderr] 13 | | stack.pop(); [INFO] [stderr] 14 | | } else { [INFO] [stderr] 15 | | stack.push(c); [INFO] [stderr] 16 | | } [INFO] [stderr] 17 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 11 | } else if are_pairs(stack[stack.len() - 1], c) { [INFO] [stderr] 12 | stack.pop(); [INFO] [stderr] 13 | } else { [INFO] [stderr] 14 | stack.push(c); [INFO] [stderr] 15 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day7.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | return (task as usize) - 65 + 60; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(task as usize) - 65 + 60` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/day4.rs:53:41 [INFO] [stderr] | [INFO] [stderr] 53 | guards.entry(current_guard).or_insert(Guard(Vec::new())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| Guard(Vec::new()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: the loop variable `minute` is used to index `minutes` [INFO] [stderr] --> src/day4.rs:80:23 [INFO] [stderr] | [INFO] [stderr] 80 | for minute in 0..60 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 80 | for (minute, ) in minutes.iter_mut().enumerate().take(60) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/day5.rs:9:12 [INFO] [stderr] | [INFO] [stderr] 9 | if stack.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/day7.rs:21:18 [INFO] [stderr] | [INFO] [stderr] 21 | .or_insert(vec![prerequisite]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| vec![prerequisite])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/day7.rs:22:47 [INFO] [stderr] | [INFO] [stderr] 22 | prerequisites.entry(prerequisite).or_insert(vec![]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/day7.rs:30:32 [INFO] [stderr] | [INFO] [stderr] 30 | .filter(|(_, pqs)| pqs.len() == 0) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `pqs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/day7.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | self.prerequisites.len() == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.prerequisites.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/day8.rs:24:8 [INFO] [stderr] | [INFO] [stderr] 24 | if node.child_nodes.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `node.child_nodes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day8.rs:37:16 [INFO] [stderr] | [INFO] [stderr] 37 | .split(" ") [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/day10.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | display.get_mut(y as usize).unwrap()[x as usize] = '#'; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `display[y as usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | (days.get_mut(day_num - 1).unwrap())(&session); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `days[day_num - 1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/day4.rs:53:41 [INFO] [stderr] | [INFO] [stderr] 53 | guards.entry(current_guard).or_insert(Guard(Vec::new())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| Guard(Vec::new()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: the loop variable `minute` is used to index `minutes` [INFO] [stderr] --> src/day4.rs:80:23 [INFO] [stderr] | [INFO] [stderr] 80 | for minute in 0..60 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 80 | for (minute, ) in minutes.iter_mut().enumerate().take(60) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/day5.rs:9:12 [INFO] [stderr] | [INFO] [stderr] 9 | if stack.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/day7.rs:21:18 [INFO] [stderr] | [INFO] [stderr] 21 | .or_insert(vec![prerequisite]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| vec![prerequisite])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/day7.rs:22:47 [INFO] [stderr] | [INFO] [stderr] 22 | prerequisites.entry(prerequisite).or_insert(vec![]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/day7.rs:30:32 [INFO] [stderr] | [INFO] [stderr] 30 | .filter(|(_, pqs)| pqs.len() == 0) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `pqs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/day7.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | self.prerequisites.len() == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.prerequisites.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/day8.rs:24:8 [INFO] [stderr] | [INFO] [stderr] 24 | if node.child_nodes.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `node.child_nodes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day8.rs:37:16 [INFO] [stderr] | [INFO] [stderr] 37 | .split(" ") [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/day10.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | display.get_mut(y as usize).unwrap()[x as usize] = '#'; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `display[y as usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | (days.get_mut(day_num - 1).unwrap())(&session); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `days[day_num - 1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 23.64s [INFO] running `"docker" "inspect" "f61a27ffadf8b4786d5d05d1984493a20b188cc9119609fd7589dfbaf92faf1d"` [INFO] running `"docker" "rm" "-f" "f61a27ffadf8b4786d5d05d1984493a20b188cc9119609fd7589dfbaf92faf1d"` [INFO] [stdout] f61a27ffadf8b4786d5d05d1984493a20b188cc9119609fd7589dfbaf92faf1d