[INFO] updating cached repository xKerman/aws-billing-notification [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/xKerman/aws-billing-notification [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/xKerman/aws-billing-notification" "work/ex/clippy-test-run/sources/stable/gh/xKerman/aws-billing-notification"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/xKerman/aws-billing-notification'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/xKerman/aws-billing-notification" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/xKerman/aws-billing-notification"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/xKerman/aws-billing-notification'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f906de98a777f42fa8d12dd944e137c56a313da4 [INFO] sha for GitHub repo xKerman/aws-billing-notification: f906de98a777f42fa8d12dd944e137c56a313da4 [INFO] validating manifest of xKerman/aws-billing-notification on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of xKerman/aws-billing-notification on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing xKerman/aws-billing-notification [INFO] finished frobbing xKerman/aws-billing-notification [INFO] frobbed toml for xKerman/aws-billing-notification written to work/ex/clippy-test-run/sources/stable/gh/xKerman/aws-billing-notification/Cargo.toml [INFO] started frobbing xKerman/aws-billing-notification [INFO] finished frobbing xKerman/aws-billing-notification [INFO] frobbed toml for xKerman/aws-billing-notification written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/xKerman/aws-billing-notification/Cargo.toml [INFO] crate xKerman/aws-billing-notification has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting xKerman/aws-billing-notification against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/xKerman/aws-billing-notification:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bd3a7ca86c5606faf62ddb4de2fb211315901471b2f5dc8cdcc11ea28300589d [INFO] running `"docker" "start" "-a" "bd3a7ca86c5606faf62ddb4de2fb211315901471b2f5dc8cdcc11ea28300589d"` [INFO] [stderr] Checking nodrop v0.1.13 [INFO] [stderr] Compiling proc-macro2 v0.4.24 [INFO] [stderr] Compiling openssl v0.10.15 [INFO] [stderr] Compiling ryu v0.2.7 [INFO] [stderr] Compiling httparse v1.3.3 [INFO] [stderr] Checking indexmap v1.0.2 [INFO] [stderr] Compiling native-tls v0.2.2 [INFO] [stderr] Checking string v0.1.2 [INFO] [stderr] Checking constant_time_eq v0.1.3 [INFO] [stderr] Checking hex v0.3.2 [INFO] [stderr] Checking md5 v0.3.8 [INFO] [stderr] Checking hex v0.2.0 [INFO] [stderr] Checking rand_xorshift v0.1.0 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking crossbeam-utils v0.6.1 [INFO] [stderr] Checking owning_ref v0.4.0 [INFO] [stderr] Checking tokio-service v0.1.0 [INFO] [stderr] Checking relay v0.1.1 [INFO] [stderr] Compiling openssl-sys v0.9.39 [INFO] [stderr] Compiling memchr v2.1.1 [INFO] [stderr] Compiling unicase v2.2.0 [INFO] [stderr] Checking xml-rs v0.7.0 [INFO] [stderr] Checking base64 v0.9.3 [INFO] [stderr] Checking arrayvec v0.4.8 [INFO] [stderr] Checking smallvec v0.6.7 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Checking want v0.0.6 [INFO] [stderr] Checking want v0.0.4 [INFO] [stderr] Checking tokio-current-thread v0.1.4 [INFO] [stderr] Checking tokio-timer v0.2.8 [INFO] [stderr] Checking lock_api v0.1.5 [INFO] [stderr] Compiling rand_pcg v0.1.1 [INFO] [stderr] Compiling rand_chacha v0.1.0 [INFO] [stderr] Compiling rand v0.6.1 [INFO] [stderr] Compiling rusoto_core v0.36.0 [INFO] [stderr] Checking iovec v0.1.2 [INFO] [stderr] Checking rand v0.5.5 [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Checking num_cpus v1.8.0 [INFO] [stderr] Checking rand v0.4.3 [INFO] [stderr] Checking dirs v1.0.4 [INFO] [stderr] Checking backtrace-sys v0.1.24 [INFO] [stderr] Checking crossbeam-epoch v0.6.1 [INFO] [stderr] Checking url v1.7.2 [INFO] [stderr] Checking libflate v0.1.19 [INFO] [stderr] Checking bytes v0.4.11 [INFO] [stderr] Checking futures-cpupool v0.1.8 [INFO] [stderr] Checking serde_json v1.0.33 [INFO] [stderr] Compiling openssl v0.9.24 [INFO] [stderr] Checking crypto-mac v0.5.2 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Checking mio v0.6.16 [INFO] [stderr] Checking backtrace v0.3.9 [INFO] [stderr] Checking crossbeam-deque v0.6.2 [INFO] [stderr] Checking aho-corasick v0.6.9 [INFO] [stderr] Checking rand v0.3.22 [INFO] [stderr] Compiling quote v0.6.10 [INFO] [stderr] Checking sha2 v0.7.1 [INFO] [stderr] Checking hmac v0.5.0 [INFO] [stderr] Checking serde_urlencoded v0.5.4 [INFO] [stderr] Checking url_serde v0.2.0 [INFO] [stderr] Checking parking_lot_core v0.3.1 [INFO] [stderr] Checking tokio-io v0.1.10 [INFO] [stderr] Checking http v0.1.14 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking mime v0.3.12 [INFO] [stderr] Checking regex v1.1.0 [INFO] [stderr] Compiling syn v0.15.22 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking simple_logger v1.0.1 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking tokio-codec v0.1.1 [INFO] [stderr] Checking tokio-reactor v0.1.7 [INFO] [stderr] Checking tokio-tcp v0.1.2 [INFO] [stderr] Checking tokio-uds v0.2.4 [INFO] [stderr] Checking tokio-udp v0.1.3 [INFO] [stderr] Checking tokio-threadpool v0.1.9 [INFO] [stderr] Checking native-tls v0.1.5 [INFO] [stderr] Checking tokio-fs v0.1.4 [INFO] [stderr] Checking h2 v0.1.13 [INFO] [stderr] Checking tokio v0.1.13 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Compiling serde_derive v1.0.80 [INFO] [stderr] Checking hyper v0.12.16 [INFO] [stderr] Checking hyper v0.11.27 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] Checking hyper-tls v0.1.4 [INFO] [stderr] Checking rusoto_credential v0.15.0 [INFO] [stderr] Checking lambda_runtime_client v0.1.0 [INFO] [stderr] Checking reqwest v0.7.3 [INFO] [stderr] Checking lambda_runtime v0.1.0 [INFO] [stderr] Checking slack-hook v0.7.0 [INFO] [stderr] Checking rusoto_cloudwatch v0.36.0 [INFO] [stderr] Checking rusoto_ssm v0.36.0 [INFO] [stderr] Checking aws-billing-notification v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:70:21 [INFO] [stderr] | [INFO] [stderr] 70 | return dp[0].maximum.unwrap_or(0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `dp[0].maximum.unwrap_or(0.0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:139:25 [INFO] [stderr] | [INFO] [stderr] 139 | return dp[0].maximum.unwrap_or(0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `dp[0].maximum.unwrap_or(0.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:70:21 [INFO] [stderr] | [INFO] [stderr] 70 | return dp[0].maximum.unwrap_or(0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `dp[0].maximum.unwrap_or(0.0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:139:25 [INFO] [stderr] | [INFO] [stderr] 139 | return dp[0].maximum.unwrap_or(0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `dp[0].maximum.unwrap_or(0.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:90:46 [INFO] [stderr] | [INFO] [stderr] 90 | let metrics = output.metrics.unwrap_or(vec![]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:93:56 [INFO] [stderr] | [INFO] [stderr] 93 | .flat_map(|m| m.clone().dimensions.unwrap_or(vec![])) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:90:46 [INFO] [stderr] | [INFO] [stderr] 90 | let metrics = output.metrics.unwrap_or(vec![]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:93:56 [INFO] [stderr] | [INFO] [stderr] 93 | .flat_map(|m| m.clone().dimensions.unwrap_or(vec![])) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2m 09s [INFO] running `"docker" "inspect" "bd3a7ca86c5606faf62ddb4de2fb211315901471b2f5dc8cdcc11ea28300589d"` [INFO] running `"docker" "rm" "-f" "bd3a7ca86c5606faf62ddb4de2fb211315901471b2f5dc8cdcc11ea28300589d"` [INFO] [stdout] bd3a7ca86c5606faf62ddb4de2fb211315901471b2f5dc8cdcc11ea28300589d