[INFO] updating cached repository x1a0/bcproxy-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/x1a0/bcproxy-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/x1a0/bcproxy-rust" "work/ex/clippy-test-run/sources/stable/gh/x1a0/bcproxy-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/x1a0/bcproxy-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/x1a0/bcproxy-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/x1a0/bcproxy-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/x1a0/bcproxy-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 89f7a9d0bef79ac1c2fd5187befbad45be98d8a0 [INFO] sha for GitHub repo x1a0/bcproxy-rust: 89f7a9d0bef79ac1c2fd5187befbad45be98d8a0 [INFO] validating manifest of x1a0/bcproxy-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of x1a0/bcproxy-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing x1a0/bcproxy-rust [INFO] finished frobbing x1a0/bcproxy-rust [INFO] frobbed toml for x1a0/bcproxy-rust written to work/ex/clippy-test-run/sources/stable/gh/x1a0/bcproxy-rust/Cargo.toml [INFO] started frobbing x1a0/bcproxy-rust [INFO] finished frobbing x1a0/bcproxy-rust [INFO] frobbed toml for x1a0/bcproxy-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/x1a0/bcproxy-rust/Cargo.toml [INFO] crate x1a0/bcproxy-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting x1a0/bcproxy-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/x1a0/bcproxy-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8683e2ed769f233e47059fa836279d5987e9f5c937eb505bd8d15f413079d289 [INFO] running `"docker" "start" "-a" "8683e2ed769f233e47059fa836279d5987e9f5c937eb505bd8d15f413079d289"` [INFO] [stderr] Compiling typenum v1.10.0 [INFO] [stderr] Checking either v1.5.0 [INFO] [stderr] Compiling num-traits v0.2.4 [INFO] [stderr] Checking byte-tools v0.2.0 [INFO] [stderr] Checking arrayref v0.3.4 [INFO] [stderr] Compiling num-integer v0.1.38 [INFO] [stderr] Checking constant_time_eq v0.1.3 [INFO] [stderr] Checking fake-simd v0.1.2 [INFO] [stderr] Checking fallible-iterator v0.1.4 [INFO] [stderr] Checking md5 v0.3.7 [INFO] [stderr] Compiling regex v1.0.0 [INFO] [stderr] Checking termcolor v0.3.6 [INFO] [stderr] Checking iovec v0.1.2 [INFO] [stderr] Checking memchr v1.0.2 [INFO] [stderr] Checking memchr v2.0.1 [INFO] [stderr] Checking net2 v0.2.32 [INFO] [stderr] Checking log v0.4.1 [INFO] [stderr] Checking socket2 v0.3.6 [INFO] [stderr] Checking phf_shared v0.7.21 [INFO] [stderr] Checking futures-core v0.2.1 [INFO] [stderr] Checking block-buffer v0.3.3 [INFO] [stderr] Checking regex-syntax v0.6.0 [INFO] [stderr] Checking scheduled-thread-pool v0.2.0 [INFO] [stderr] Checking rand v0.3.22 [INFO] [stderr] Checking stringprep v0.1.2 [INFO] [stderr] Checking crossbeam-epoch v0.4.1 [INFO] [stderr] Checking bytes v0.4.8 [INFO] [stderr] Checking tokio-timer v0.2.3 [INFO] [stderr] Checking aho-corasick v0.6.4 [INFO] [stderr] Checking phf v0.7.21 [INFO] [stderr] Checking mio v0.6.14 [INFO] [stderr] Checking futures-channel v0.2.1 [INFO] [stderr] Checking futures-io v0.2.1 [INFO] [stderr] Checking r2d2 v0.8.2 [INFO] [stderr] Checking crossbeam-deque v0.3.1 [INFO] [stderr] Checking futures-sink v0.2.1 [INFO] [stderr] Checking tokio-threadpool v0.1.3 [INFO] [stderr] Checking tokio-io v0.1.6 [INFO] [stderr] Checking futures-util v0.2.1 [INFO] [stderr] Checking generic-array v0.9.0 [INFO] [stderr] Checking tokio-reactor v0.1.1 [INFO] [stderr] Checking tokio-fs v0.1.0 [INFO] [stderr] Checking digest v0.7.2 [INFO] [stderr] Checking crypto-mac v0.5.2 [INFO] [stderr] Checking sha2 v0.7.1 [INFO] [stderr] Checking hmac v0.5.0 [INFO] [stderr] Checking chrono v0.4.2 [INFO] [stderr] Checking tokio-udp v0.1.0 [INFO] [stderr] Checking tokio-tcp v0.1.0 [INFO] [stderr] Checking postgres-protocol v0.3.2 [INFO] [stderr] Checking tokio v0.1.6 [INFO] [stderr] Checking futures-executor v0.2.1 [INFO] [stderr] Checking postgres-shared v0.4.1 [INFO] [stderr] Checking futures-stable v0.2.1 [INFO] [stderr] Checking futures-async-runtime v0.2.1 [INFO] [stderr] Checking futures v0.2.1 [INFO] [stderr] Checking postgres v0.15.2 [INFO] [stderr] Checking env_logger v0.5.10 [INFO] [stderr] Checking r2d2_postgres v0.14.0 [INFO] [stderr] Checking bcproxy-rust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol/control_code.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol/control_code.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | parent: parent, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `parent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol/bat_mapper.rs:174:13 [INFO] [stderr] | [INFO] [stderr] 174 | area: area, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `area` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol/bat_mapper.rs:175:13 [INFO] [stderr] | [INFO] [stderr] 175 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol/bat_mapper.rs:176:13 [INFO] [stderr] | [INFO] [stderr] 176 | short_desc: short_desc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `short_desc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol/bat_mapper.rs:177:13 [INFO] [stderr] | [INFO] [stderr] 177 | long_desc: long_desc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `long_desc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol/bat_mapper.rs:178:13 [INFO] [stderr] | [INFO] [stderr] 178 | exits: exits, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `exits` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol/bat_mapper.rs:179:13 [INFO] [stderr] | [INFO] [stderr] 179 | is_indoor: is_indoor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_indoor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol/bat_mapper.rs:180:13 [INFO] [stderr] | [INFO] [stderr] 180 | from_dir: from_dir, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `from_dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol/bat_mapper.rs:182:13 [INFO] [stderr] | [INFO] [stderr] 182 | output: output, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | pool: pool, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `pool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol/control_code.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol/control_code.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | parent: parent, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `parent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol/bat_mapper.rs:174:13 [INFO] [stderr] | [INFO] [stderr] 174 | area: area, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `area` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol/bat_mapper.rs:175:13 [INFO] [stderr] | [INFO] [stderr] 175 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol/bat_mapper.rs:176:13 [INFO] [stderr] | [INFO] [stderr] 176 | short_desc: short_desc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `short_desc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol/bat_mapper.rs:177:13 [INFO] [stderr] | [INFO] [stderr] 177 | long_desc: long_desc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `long_desc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol/bat_mapper.rs:178:13 [INFO] [stderr] | [INFO] [stderr] 178 | exits: exits, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `exits` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol/bat_mapper.rs:179:13 [INFO] [stderr] | [INFO] [stderr] 179 | is_indoor: is_indoor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_indoor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol/bat_mapper.rs:180:13 [INFO] [stderr] | [INFO] [stderr] 180 | from_dir: from_dir, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `from_dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol/bat_mapper.rs:182:13 [INFO] [stderr] | [INFO] [stderr] 182 | output: output, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | pool: pool, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `pool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/codec.rs:73:25 [INFO] [stderr] | [INFO] [stderr] 73 | frame [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/codec.rs:72:37 [INFO] [stderr] | [INFO] [stderr] 72 | let frame = self.process(child_bytes); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | 0x000000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | 0x800000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0080_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | 0x008000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_8000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | 0x808000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0080_8000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | 0x000080, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_0080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | 0x800080, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0080_0080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | 0x008080, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_8080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | 0xc0c0c0, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00c0_c0c0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | 0x808080, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0080_8080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | 0xff0000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | 0x00ff00, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_ff00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | 0xffff00, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_ff00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | 0x0000ff, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_00ff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | 0xff00ff, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_00ff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | 0x00ffff, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | 0xffffff, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | 0x080808, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0008_0808` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | 0x121212, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0012_1212` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | 0x1c1c1c, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001c_1c1c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | 0x262626, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0026_2626` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | 0x303030, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0030_3030` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | 0x3a3a3a, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x003a_3a3a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | 0x444444, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0044_4444` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | 0x4e4e4e, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x004e_4e4e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | 0x585858, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0058_5858` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | 0x626262, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0062_6262` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | 0x6c6c6c, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x006c_6c6c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | 0x767676, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0076_7676` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | 0x808080, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0080_8080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | 0x8a8a8a, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x008a_8a8a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | 0x949494, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0094_9494` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | 0x9e9e9e, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x009e_9e9e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | 0xa8a8a8, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00a8_a8a8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | 0xb2b2b2, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00b2_b2b2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | 0xbcbcbc, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00bc_bcbc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | 0xc6c6c6, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00c6_c6c6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | 0xd0d0d0, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00d0_d0d0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | 0xdadada, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00da_dada` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | 0xe4e4e4, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00e4_e4e4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | 0xeeeeee, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ee_eeee` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/codec.rs:73:25 [INFO] [stderr] | [INFO] [stderr] 73 | frame [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/codec.rs:72:37 [INFO] [stderr] | [INFO] [stderr] 72 | let frame = self.process(child_bytes); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | 0x000000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | 0x800000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0080_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | 0x008000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_8000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | 0x808000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0080_8000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | 0x000080, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_0080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | 0x800080, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0080_0080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | 0x008080, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_8080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | 0xc0c0c0, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00c0_c0c0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | 0x808080, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0080_8080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | 0xff0000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | 0x00ff00, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_ff00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | 0xffff00, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_ff00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | 0x0000ff, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_00ff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | 0xff00ff, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_00ff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | 0x00ffff, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | 0xffffff, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | 0x080808, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0008_0808` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | 0x121212, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0012_1212` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | 0x1c1c1c, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001c_1c1c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | 0x262626, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0026_2626` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | 0x303030, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0030_3030` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | 0x3a3a3a, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x003a_3a3a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | 0x444444, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0044_4444` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | 0x4e4e4e, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x004e_4e4e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | 0x585858, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0058_5858` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | 0x626262, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0062_6262` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | 0x6c6c6c, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x006c_6c6c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | 0x767676, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0076_7676` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | 0x808080, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0080_8080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | 0x8a8a8a, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x008a_8a8a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | 0x949494, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0094_9494` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | 0x9e9e9e, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x009e_9e9e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | 0xa8a8a8, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00a8_a8a8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | 0xb2b2b2, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00b2_b2b2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | 0xbcbcbc, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00bc_bcbc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | 0xc6c6c6, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00c6_c6c6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | 0xd0d0d0, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00d0_d0d0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | 0xdadada, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00da_dada` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | 0xe4e4e4, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00e4_e4e4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | 0xeeeeee, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ee_eeee` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/codec.rs:50:21 [INFO] [stderr] | [INFO] [stderr] 50 | None if bytes.len() > 0 => { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!bytes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/codec.rs:61:51 [INFO] [stderr] | [INFO] [stderr] 61 | let new_code = ControlCode::new((c1, c2), self.code.as_ref().map(|x| x.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.code.as_ref().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/color.rs:77:21 [INFO] [stderr] | [INFO] [stderr] 77 | let rgb: u32 = ((r as u32) << 16) | ((g as u32) << 8) | (b as u32); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(r)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/color.rs:77:42 [INFO] [stderr] | [INFO] [stderr] 77 | let rgb: u32 = ((r as u32) << 16) | ((g as u32) << 8) | (b as u32); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/color.rs:77:61 [INFO] [stderr] | [INFO] [stderr] 77 | let rgb: u32 = ((r as u32) << 16) | ((g as u32) << 8) | (b as u32); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/color.rs:56:10 [INFO] [stderr] | [INFO] [stderr] 56 | (($x as u32) * $n / (u8::MAX as u32)) as u8 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(r)` [INFO] [stderr] ... [INFO] [stderr] 84 | None => 16 + 36 * scale!(r, 5) + 6 * scale!(g, 5) + scale!(b, 5) [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/color.rs:56:29 [INFO] [stderr] | [INFO] [stderr] 56 | (($x as u32) * $n / (u8::MAX as u32)) as u8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(u8::MAX)` [INFO] [stderr] ... [INFO] [stderr] 84 | None => 16 + 36 * scale!(r, 5) + 6 * scale!(g, 5) + scale!(b, 5) [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/color.rs:56:10 [INFO] [stderr] | [INFO] [stderr] 56 | (($x as u32) * $n / (u8::MAX as u32)) as u8 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(g)` [INFO] [stderr] ... [INFO] [stderr] 84 | None => 16 + 36 * scale!(r, 5) + 6 * scale!(g, 5) + scale!(b, 5) [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/color.rs:56:29 [INFO] [stderr] | [INFO] [stderr] 56 | (($x as u32) * $n / (u8::MAX as u32)) as u8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(u8::MAX)` [INFO] [stderr] ... [INFO] [stderr] 84 | None => 16 + 36 * scale!(r, 5) + 6 * scale!(g, 5) + scale!(b, 5) [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/color.rs:56:10 [INFO] [stderr] | [INFO] [stderr] 56 | (($x as u32) * $n / (u8::MAX as u32)) as u8 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(b)` [INFO] [stderr] ... [INFO] [stderr] 84 | None => 16 + 36 * scale!(r, 5) + 6 * scale!(g, 5) + scale!(b, 5) [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/color.rs:56:29 [INFO] [stderr] | [INFO] [stderr] 56 | (($x as u32) * $n / (u8::MAX as u32)) as u8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(u8::MAX)` [INFO] [stderr] ... [INFO] [stderr] 84 | None => 16 + 36 * scale!(r, 5) + 6 * scale!(g, 5) + scale!(b, 5) [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/protocol/control_code.rs:103:21 [INFO] [stderr] | [INFO] [stderr] 103 | lines = lines - 10; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `lines -= 10` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/protocol/control_code.rs:130:20 [INFO] [stderr] | [INFO] [stderr] 130 | if body.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!body.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/protocol/control_code.rs:290:21 [INFO] [stderr] | [INFO] [stderr] 290 | lines = lines - 10; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `lines -= 10` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/protocol/control_code.rs:318:20 [INFO] [stderr] | [INFO] [stderr] 318 | if body.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!body.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/protocol/bat_mapper.rs:115:24 [INFO] [stderr] | [INFO] [stderr] 115 | if bytes.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!bytes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/protocol/bat_mapper.rs:130:21 [INFO] [stderr] | [INFO] [stderr] 130 | / match state { [INFO] [stderr] 131 | | ParseState::LongDesc => { [INFO] [stderr] 132 | | if cnt_long_desc_line == 0 { [INFO] [stderr] 133 | | output.extend(&[b'\n']); [INFO] [stderr] ... | [INFO] [stderr] 149 | | _ => () [INFO] [stderr] 150 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 130 | if let ParseState::LongDesc = state { [INFO] [stderr] 131 | if cnt_long_desc_line == 0 { [INFO] [stderr] 132 | output.extend(&[b'\n']); [INFO] [stderr] 133 | } [INFO] [stderr] 134 | [INFO] [stderr] 135 | output.extend(b"[bat_mapper:long:"); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/protocol/bat_mapper.rs:162:9 [INFO] [stderr] | [INFO] [stderr] 162 | / match state { [INFO] [stderr] 163 | | ParseState::Area => output.extend(&b"[bat_mapper] "[..]), [INFO] [stderr] 164 | | _ => () [INFO] [stderr] 165 | | } [INFO] [stderr] | |_________^ help: try this: `if let ParseState::Area = state { output.extend(&b"[bat_mapper] "[..]) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/protocol/bat_mapper.rs:167:12 [INFO] [stderr] | [INFO] [stderr] 167 | if input.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!input.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/protocol/mod.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | x = x / 10; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `x /= 10` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:65:39 [INFO] [stderr] | [INFO] [stderr] 65 | let db = pool.clone().map(|p| Db::new(p)); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove closure as shown: `Db::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/codec.rs:50:21 [INFO] [stderr] | [INFO] [stderr] 50 | None if bytes.len() > 0 => { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!bytes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/codec.rs:61:51 [INFO] [stderr] | [INFO] [stderr] 61 | let new_code = ControlCode::new((c1, c2), self.code.as_ref().map(|x| x.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.code.as_ref().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/color.rs:77:21 [INFO] [stderr] | [INFO] [stderr] 77 | let rgb: u32 = ((r as u32) << 16) | ((g as u32) << 8) | (b as u32); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(r)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/color.rs:77:42 [INFO] [stderr] | [INFO] [stderr] 77 | let rgb: u32 = ((r as u32) << 16) | ((g as u32) << 8) | (b as u32); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/color.rs:77:61 [INFO] [stderr] | [INFO] [stderr] 77 | let rgb: u32 = ((r as u32) << 16) | ((g as u32) << 8) | (b as u32); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/color.rs:56:10 [INFO] [stderr] | [INFO] [stderr] 56 | (($x as u32) * $n / (u8::MAX as u32)) as u8 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(r)` [INFO] [stderr] ... [INFO] [stderr] 84 | None => 16 + 36 * scale!(r, 5) + 6 * scale!(g, 5) + scale!(b, 5) [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/color.rs:56:29 [INFO] [stderr] | [INFO] [stderr] 56 | (($x as u32) * $n / (u8::MAX as u32)) as u8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(u8::MAX)` [INFO] [stderr] ... [INFO] [stderr] 84 | None => 16 + 36 * scale!(r, 5) + 6 * scale!(g, 5) + scale!(b, 5) [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/color.rs:56:10 [INFO] [stderr] | [INFO] [stderr] 56 | (($x as u32) * $n / (u8::MAX as u32)) as u8 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(g)` [INFO] [stderr] ... [INFO] [stderr] 84 | None => 16 + 36 * scale!(r, 5) + 6 * scale!(g, 5) + scale!(b, 5) [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/color.rs:56:29 [INFO] [stderr] | [INFO] [stderr] 56 | (($x as u32) * $n / (u8::MAX as u32)) as u8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(u8::MAX)` [INFO] [stderr] ... [INFO] [stderr] 84 | None => 16 + 36 * scale!(r, 5) + 6 * scale!(g, 5) + scale!(b, 5) [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/color.rs:56:10 [INFO] [stderr] | [INFO] [stderr] 56 | (($x as u32) * $n / (u8::MAX as u32)) as u8 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(b)` [INFO] [stderr] ... [INFO] [stderr] 84 | None => 16 + 36 * scale!(r, 5) + 6 * scale!(g, 5) + scale!(b, 5) [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/color.rs:56:29 [INFO] [stderr] | [INFO] [stderr] 56 | (($x as u32) * $n / (u8::MAX as u32)) as u8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(u8::MAX)` [INFO] [stderr] ... [INFO] [stderr] 84 | None => 16 + 36 * scale!(r, 5) + 6 * scale!(g, 5) + scale!(b, 5) [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 209 [INFO] [stderr] --> src/color.rs:152:5 [INFO] [stderr] | [INFO] [stderr] 152 | / fn others() { [INFO] [stderr] 153 | | assert_eq!(rgb_to_xterm(BytesMut::from(&b"00005f"[..])), 17); [INFO] [stderr] 154 | | assert_eq!(rgb_to_xterm(BytesMut::from(&b"000087"[..])), 18); [INFO] [stderr] 155 | | assert_eq!(rgb_to_xterm(BytesMut::from(&b"0000af"[..])), 19); [INFO] [stderr] ... | [INFO] [stderr] 366 | | assert_eq!(rgb_to_xterm(BytesMut::from(&b"ffffd7"[..])), 230); [INFO] [stderr] 367 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/protocol/control_code.rs:103:21 [INFO] [stderr] | [INFO] [stderr] 103 | lines = lines - 10; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `lines -= 10` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/protocol/control_code.rs:130:20 [INFO] [stderr] | [INFO] [stderr] 130 | if body.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!body.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/protocol/control_code.rs:290:21 [INFO] [stderr] | [INFO] [stderr] 290 | lines = lines - 10; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `lines -= 10` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/protocol/control_code.rs:318:20 [INFO] [stderr] | [INFO] [stderr] 318 | if body.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!body.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/protocol/bat_mapper.rs:115:24 [INFO] [stderr] | [INFO] [stderr] 115 | if bytes.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!bytes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/protocol/bat_mapper.rs:130:21 [INFO] [stderr] | [INFO] [stderr] 130 | / match state { [INFO] [stderr] 131 | | ParseState::LongDesc => { [INFO] [stderr] 132 | | if cnt_long_desc_line == 0 { [INFO] [stderr] 133 | | output.extend(&[b'\n']); [INFO] [stderr] ... | [INFO] [stderr] 149 | | _ => () [INFO] [stderr] 150 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 130 | if let ParseState::LongDesc = state { [INFO] [stderr] 131 | if cnt_long_desc_line == 0 { [INFO] [stderr] 132 | output.extend(&[b'\n']); [INFO] [stderr] 133 | } [INFO] [stderr] 134 | [INFO] [stderr] 135 | output.extend(b"[bat_mapper:long:"); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/protocol/bat_mapper.rs:162:9 [INFO] [stderr] | [INFO] [stderr] 162 | / match state { [INFO] [stderr] 163 | | ParseState::Area => output.extend(&b"[bat_mapper] "[..]), [INFO] [stderr] 164 | | _ => () [INFO] [stderr] 165 | | } [INFO] [stderr] | |_________^ help: try this: `if let ParseState::Area = state { output.extend(&b"[bat_mapper] "[..]) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/protocol/bat_mapper.rs:167:12 [INFO] [stderr] | [INFO] [stderr] 167 | if input.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!input.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/protocol/mod.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | x = x / 10; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `x /= 10` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:65:39 [INFO] [stderr] | [INFO] [stderr] 65 | let db = pool.clone().map(|p| Db::new(p)); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove closure as shown: `Db::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 44.74s [INFO] running `"docker" "inspect" "8683e2ed769f233e47059fa836279d5987e9f5c937eb505bd8d15f413079d289"` [INFO] running `"docker" "rm" "-f" "8683e2ed769f233e47059fa836279d5987e9f5c937eb505bd8d15f413079d289"` [INFO] [stdout] 8683e2ed769f233e47059fa836279d5987e9f5c937eb505bd8d15f413079d289