[INFO] updating cached repository wwendler/random_tarot [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/wwendler/random_tarot [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/wwendler/random_tarot" "work/ex/clippy-test-run/sources/stable/gh/wwendler/random_tarot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/wwendler/random_tarot'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/wwendler/random_tarot" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wwendler/random_tarot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wwendler/random_tarot'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a98f0ca2b11fcfc62e22cff80ec1725a3db6782f [INFO] sha for GitHub repo wwendler/random_tarot: a98f0ca2b11fcfc62e22cff80ec1725a3db6782f [INFO] validating manifest of wwendler/random_tarot on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wwendler/random_tarot on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wwendler/random_tarot [INFO] finished frobbing wwendler/random_tarot [INFO] frobbed toml for wwendler/random_tarot written to work/ex/clippy-test-run/sources/stable/gh/wwendler/random_tarot/Cargo.toml [INFO] started frobbing wwendler/random_tarot [INFO] finished frobbing wwendler/random_tarot [INFO] frobbed toml for wwendler/random_tarot written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wwendler/random_tarot/Cargo.toml [INFO] crate wwendler/random_tarot has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wwendler/random_tarot against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/wwendler/random_tarot:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 93b9c09e1c19e09d93798ef3d23839b8380217620259dae56e28d6bede69ca61 [INFO] running `"docker" "start" "-a" "93b9c09e1c19e09d93798ef3d23839b8380217620259dae56e28d6bede69ca61"` [INFO] [stderr] Checking libc v0.2.21 [INFO] [stderr] Checking rand v0.3.15 [INFO] [stderr] Checking random_tarot v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:6:22 [INFO] [stderr] | [INFO] [stderr] 6 | const SUIT_NAMES : [&'static str; 4] = ["wands", "coins", "cups", "swords"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:7:22 [INFO] [stderr] | [INFO] [stderr] 7 | const CARD_NAMES : [&'static str; 14] = ["ace", "two", "three", "four", "five", "six", "seven", "eight", "nine", "ten", "jack", "knight", "queen", "king"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:8:23 [INFO] [stderr] | [INFO] [stderr] 8 | const TRUMP_NAMES : [&'static str; 22] = ["the fool", "the magician", "the high priestess", "the empress", "the emperor", "the hierophant", "the lovers", "the chariot", "strength", "the hermit", "wheel of fortune", "justice", "the hanged man", "death", "temperance", "the devil", "the tower", "the star", "the moon", "the sun", "judgement", "the world"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:47:16 [INFO] [stderr] | [INFO] [stderr] 47 | if deck.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `deck.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:6:22 [INFO] [stderr] | [INFO] [stderr] 6 | const SUIT_NAMES : [&'static str; 4] = ["wands", "coins", "cups", "swords"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:7:22 [INFO] [stderr] | [INFO] [stderr] 7 | const CARD_NAMES : [&'static str; 14] = ["ace", "two", "three", "four", "five", "six", "seven", "eight", "nine", "ten", "jack", "knight", "queen", "king"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:8:23 [INFO] [stderr] | [INFO] [stderr] 8 | const TRUMP_NAMES : [&'static str; 22] = ["the fool", "the magician", "the high priestess", "the empress", "the emperor", "the hierophant", "the lovers", "the chariot", "strength", "the hermit", "wheel of fortune", "justice", "the hanged man", "death", "temperance", "the devil", "the tower", "the star", "the moon", "the sun", "judgement", "the world"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:47:16 [INFO] [stderr] | [INFO] [stderr] 47 | if deck.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `deck.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.18s [INFO] running `"docker" "inspect" "93b9c09e1c19e09d93798ef3d23839b8380217620259dae56e28d6bede69ca61"` [INFO] running `"docker" "rm" "-f" "93b9c09e1c19e09d93798ef3d23839b8380217620259dae56e28d6bede69ca61"` [INFO] [stdout] 93b9c09e1c19e09d93798ef3d23839b8380217620259dae56e28d6bede69ca61