[INFO] updating cached repository wszxl516/terminal_clock [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/wszxl516/terminal_clock [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/wszxl516/terminal_clock" "work/ex/clippy-test-run/sources/stable/gh/wszxl516/terminal_clock"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/wszxl516/terminal_clock'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/wszxl516/terminal_clock" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wszxl516/terminal_clock"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wszxl516/terminal_clock'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 51b63572cc2bd6b9029c3ecbc70e977d386afa45 [INFO] sha for GitHub repo wszxl516/terminal_clock: 51b63572cc2bd6b9029c3ecbc70e977d386afa45 [INFO] validating manifest of wszxl516/terminal_clock on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wszxl516/terminal_clock on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wszxl516/terminal_clock [INFO] finished frobbing wszxl516/terminal_clock [INFO] frobbed toml for wszxl516/terminal_clock written to work/ex/clippy-test-run/sources/stable/gh/wszxl516/terminal_clock/Cargo.toml [INFO] started frobbing wszxl516/terminal_clock [INFO] finished frobbing wszxl516/terminal_clock [INFO] frobbed toml for wszxl516/terminal_clock written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wszxl516/terminal_clock/Cargo.toml [INFO] crate wszxl516/terminal_clock has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wszxl516/terminal_clock against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/wszxl516/terminal_clock:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fdd17a0e0513a69ffbacf57e12e8ae8459ade09a9d0783dae75b9b19dd199f2e [INFO] running `"docker" "start" "-a" "fdd17a0e0513a69ffbacf57e12e8ae8459ade09a9d0783dae75b9b19dd199f2e"` [INFO] [stderr] Checking time v0.1.40 [INFO] [stderr] Checking num-integer v0.1.39 [INFO] [stderr] Checking signal v0.6.0 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Checking terminal_clock v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:201:5 [INFO] [stderr] | [INFO] [stderr] 201 | return num [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `num` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:211:5 [INFO] [stderr] | [INFO] [stderr] 211 | return num [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:201:5 [INFO] [stderr] | [INFO] [stderr] 201 | return num [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `num` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:211:5 [INFO] [stderr] | [INFO] [stderr] 211 | return num [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:232:53 [INFO] [stderr] | [INFO] [stderr] 232 | let argument: Vec<&str> = arg.splitn(2, "=").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:253:9 [INFO] [stderr] | [INFO] [stderr] 253 | / let mut value:&str = " "; [INFO] [stderr] 254 | | if self.0.contains_key(key){ [INFO] [stderr] 255 | | value = &self.0[key]; [INFO] [stderr] 256 | | } [INFO] [stderr] | |_________________^ help: it is more idiomatic to write: `let value = if self.0.contains_key(key) { &self.0[key] } else { " " };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:286:27 [INFO] [stderr] | [INFO] [stderr] 286 | let r = ((self.red as f64 / 51.0).round() * 36.0) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(self.red)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:287:27 [INFO] [stderr] | [INFO] [stderr] 287 | let g = ((self.green as f64 / 51.0).round() * 6.0) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.green)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:288:26 [INFO] [stderr] | [INFO] [stderr] 288 | let b = (self.blue as f64 / 51.0).round() as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(self.blue)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:232:53 [INFO] [stderr] | [INFO] [stderr] 232 | let argument: Vec<&str> = arg.splitn(2, "=").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:253:9 [INFO] [stderr] | [INFO] [stderr] 253 | / let mut value:&str = " "; [INFO] [stderr] 254 | | if self.0.contains_key(key){ [INFO] [stderr] 255 | | value = &self.0[key]; [INFO] [stderr] 256 | | } [INFO] [stderr] | |_________________^ help: it is more idiomatic to write: `let value = if self.0.contains_key(key) { &self.0[key] } else { " " };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: the loop variable `n` is used to index `pic` [INFO] [stderr] --> src/main.rs:346:14 [INFO] [stderr] | [INFO] [stderr] 346 | for n in 0..pic.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:286:27 [INFO] [stderr] | [INFO] [stderr] 286 | let r = ((self.red as f64 / 51.0).round() * 36.0) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(self.red)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 346 | for (n, ) in pic.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:287:27 [INFO] [stderr] | [INFO] [stderr] 287 | let g = ((self.green as f64 / 51.0).round() * 6.0) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.green)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:288:26 [INFO] [stderr] | [INFO] [stderr] 288 | let b = (self.blue as f64 / 51.0).round() as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(self.blue)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `n` is used to index `pic` [INFO] [stderr] --> src/main.rs:346:14 [INFO] [stderr] | [INFO] [stderr] 346 | for n in 0..pic.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 346 | for (n, ) in pic.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.65s [INFO] running `"docker" "inspect" "fdd17a0e0513a69ffbacf57e12e8ae8459ade09a9d0783dae75b9b19dd199f2e"` [INFO] running `"docker" "rm" "-f" "fdd17a0e0513a69ffbacf57e12e8ae8459ade09a9d0783dae75b9b19dd199f2e"` [INFO] [stdout] fdd17a0e0513a69ffbacf57e12e8ae8459ade09a9d0783dae75b9b19dd199f2e