[INFO] updating cached repository wspl/deoxys-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/wspl/deoxys-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/wspl/deoxys-rust" "work/ex/clippy-test-run/sources/stable/gh/wspl/deoxys-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/wspl/deoxys-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/wspl/deoxys-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wspl/deoxys-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wspl/deoxys-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 99f7914b9ce746d8b19b21a1dbe213f11b965c25 [INFO] sha for GitHub repo wspl/deoxys-rust: 99f7914b9ce746d8b19b21a1dbe213f11b965c25 [INFO] validating manifest of wspl/deoxys-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wspl/deoxys-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wspl/deoxys-rust [INFO] finished frobbing wspl/deoxys-rust [INFO] frobbed toml for wspl/deoxys-rust written to work/ex/clippy-test-run/sources/stable/gh/wspl/deoxys-rust/Cargo.toml [INFO] started frobbing wspl/deoxys-rust [INFO] finished frobbing wspl/deoxys-rust [INFO] frobbed toml for wspl/deoxys-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wspl/deoxys-rust/Cargo.toml [INFO] crate wspl/deoxys-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wspl/deoxys-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/wspl/deoxys-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e9d4a0db5b8c6b01c5c693c072ef4f4a4a2297e46235922c1013794bdd9b4289 [INFO] running `"docker" "start" "-a" "e9d4a0db5b8c6b01c5c693c072ef4f4a4a2297e46235922c1013794bdd9b4289"` [INFO] [stderr] Checking deoxys-rust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/messages/mod.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | dgram: dgram [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `dgram` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/messages/mod.rs:143:13 [INFO] [stderr] | [INFO] [stderr] 143 | dgram: dgram [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `dgram` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/messages/mod.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | dgram: dgram [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `dgram` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/messages/mod.rs:143:13 [INFO] [stderr] | [INFO] [stderr] 143 | dgram: dgram [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `dgram` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `VERSION` [INFO] [stderr] --> src/core/messages/ping.rs:1:13 [INFO] [stderr] | [INFO] [stderr] 1 | use super::{VERSION, MessageBase, MessageClasses, DgramBuilder, DgramReader}; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `DgramReader`, `MessageClasses` [INFO] [stderr] --> src/main.rs:5:35 [INFO] [stderr] | [INFO] [stderr] 5 | use core::messages::{MessageBase, MessageClasses, DgramReader}; [INFO] [stderr] | ^^^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `PingMessage2` [INFO] [stderr] --> src/core/messages/mod.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | PingMessage2 = 1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `DataMessage` [INFO] [stderr] --> src/core/messages/mod.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | DataMessage = 2, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `AckListMessage` [INFO] [stderr] --> src/core/messages/mod.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | AckListMessage = 3, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `CloseStreamMessage` [INFO] [stderr] --> src/core/messages/mod.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | CloseStreamMessage = 4, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `CloseConnMessage` [INFO] [stderr] --> src/core/messages/mod.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | CloseConnMessage = 5, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Unknown` [INFO] [stderr] --> src/core/messages/mod.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | Unknown = -1 [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `write_i16` [INFO] [stderr] --> src/core/messages/mod.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | fn write_i16(&mut self, data: i16, pos: usize) -> &mut DgramBuilder { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `write_i32` [INFO] [stderr] --> src/core/messages/mod.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | fn write_i32(&mut self, data: i32, pos: usize) -> &mut DgramBuilder { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `i16` [INFO] [stderr] --> src/core/messages/mod.rs:109:5 [INFO] [stderr] | [INFO] [stderr] 109 | fn i16(&self, pos: usize) -> i16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `version` [INFO] [stderr] --> src/core/messages/mod.rs:125:5 [INFO] [stderr] | [INFO] [stderr] 125 | fn version(&self) -> i16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `class` [INFO] [stderr] --> src/core/messages/mod.rs:129:5 [INFO] [stderr] | [INFO] [stderr] 129 | fn class(&self) -> MessageClasses { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `read_class` [INFO] [stderr] --> src/core/messages/mod.rs:141:5 [INFO] [stderr] | [INFO] [stderr] 141 | fn read_class(dgram: Vec) -> MessageClasses { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/core/messages/ping.rs:34:21 [INFO] [stderr] | [INFO] [stderr] 34 | self.base = base.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `base` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: unused import: `VERSION` [INFO] [stderr] --> src/core/messages/ping.rs:1:13 [INFO] [stderr] | [INFO] [stderr] 1 | use super::{VERSION, MessageBase, MessageClasses, DgramBuilder, DgramReader}; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `DgramReader`, `MessageClasses` [INFO] [stderr] --> src/main.rs:5:35 [INFO] [stderr] | [INFO] [stderr] 5 | use core::messages::{MessageBase, MessageClasses, DgramReader}; [INFO] [stderr] | ^^^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/core/messages/mod.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | fragm.write_i16::(data); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: the variable `relative_pos` is used as a loop counter. Consider using `for (relative_pos, item) in fragm.enumerate()` or similar iterators [INFO] [stderr] --> src/core/messages/mod.rs:42:21 [INFO] [stderr] | [INFO] [stderr] 42 | for byte in fragm { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/core/messages/mod.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | fragm.write_i32::(data); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: the variable `relative_pos` is used as a loop counter. Consider using `for (relative_pos, item) in fragm.enumerate()` or similar iterators [INFO] [stderr] --> src/core/messages/mod.rs:54:21 [INFO] [stderr] | [INFO] [stderr] 54 | for byte in fragm { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/core/messages/mod.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | fragm.write_i16::(data); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/core/messages/mod.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | fragm.write_i32::(data); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `fragm` [INFO] [stderr] --> src/core/messages/mod.rs:102:18 [INFO] [stderr] | [INFO] [stderr] 102 | for i in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 102 | for (i, ) in fragm.iter_mut().enumerate().take(4) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/core/messages/mod.rs:102:18 [INFO] [stderr] | [INFO] [stderr] 102 | for i in 0..4 { [INFO] [stderr] | ^^^^ help: try replacing the loop by: `fragm[..4].clone_from_slice(&self.dgram[pos..(4 + pos)])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `fragm` [INFO] [stderr] --> src/core/messages/mod.rs:111:18 [INFO] [stderr] | [INFO] [stderr] 111 | for i in 0..2 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 111 | for (i, ) in fragm.iter_mut().enumerate().take(2) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/core/messages/mod.rs:111:18 [INFO] [stderr] | [INFO] [stderr] 111 | for i in 0..2 { [INFO] [stderr] | ^^^^ help: try replacing the loop by: `fragm[..2].clone_from_slice(&self.dgram[pos..(2 + pos)])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `PingMessage2` [INFO] [stderr] --> src/core/messages/mod.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | PingMessage2 = 1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `DataMessage` [INFO] [stderr] --> src/core/messages/mod.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | DataMessage = 2, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `AckListMessage` [INFO] [stderr] --> src/core/messages/mod.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | AckListMessage = 3, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `CloseStreamMessage` [INFO] [stderr] --> src/core/messages/mod.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | CloseStreamMessage = 4, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `CloseConnMessage` [INFO] [stderr] --> src/core/messages/mod.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | CloseConnMessage = 5, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Unknown` [INFO] [stderr] --> src/core/messages/mod.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | Unknown = -1 [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `write_i16` [INFO] [stderr] --> src/core/messages/mod.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | fn write_i16(&mut self, data: i16, pos: usize) -> &mut DgramBuilder { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `write_i32` [INFO] [stderr] --> src/core/messages/mod.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | fn write_i32(&mut self, data: i32, pos: usize) -> &mut DgramBuilder { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `i16` [INFO] [stderr] --> src/core/messages/mod.rs:109:5 [INFO] [stderr] | [INFO] [stderr] 109 | fn i16(&self, pos: usize) -> i16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `version` [INFO] [stderr] --> src/core/messages/mod.rs:125:5 [INFO] [stderr] | [INFO] [stderr] 125 | fn version(&self) -> i16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `class` [INFO] [stderr] --> src/core/messages/mod.rs:129:5 [INFO] [stderr] | [INFO] [stderr] 129 | fn class(&self) -> MessageClasses { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `read_class` [INFO] [stderr] --> src/core/messages/mod.rs:141:5 [INFO] [stderr] | [INFO] [stderr] 141 | fn read_class(dgram: Vec) -> MessageClasses { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/core/messages/ping.rs:34:21 [INFO] [stderr] | [INFO] [stderr] 34 | self.base = base.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `base` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/core/messages/mod.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | fragm.write_i16::(data); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: the variable `relative_pos` is used as a loop counter. Consider using `for (relative_pos, item) in fragm.enumerate()` or similar iterators [INFO] [stderr] --> src/core/messages/mod.rs:42:21 [INFO] [stderr] | [INFO] [stderr] 42 | for byte in fragm { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/core/messages/mod.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | fragm.write_i32::(data); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: the variable `relative_pos` is used as a loop counter. Consider using `for (relative_pos, item) in fragm.enumerate()` or similar iterators [INFO] [stderr] --> src/core/messages/mod.rs:54:21 [INFO] [stderr] | [INFO] [stderr] 54 | for byte in fragm { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/core/messages/mod.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | fragm.write_i16::(data); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/core/messages/mod.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | fragm.write_i32::(data); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `fragm` [INFO] [stderr] --> src/core/messages/mod.rs:102:18 [INFO] [stderr] | [INFO] [stderr] 102 | for i in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 102 | for (i, ) in fragm.iter_mut().enumerate().take(4) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/core/messages/mod.rs:102:18 [INFO] [stderr] | [INFO] [stderr] 102 | for i in 0..4 { [INFO] [stderr] | ^^^^ help: try replacing the loop by: `fragm[..4].clone_from_slice(&self.dgram[pos..(4 + pos)])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `fragm` [INFO] [stderr] --> src/core/messages/mod.rs:111:18 [INFO] [stderr] | [INFO] [stderr] 111 | for i in 0..2 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 111 | for (i, ) in fragm.iter_mut().enumerate().take(2) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/core/messages/mod.rs:111:18 [INFO] [stderr] | [INFO] [stderr] 111 | for i in 0..2 { [INFO] [stderr] | ^^^^ help: try replacing the loop by: `fragm[..2].clone_from_slice(&self.dgram[pos..(2 + pos)])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.52s [INFO] running `"docker" "inspect" "e9d4a0db5b8c6b01c5c693c072ef4f4a4a2297e46235922c1013794bdd9b4289"` [INFO] running `"docker" "rm" "-f" "e9d4a0db5b8c6b01c5c693c072ef4f4a4a2297e46235922c1013794bdd9b4289"` [INFO] [stdout] e9d4a0db5b8c6b01c5c693c072ef4f4a4a2297e46235922c1013794bdd9b4289