[INFO] updating cached repository wraithan/md-to-wp [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/wraithan/md-to-wp [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/wraithan/md-to-wp" "work/ex/clippy-test-run/sources/stable/gh/wraithan/md-to-wp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/wraithan/md-to-wp'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/wraithan/md-to-wp" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wraithan/md-to-wp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wraithan/md-to-wp'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 34a62cbf66ec96f2352ac25c60a3ab416ba87251 [INFO] sha for GitHub repo wraithan/md-to-wp: 34a62cbf66ec96f2352ac25c60a3ab416ba87251 [INFO] validating manifest of wraithan/md-to-wp on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wraithan/md-to-wp on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wraithan/md-to-wp [INFO] finished frobbing wraithan/md-to-wp [INFO] frobbed toml for wraithan/md-to-wp written to work/ex/clippy-test-run/sources/stable/gh/wraithan/md-to-wp/Cargo.toml [INFO] started frobbing wraithan/md-to-wp [INFO] finished frobbing wraithan/md-to-wp [INFO] frobbed toml for wraithan/md-to-wp written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wraithan/md-to-wp/Cargo.toml [INFO] crate wraithan/md-to-wp has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wraithan/md-to-wp against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/wraithan/md-to-wp:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 44657d091bcc6209cda9151108be67bff302dd116ad359e162206bbe7beeff8b [INFO] running `"docker" "start" "-a" "44657d091bcc6209cda9151108be67bff302dd116ad359e162206bbe7beeff8b"` [INFO] [stderr] Checking libc v0.2.24 [INFO] [stderr] Checking unicode-segmentation v1.2.0 [INFO] [stderr] Checking typed-arena v1.3.0 [INFO] [stderr] Checking arena-tree v0.3.0 [INFO] [stderr] Checking memchr v1.0.1 [INFO] [stderr] Checking thread-id v3.1.0 [INFO] [stderr] Checking atty v0.2.2 [INFO] [stderr] Checking term_size v0.3.0 [INFO] [stderr] Checking aho-corasick v0.6.3 [INFO] [stderr] Checking thread_local v0.3.3 [INFO] [stderr] Checking clap v2.24.2 [INFO] [stderr] Checking regex v0.2.2 [INFO] [stderr] Checking comrak v0.1.4 [INFO] [stderr] Checking post v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | let ref mut value = node.data.borrow_mut().value; [INFO] [stderr] | ----^^^^^^^^^^^^^-------------------------------- help: try: `let value = &mut node.data.borrow_mut().value;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:31:25 [INFO] [stderr] | [INFO] [stderr] 31 | let new_value = match value { [INFO] [stderr] | _________________________^ [INFO] [stderr] 32 | | &mut NodeValue::CodeBlock(ref codeblock) => { [INFO] [stderr] 33 | | let formatted = code_to_html(&codeblock.literal, &codeblock.info); [INFO] [stderr] 34 | | NodeValue::HtmlBlock( [INFO] [stderr] ... | [INFO] [stderr] 41 | | _ => value.to_owned(), [INFO] [stderr] 42 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 31 | let new_value = match *value { [INFO] [stderr] 32 | NodeValue::CodeBlock(ref codeblock) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:59:28 [INFO] [stderr] | [INFO] [stderr] 59 | pub fn code_to_html(input: &String, lang: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:59:43 [INFO] [stderr] | [INFO] [stderr] 59 | pub fn code_to_html(input: &String, lang: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | let ref mut value = node.data.borrow_mut().value; [INFO] [stderr] | ----^^^^^^^^^^^^^-------------------------------- help: try: `let value = &mut node.data.borrow_mut().value;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:31:25 [INFO] [stderr] | [INFO] [stderr] 31 | let new_value = match value { [INFO] [stderr] | _________________________^ [INFO] [stderr] 32 | | &mut NodeValue::CodeBlock(ref codeblock) => { [INFO] [stderr] 33 | | let formatted = code_to_html(&codeblock.literal, &codeblock.info); [INFO] [stderr] 34 | | NodeValue::HtmlBlock( [INFO] [stderr] ... | [INFO] [stderr] 41 | | _ => value.to_owned(), [INFO] [stderr] 42 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 31 | let new_value = match *value { [INFO] [stderr] 32 | NodeValue::CodeBlock(ref codeblock) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:59:28 [INFO] [stderr] | [INFO] [stderr] 59 | pub fn code_to_html(input: &String, lang: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:59:43 [INFO] [stderr] | [INFO] [stderr] 59 | pub fn code_to_html(input: &String, lang: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.15s [INFO] running `"docker" "inspect" "44657d091bcc6209cda9151108be67bff302dd116ad359e162206bbe7beeff8b"` [INFO] running `"docker" "rm" "-f" "44657d091bcc6209cda9151108be67bff302dd116ad359e162206bbe7beeff8b"` [INFO] [stdout] 44657d091bcc6209cda9151108be67bff302dd116ad359e162206bbe7beeff8b