[INFO] updating cached repository wraikny/graph-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/wraikny/graph-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/wraikny/graph-rs" "work/ex/clippy-test-run/sources/stable/gh/wraikny/graph-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/wraikny/graph-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/wraikny/graph-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wraikny/graph-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wraikny/graph-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] bcfdf3b0c460339bcd0fb0523b71c487d2cc6acf [INFO] sha for GitHub repo wraikny/graph-rs: bcfdf3b0c460339bcd0fb0523b71c487d2cc6acf [INFO] validating manifest of wraikny/graph-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wraikny/graph-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wraikny/graph-rs [INFO] finished frobbing wraikny/graph-rs [INFO] frobbed toml for wraikny/graph-rs written to work/ex/clippy-test-run/sources/stable/gh/wraikny/graph-rs/Cargo.toml [INFO] started frobbing wraikny/graph-rs [INFO] finished frobbing wraikny/graph-rs [INFO] frobbed toml for wraikny/graph-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wraikny/graph-rs/Cargo.toml [INFO] crate wraikny/graph-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wraikny/graph-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/wraikny/graph-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9ef536685521d4676ca04cfdd926eee45e7dbbf4f97519e5e782eb721a15f9c1 [INFO] running `"docker" "start" "-a" "9ef536685521d4676ca04cfdd926eee45e7dbbf4f97519e5e782eb721a15f9c1"` [INFO] [stderr] Checking graph v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/algorithm/kruskal.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/algorithm/kruskal.rs:83:18 [INFO] [stderr] | [INFO] [stderr] 83 | let result = edges.map(|e| { [INFO] [stderr] | __________________^ [INFO] [stderr] 84 | | let (n1, n2) = &e.node.clone(); [INFO] [stderr] 85 | | if let Some(b) = uf.same_tree(n1, n2) { [INFO] [stderr] 86 | | if !b { [INFO] [stderr] ... | [INFO] [stderr] 94 | | } [INFO] [stderr] 95 | | }).filter_map(id).collect(); [INFO] [stderr] | |_______________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/algorithm/kruskal.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/algorithm/kruskal.rs:83:18 [INFO] [stderr] | [INFO] [stderr] 83 | let result = edges.map(|e| { [INFO] [stderr] | __________________^ [INFO] [stderr] 84 | | let (n1, n2) = &e.node.clone(); [INFO] [stderr] 85 | | if let Some(b) = uf.same_tree(n1, n2) { [INFO] [stderr] 86 | | if !b { [INFO] [stderr] ... | [INFO] [stderr] 94 | | } [INFO] [stderr] 95 | | }).filter_map(id).collect(); [INFO] [stderr] | |_______________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/algorithm/kruskal.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | self.sizes.get(&par).map(|x| *x) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.sizes.get(&par).cloned()` [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/algorithm/kruskal.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | self.sizes.get(&par).map(|x| *x) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.sizes.get(&par).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/algorithm/kruskal.rs:71:31 [INFO] [stderr] | [INFO] [stderr] 71 | edges.sort_by_key(|e| e.weight.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `e.weight` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/algorithm/kruskal.rs:71:31 [INFO] [stderr] | [INFO] [stderr] 71 | edges.sort_by_key(|e| e.weight.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `e.weight` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:27:62 [INFO] [stderr] | [INFO] [stderr] 27 | let edges : Vec> = s.replace(" ", "").split("\n") [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:29:29 [INFO] [stderr] | [INFO] [stderr] 29 | let x = x.split(",").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:27:62 [INFO] [stderr] | [INFO] [stderr] 27 | let edges : Vec> = s.replace(" ", "").split("\n") [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:29:29 [INFO] [stderr] | [INFO] [stderr] 29 | let x = x.split(",").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.65s [INFO] running `"docker" "inspect" "9ef536685521d4676ca04cfdd926eee45e7dbbf4f97519e5e782eb721a15f9c1"` [INFO] running `"docker" "rm" "-f" "9ef536685521d4676ca04cfdd926eee45e7dbbf4f97519e5e782eb721a15f9c1"` [INFO] [stdout] 9ef536685521d4676ca04cfdd926eee45e7dbbf4f97519e5e782eb721a15f9c1