[INFO] updating cached repository wolfmankurd/wihd.rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/wolfmankurd/wihd.rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/wolfmankurd/wihd.rs" "work/ex/clippy-test-run/sources/stable/gh/wolfmankurd/wihd.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/wolfmankurd/wihd.rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/wolfmankurd/wihd.rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wolfmankurd/wihd.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wolfmankurd/wihd.rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c958099664f8999a2e5aa6384eaab775eb6d7716 [INFO] sha for GitHub repo wolfmankurd/wihd.rs: c958099664f8999a2e5aa6384eaab775eb6d7716 [INFO] validating manifest of wolfmankurd/wihd.rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wolfmankurd/wihd.rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wolfmankurd/wihd.rs [INFO] finished frobbing wolfmankurd/wihd.rs [INFO] frobbed toml for wolfmankurd/wihd.rs written to work/ex/clippy-test-run/sources/stable/gh/wolfmankurd/wihd.rs/Cargo.toml [INFO] started frobbing wolfmankurd/wihd.rs [INFO] finished frobbing wolfmankurd/wihd.rs [INFO] frobbed toml for wolfmankurd/wihd.rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wolfmankurd/wihd.rs/Cargo.toml [INFO] crate wolfmankurd/wihd.rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wolfmankurd/wihd.rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/wolfmankurd/wihd.rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3f3df883ff7be0c791f2d3016f0416cd2cc8c6b84944e5f5f35b05c69b102c93 [INFO] running `"docker" "start" "-a" "3f3df883ff7be0c791f2d3016f0416cd2cc8c6b84944e5f5f35b05c69b102c93"` [INFO] [stderr] Checking wihdrs v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:87:41 [INFO] [stderr] | [INFO] [stderr] 87 | let player = Player{tag: tag, sock: sock}; [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tag` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:87:51 [INFO] [stderr] | [INFO] [stderr] 87 | let player = Player{tag: tag, sock: sock}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `sock` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:87:41 [INFO] [stderr] | [INFO] [stderr] 87 | let player = Player{tag: tag, sock: sock}; [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tag` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:87:51 [INFO] [stderr] | [INFO] [stderr] 87 | let player = Player{tag: tag, sock: sock}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `sock` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | / match red_reader.read_line(&mut red_read) { [INFO] [stderr] 23 | | Ok(n) => { [INFO] [stderr] 24 | | if 0 < n { [INFO] [stderr] 25 | | blue.write(red_read.as_bytes()) [INFO] [stderr] ... | [INFO] [stderr] 30 | | } [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 22 | if let Ok(n) = red_reader.read_line(&mut red_read) { [INFO] [stderr] 23 | if 0 < n { [INFO] [stderr] 24 | blue.write(red_read.as_bytes()) [INFO] [stderr] 25 | .expect("Could not write to stream."); [INFO] [stderr] 26 | } [INFO] [stderr] 27 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:25:25 [INFO] [stderr] | [INFO] [stderr] 25 | / blue.write(red_read.as_bytes()) [INFO] [stderr] 26 | | .expect("Could not write to stream."); [INFO] [stderr] | |_________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | / match blue_reader.read_line(&mut blue_read) { [INFO] [stderr] 36 | | Ok(n) => { [INFO] [stderr] 37 | | if 0 < n { [INFO] [stderr] 38 | | red.write(blue_read.as_bytes()) [INFO] [stderr] ... | [INFO] [stderr] 43 | | } [INFO] [stderr] 44 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 35 | if let Ok(n) = blue_reader.read_line(&mut blue_read) { [INFO] [stderr] 36 | if 0 < n { [INFO] [stderr] 37 | red.write(blue_read.as_bytes()) [INFO] [stderr] 38 | .expect("Could not write to stream."); [INFO] [stderr] 39 | } [INFO] [stderr] 40 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:38:25 [INFO] [stderr] | [INFO] [stderr] 38 | / red.write(blue_read.as_bytes()) [INFO] [stderr] 39 | | .expect("Could not write to stream."); [INFO] [stderr] | |_________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | / match red_reader.read_line(&mut red_read) { [INFO] [stderr] 23 | | Ok(n) => { [INFO] [stderr] 24 | | if 0 < n { [INFO] [stderr] 25 | | blue.write(red_read.as_bytes()) [INFO] [stderr] ... | [INFO] [stderr] 30 | | } [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 22 | if let Ok(n) = red_reader.read_line(&mut red_read) { [INFO] [stderr] 23 | if 0 < n { [INFO] [stderr] 24 | blue.write(red_read.as_bytes()) [INFO] [stderr] 25 | .expect("Could not write to stream."); [INFO] [stderr] 26 | } [INFO] [stderr] 27 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:25:25 [INFO] [stderr] | [INFO] [stderr] 25 | / blue.write(red_read.as_bytes()) [INFO] [stderr] 26 | | .expect("Could not write to stream."); [INFO] [stderr] | |_________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | / match blue_reader.read_line(&mut blue_read) { [INFO] [stderr] 36 | | Ok(n) => { [INFO] [stderr] 37 | | if 0 < n { [INFO] [stderr] 38 | | red.write(blue_read.as_bytes()) [INFO] [stderr] ... | [INFO] [stderr] 43 | | } [INFO] [stderr] 44 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 35 | if let Ok(n) = blue_reader.read_line(&mut blue_read) { [INFO] [stderr] 36 | if 0 < n { [INFO] [stderr] 37 | red.write(blue_read.as_bytes()) [INFO] [stderr] 38 | .expect("Could not write to stream."); [INFO] [stderr] 39 | } [INFO] [stderr] 40 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:38:25 [INFO] [stderr] | [INFO] [stderr] 38 | / red.write(blue_read.as_bytes()) [INFO] [stderr] 39 | | .expect("Could not write to stream."); [INFO] [stderr] | |_________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: Could not compile `wihdrs`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `wihdrs`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "3f3df883ff7be0c791f2d3016f0416cd2cc8c6b84944e5f5f35b05c69b102c93"` [INFO] running `"docker" "rm" "-f" "3f3df883ff7be0c791f2d3016f0416cd2cc8c6b84944e5f5f35b05c69b102c93"` [INFO] [stdout] 3f3df883ff7be0c791f2d3016f0416cd2cc8c6b84944e5f5f35b05c69b102c93