[INFO] updating cached repository woelper/tracktools [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/woelper/tracktools [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/woelper/tracktools" "work/ex/clippy-test-run/sources/stable/gh/woelper/tracktools"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/woelper/tracktools'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/woelper/tracktools" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/woelper/tracktools"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/woelper/tracktools'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 84c0355924689c404165104faf325631a6896c47 [INFO] sha for GitHub repo woelper/tracktools: 84c0355924689c404165104faf325631a6896c47 [INFO] validating manifest of woelper/tracktools on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of woelper/tracktools on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing woelper/tracktools [INFO] finished frobbing woelper/tracktools [INFO] frobbed toml for woelper/tracktools written to work/ex/clippy-test-run/sources/stable/gh/woelper/tracktools/Cargo.toml [INFO] started frobbing woelper/tracktools [INFO] finished frobbing woelper/tracktools [INFO] frobbed toml for woelper/tracktools written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/woelper/tracktools/Cargo.toml [INFO] crate woelper/tracktools has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting woelper/tracktools against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/woelper/tracktools:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e39fd731c5573c010436cd22e42afb9bce378435979a756c3bf4908820571e01 [INFO] running `"docker" "start" "-a" "e39fd731c5573c010436cd22e42afb9bce378435979a756c3bf4908820571e01"` [INFO] [stderr] Compiling cc v1.0.18 [INFO] [stderr] Compiling num-traits v0.2.5 [INFO] [stderr] Compiling num-integer v0.1.39 [INFO] [stderr] Checking atty v0.2.11 [INFO] [stderr] Checking encoding_rs v0.7.2 [INFO] [stderr] Checking clap v2.32.0 [INFO] [stderr] Compiling backtrace-sys v0.1.23 [INFO] [stderr] Checking backtrace v0.3.9 [INFO] [stderr] Checking chrono v0.4.4 [INFO] [stderr] Checking failure v0.1.1 [INFO] [stderr] Checking quick-xml v0.12.1 [INFO] [stderr] Checking tracktools v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `SubCommand` [INFO] [stderr] --> src/main.rs:6:22 [INFO] [stderr] | [INFO] [stderr] 6 | use clap::{App, Arg, SubCommand}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/gps.rs:240:29 [INFO] [stderr] | [INFO] [stderr] 240 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gps.rs:293:5 [INFO] [stderr] | [INFO] [stderr] 293 | return r * c; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `r * c` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `SubCommand` [INFO] [stderr] --> src/main.rs:6:22 [INFO] [stderr] | [INFO] [stderr] 6 | use clap::{App, Arg, SubCommand}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/gps.rs:240:29 [INFO] [stderr] | [INFO] [stderr] 240 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gps.rs:293:5 [INFO] [stderr] | [INFO] [stderr] 293 | return r * c; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `r * c` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `gps::Point` [INFO] [stderr] --> src/gps.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | / pub fn new() -> Point { [INFO] [stderr] 28 | | Point { [INFO] [stderr] 29 | | lat: 0.0, [INFO] [stderr] 30 | | long: 0.0, [INFO] [stderr] ... | [INFO] [stderr] 33 | | } [INFO] [stderr] 34 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 26 | impl Default for gps::Point { [INFO] [stderr] 27 | fn default() -> Self { [INFO] [stderr] 28 | Self::new() [INFO] [stderr] 29 | } [INFO] [stderr] 30 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: item `gps::Track` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/gps.rs:43:1 [INFO] [stderr] | [INFO] [stderr] 43 | / impl Track { [INFO] [stderr] 44 | | pub fn len(&self) -> f64 { [INFO] [stderr] 45 | | let mut sum = 0.0; [INFO] [stderr] 46 | | let mut prev_point = &self.points[0]; [INFO] [stderr] ... | [INFO] [stderr] 280 | | } [INFO] [stderr] 281 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: the variable `ptnum` is used as a loop counter. Consider using `for (ptnum, item) in &self.points.enumerate()` or similar iterators [INFO] [stderr] --> src/gps.rs:81:19 [INFO] [stderr] | [INFO] [stderr] 81 | for pt in &self.points { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/gps.rs:208:21 [INFO] [stderr] | [INFO] [stderr] 208 | pub fn from_xml(&mut self, filename: String) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `gps::Point` [INFO] [stderr] --> src/gps.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | / pub fn new() -> Point { [INFO] [stderr] 28 | | Point { [INFO] [stderr] 29 | | lat: 0.0, [INFO] [stderr] 30 | | long: 0.0, [INFO] [stderr] ... | [INFO] [stderr] 33 | | } [INFO] [stderr] 34 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 26 | impl Default for gps::Point { [INFO] [stderr] 27 | fn default() -> Self { [INFO] [stderr] 28 | Self::new() [INFO] [stderr] 29 | } [INFO] [stderr] 30 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/gps.rs:225:21 [INFO] [stderr] | [INFO] [stderr] 225 | / match e.name() { [INFO] [stderr] 226 | | b"trkpt" => { [INFO] [stderr] 227 | | for a in e.attributes() { [INFO] [stderr] 228 | | let unwrapped_attr = a.unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 242 | | _ => (), [INFO] [stderr] 243 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 225 | if let b"trkpt" = e.name() { [INFO] [stderr] 226 | for a in e.attributes() { [INFO] [stderr] 227 | let unwrapped_attr = a.unwrap(); [INFO] [stderr] 228 | let key = reader.decode(unwrapped_attr.key).into_owned(); [INFO] [stderr] 229 | let value = [INFO] [stderr] 230 | unwrapped_attr.unescape_and_decode_value(&reader).unwrap(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: item `gps::Track` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/gps.rs:43:1 [INFO] [stderr] | [INFO] [stderr] 43 | / impl Track { [INFO] [stderr] 44 | | pub fn len(&self) -> f64 { [INFO] [stderr] 45 | | let mut sum = 0.0; [INFO] [stderr] 46 | | let mut prev_point = &self.points[0]; [INFO] [stderr] ... | [INFO] [stderr] 280 | | } [INFO] [stderr] 281 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/gps.rs:305:5 [INFO] [stderr] | [INFO] [stderr] 305 | / match file.write_all("\n".as_bytes()) { [INFO] [stderr] 306 | | Err(_why) => panic!("couldn't write to {}", display), [INFO] [stderr] 307 | | // Ok(_) => (println!("Wrote header -> {}", display)), [INFO] [stderr] 308 | | Ok(_) => (), [INFO] [stderr] 309 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(_why) = file.write_all("\n".as_bytes()) { panic!("couldn't write to {}", display) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: the variable `ptnum` is used as a loop counter. Consider using `for (ptnum, item) in &self.points.enumerate()` or similar iterators [INFO] [stderr] --> src/gps.rs:81:19 [INFO] [stderr] | [INFO] [stderr] 81 | for pt in &self.points { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/gps.rs:208:21 [INFO] [stderr] | [INFO] [stderr] 208 | pub fn from_xml(&mut self, filename: String) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/gps.rs:225:21 [INFO] [stderr] | [INFO] [stderr] 225 | / match e.name() { [INFO] [stderr] 226 | | b"trkpt" => { [INFO] [stderr] 227 | | for a in e.attributes() { [INFO] [stderr] 228 | | let unwrapped_attr = a.unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 242 | | _ => (), [INFO] [stderr] 243 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 225 | if let b"trkpt" = e.name() { [INFO] [stderr] 226 | for a in e.attributes() { [INFO] [stderr] 227 | let unwrapped_attr = a.unwrap(); [INFO] [stderr] 228 | let key = reader.decode(unwrapped_attr.key).into_owned(); [INFO] [stderr] 229 | let value = [INFO] [stderr] 230 | unwrapped_attr.unescape_and_decode_value(&reader).unwrap(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/gps.rs:305:5 [INFO] [stderr] | [INFO] [stderr] 305 | / match file.write_all("\n".as_bytes()) { [INFO] [stderr] 306 | | Err(_why) => panic!("couldn't write to {}", display), [INFO] [stderr] 307 | | // Ok(_) => (println!("Wrote header -> {}", display)), [INFO] [stderr] 308 | | Ok(_) => (), [INFO] [stderr] 309 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(_why) = file.write_all("\n".as_bytes()) { panic!("couldn't write to {}", display) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 17.49s [INFO] running `"docker" "inspect" "e39fd731c5573c010436cd22e42afb9bce378435979a756c3bf4908820571e01"` [INFO] running `"docker" "rm" "-f" "e39fd731c5573c010436cd22e42afb9bce378435979a756c3bf4908820571e01"` [INFO] [stdout] e39fd731c5573c010436cd22e42afb9bce378435979a756c3bf4908820571e01