[INFO] updating cached repository wmww/Rust-on-Android-test [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/wmww/Rust-on-Android-test [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/wmww/Rust-on-Android-test" "work/ex/clippy-test-run/sources/stable/gh/wmww/Rust-on-Android-test"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/wmww/Rust-on-Android-test'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/wmww/Rust-on-Android-test" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wmww/Rust-on-Android-test"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wmww/Rust-on-Android-test'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0fea157162df88c7cb7c0a086f78e32d67e2ab29 [INFO] sha for GitHub repo wmww/Rust-on-Android-test: 0fea157162df88c7cb7c0a086f78e32d67e2ab29 [INFO] validating manifest of wmww/Rust-on-Android-test on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wmww/Rust-on-Android-test on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wmww/Rust-on-Android-test [INFO] finished frobbing wmww/Rust-on-Android-test [INFO] frobbed toml for wmww/Rust-on-Android-test written to work/ex/clippy-test-run/sources/stable/gh/wmww/Rust-on-Android-test/Cargo.toml [INFO] started frobbing wmww/Rust-on-Android-test [INFO] finished frobbing wmww/Rust-on-Android-test [INFO] frobbed toml for wmww/Rust-on-Android-test written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wmww/Rust-on-Android-test/Cargo.toml [INFO] crate wmww/Rust-on-Android-test has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wmww/Rust-on-Android-test against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/wmww/Rust-on-Android-test:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7d43d8e119101fd197f421faaeb63bfe434c48031db3475664966bc805504089 [INFO] running `"docker" "start" "-a" "7d43d8e119101fd197f421faaeb63bfe434c48031db3475664966bc805504089"` [INFO] [stderr] Compiling bitflags v1.0.3 [INFO] [stderr] Checking downcast-rs v1.0.3 [INFO] [stderr] Compiling num-traits v0.2.4 [INFO] [stderr] Checking stable_deref_trait v1.0.0 [INFO] [stderr] Checking smallvec v0.6.1 [INFO] [stderr] Checking approx v0.1.1 [INFO] [stderr] Compiling libloading v0.5.0 [INFO] [stderr] Compiling x11-dl v2.17.5 [INFO] [stderr] Checking memmap v0.6.2 [INFO] [stderr] Checking shared_library v0.1.8 [INFO] [stderr] Compiling log v0.4.1 [INFO] [stderr] Checking stb_truetype v0.2.2 [INFO] [stderr] Compiling xml-rs v0.7.0 [INFO] [stderr] Checking tempfile v3.0.2 [INFO] [stderr] Checking owning_ref v0.3.3 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking parking_lot_core v0.2.14 [INFO] [stderr] Checking parking_lot v0.5.5 [INFO] [stderr] Checking dlib v0.4.1 [INFO] [stderr] Checking wayland-sys v0.20.8 [INFO] [stderr] Checking wayland-commons v0.20.8 [INFO] [stderr] Compiling wayland-scanner v0.20.8 [INFO] [stderr] Compiling gl_generator v0.9.0 [INFO] [stderr] Checking num-traits v0.1.43 [INFO] [stderr] Checking ordered-float v0.5.0 [INFO] [stderr] Compiling wayland-client v0.20.8 [INFO] [stderr] Compiling wayland-protocols v0.20.8 [INFO] [stderr] Checking rusttype v0.5.2 [INFO] [stderr] Compiling gl v0.10.0 [INFO] [stderr] Compiling glutin v0.16.0 [INFO] [stderr] Checking smithay-client-toolkit v0.2.1 [INFO] [stderr] Checking winit v0.15.0 [INFO] [stderr] Checking android_rust_test v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gl_basic/shader.rs:38:29 [INFO] [stderr] | [INFO] [stderr] 38 | Ok(Shader { id: id }) [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gl_basic/shader.rs:91:30 [INFO] [stderr] | [INFO] [stderr] 91 | Ok(Program { id: id }) [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gl_basic/object.rs:40:17 [INFO] [stderr] | [INFO] [stderr] 40 | program: program, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `program` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gl_basic/texture.rs:14:26 [INFO] [stderr] | [INFO] [stderr] 14 | Ok(Texture { id: id }) [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | cache: cache, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `cache` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | texture: texture, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `texture` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text.rs:175:13 [INFO] [stderr] | [INFO] [stderr] 175 | cache: cache, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `cache` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text.rs:176:13 [INFO] [stderr] | [INFO] [stderr] 176 | font: font, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `font` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text.rs:177:13 [INFO] [stderr] | [INFO] [stderr] 177 | object: object, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `object` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gl_basic/shader.rs:38:29 [INFO] [stderr] | [INFO] [stderr] 38 | Ok(Shader { id: id }) [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gl_basic/shader.rs:91:30 [INFO] [stderr] | [INFO] [stderr] 91 | Ok(Program { id: id }) [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gl_basic/object.rs:40:17 [INFO] [stderr] | [INFO] [stderr] 40 | program: program, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `program` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gl_basic/texture.rs:14:26 [INFO] [stderr] | [INFO] [stderr] 14 | Ok(Texture { id: id }) [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | cache: cache, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `cache` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | texture: texture, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `texture` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text.rs:175:13 [INFO] [stderr] | [INFO] [stderr] 175 | cache: cache, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `cache` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text.rs:176:13 [INFO] [stderr] | [INFO] [stderr] 176 | font: font, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `font` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text.rs:177:13 [INFO] [stderr] | [INFO] [stderr] 177 | object: object, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `object` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `Font` [INFO] [stderr] --> src/text.rs:7:31 [INFO] [stderr] | [INFO] [stderr] 7 | use rusttype::{point, vector, Font, FontCollection, PositionedGlyph, Rect, Scale}; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std` [INFO] [stderr] --> src/gl_basic/object.rs:138:21 [INFO] [stderr] | [INFO] [stderr] 138 | use std; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/text.rs:345:1 [INFO] [stderr] | [INFO] [stderr] 345 | / attribs!(pub struct Vertex { [INFO] [stderr] 346 | | pub position: Vec2, [INFO] [stderr] 347 | | pub tex_coords: Vec2, [INFO] [stderr] 348 | | }); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused import: `rusttype::gpu_cache::CacheBuilder` [INFO] [stderr] --> src/main.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | use rusttype::gpu_cache::CacheBuilder; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Font`, `Rect`, `vector` [INFO] [stderr] --> src/main.rs:12:23 [INFO] [stderr] | [INFO] [stderr] 12 | use rusttype::{point, vector, Font, FontCollection, PositionedGlyph, Rect, Scale}; [INFO] [stderr] | ^^^^^^ ^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::mem` [INFO] [stderr] --> src/main.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | use std::mem; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ptr` [INFO] [stderr] --> src/main.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | use std::ptr; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std` [INFO] [stderr] --> src/gl_basic/object.rs:138:21 [INFO] [stderr] | [INFO] [stderr] 138 | use std; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/main.rs:149:5 [INFO] [stderr] | [INFO] [stderr] 149 | / attribs!(pub struct Vertex { [INFO] [stderr] 150 | | pub position: Vec2, [INFO] [stderr] 151 | | pub tex_coords: Vec2, [INFO] [stderr] 152 | | pub color: Vec4, [INFO] [stderr] 153 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused import: `Font` [INFO] [stderr] --> src/text.rs:7:31 [INFO] [stderr] | [INFO] [stderr] 7 | use rusttype::{point, vector, Font, FontCollection, PositionedGlyph, Rect, Scale}; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std` [INFO] [stderr] --> src/gl_basic/object.rs:138:21 [INFO] [stderr] | [INFO] [stderr] 138 | use std; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/text.rs:345:1 [INFO] [stderr] | [INFO] [stderr] 345 | / attribs!(pub struct Vertex { [INFO] [stderr] 346 | | pub position: Vec2, [INFO] [stderr] 347 | | pub tex_coords: Vec2, [INFO] [stderr] 348 | | }); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused import: `rusttype::gpu_cache::CacheBuilder` [INFO] [stderr] --> src/main.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | use rusttype::gpu_cache::CacheBuilder; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Font`, `Rect`, `vector` [INFO] [stderr] --> src/main.rs:12:23 [INFO] [stderr] | [INFO] [stderr] 12 | use rusttype::{point, vector, Font, FontCollection, PositionedGlyph, Rect, Scale}; [INFO] [stderr] | ^^^^^^ ^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::mem` [INFO] [stderr] --> src/main.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | use std::mem; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ptr` [INFO] [stderr] --> src/main.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | use std::ptr; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std` [INFO] [stderr] --> src/gl_basic/object.rs:138:21 [INFO] [stderr] | [INFO] [stderr] 138 | use std; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/main.rs:149:5 [INFO] [stderr] | [INFO] [stderr] 149 | / attribs!(pub struct Vertex { [INFO] [stderr] 150 | | pub position: Vec2, [INFO] [stderr] 151 | | pub tex_coords: Vec2, [INFO] [stderr] 152 | | pub color: Vec4, [INFO] [stderr] 153 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused import: `gl_basic::types::GlType` [INFO] [stderr] --> src/gl_basic/object.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use gl_basic::types::GlType; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | let mut texture = match gl_basic::Texture::new() { [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/text.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | let mut texture = match gl_basic::Texture::new() { [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/text.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | let mut cache = rusttype::gpu_cache::CacheBuilder { [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/text.rs:164:13 [INFO] [stderr] | [INFO] [stderr] 164 | let mut object = match Vertex::new_object(program) { [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/text.rs:169:13 [INFO] [stderr] | [INFO] [stderr] 169 | let mut cache = match GlGlyphCache::new() { [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Vec3` [INFO] [stderr] --> src/gl_basic/types.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | pub struct Vec3 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/gl_basic/shader.rs:27:18 [INFO] [stderr] | [INFO] [stderr] 27 | [std::ffi::CString::new(source).unwrap().as_ptr() as *const _].as_ptr(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::temporary_cstring_as_ptr)] on by default [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/gl_basic/shader.rs:27:18 [INFO] [stderr] | [INFO] [stderr] 27 | [std::ffi::CString::new(source).unwrap().as_ptr() as *const _].as_ptr(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/gl_basic/shader.rs:33:31 [INFO] [stderr] | [INFO] [stderr] 33 | let mut success = gl::FALSE as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/gl_basic/shader.rs:37:27 [INFO] [stderr] | [INFO] [stderr] 37 | if success == gl::TRUE as i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/gl_basic/shader.rs:86:31 [INFO] [stderr] | [INFO] [stderr] 86 | let mut success = gl::FALSE as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/gl_basic/shader.rs:90:27 [INFO] [stderr] | [INFO] [stderr] 90 | if success == gl::TRUE as i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/gl_basic/object.rs:59:21 [INFO] [stderr] | [INFO] [stderr] 59 | / std::ffi::CString::new(attrib.name.clone()) [INFO] [stderr] 60 | | .unwrap() [INFO] [stderr] 61 | | .as_ptr() as *const _, [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/gl_basic/object.rs:59:21 [INFO] [stderr] | [INFO] [stderr] 59 | / std::ffi::CString::new(attrib.name.clone()) [INFO] [stderr] 60 | | .unwrap() [INFO] [stderr] | |_________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/text.rs:94:44 [INFO] [stderr] | [INFO] [stderr] 94 | pub fn cache_glyphs(&mut self, glyphs: &Vec<(usize, &Vec>)>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(usize, &Vec>)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/text.rs:96:17 [INFO] [stderr] | [INFO] [stderr] 96 | for ref glyphs in glyphs { [INFO] [stderr] | ^^^^^^^^^^ ------ help: try: `let glyphs = &glyphs;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: unused import: `gl_basic::types::GlType` [INFO] [stderr] --> src/gl_basic/object.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use gl_basic::types::GlType; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/text.rs:192:17 [INFO] [stderr] | [INFO] [stderr] 192 | / match c { [INFO] [stderr] 193 | | '\n' => { [INFO] [stderr] 194 | | caret = point(0.0, caret.y + advance_height); [INFO] [stderr] 195 | | } [INFO] [stderr] 196 | | _ => {} [INFO] [stderr] 197 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 192 | if let '\n' = c { [INFO] [stderr] 193 | caret = point(0.0, caret.y + advance_height); [INFO] [stderr] 194 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `i` [INFO] [stderr] --> src/text.rs:296:23 [INFO] [stderr] | [INFO] [stderr] 296 | vec![[i + 0, i + 1, i + 2], [i + 0, i + 2, i + 3]] [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `i` [INFO] [stderr] --> src/text.rs:296:46 [INFO] [stderr] | [INFO] [stderr] 296 | vec![[i + 0, i + 1, i + 2], [i + 0, i + 2, i + 3]] [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(x + y * width) * 4` [INFO] [stderr] --> src/main.rs:109:32 [INFO] [stderr] | [INFO] [stderr] 109 | pixel_data[(x + y * width) * 4 + 0] = 255; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:215:13 [INFO] [stderr] | [INFO] [stderr] 215 | / match event { [INFO] [stderr] 216 | | glutin::Event::WindowEvent { event, .. } => match event { [INFO] [stderr] 217 | | glutin::WindowEvent::CloseRequested => running = false, [INFO] [stderr] 218 | | glutin::WindowEvent::Resized(w, h) => gl_window.resize(w, h), [INFO] [stderr] ... | [INFO] [stderr] 221 | | _ => (), [INFO] [stderr] 222 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 215 | if let glutin::Event::WindowEvent { event, .. } = event { match event { [INFO] [stderr] 216 | glutin::WindowEvent::CloseRequested => running = false, [INFO] [stderr] 217 | glutin::WindowEvent::Resized(w, h) => gl_window.resize(w, h), [INFO] [stderr] 218 | _ => (), [INFO] [stderr] 219 | } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | let mut texture = match gl_basic::Texture::new() { [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] error: Could not compile `android_rust_test`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/text.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | let mut texture = match gl_basic::Texture::new() { [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/text.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | let mut cache = rusttype::gpu_cache::CacheBuilder { [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/text.rs:164:13 [INFO] [stderr] | [INFO] [stderr] 164 | let mut object = match Vertex::new_object(program) { [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/text.rs:169:13 [INFO] [stderr] | [INFO] [stderr] 169 | let mut cache = match GlGlyphCache::new() { [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Vec3` [INFO] [stderr] --> src/gl_basic/types.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | pub struct Vec3 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/gl_basic/shader.rs:27:18 [INFO] [stderr] | [INFO] [stderr] 27 | [std::ffi::CString::new(source).unwrap().as_ptr() as *const _].as_ptr(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::temporary_cstring_as_ptr)] on by default [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/gl_basic/shader.rs:27:18 [INFO] [stderr] | [INFO] [stderr] 27 | [std::ffi::CString::new(source).unwrap().as_ptr() as *const _].as_ptr(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/gl_basic/shader.rs:33:31 [INFO] [stderr] | [INFO] [stderr] 33 | let mut success = gl::FALSE as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/gl_basic/shader.rs:37:27 [INFO] [stderr] | [INFO] [stderr] 37 | if success == gl::TRUE as i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/gl_basic/shader.rs:86:31 [INFO] [stderr] | [INFO] [stderr] 86 | let mut success = gl::FALSE as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/gl_basic/shader.rs:90:27 [INFO] [stderr] | [INFO] [stderr] 90 | if success == gl::TRUE as i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/gl_basic/object.rs:59:21 [INFO] [stderr] | [INFO] [stderr] 59 | / std::ffi::CString::new(attrib.name.clone()) [INFO] [stderr] 60 | | .unwrap() [INFO] [stderr] 61 | | .as_ptr() as *const _, [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/gl_basic/object.rs:59:21 [INFO] [stderr] | [INFO] [stderr] 59 | / std::ffi::CString::new(attrib.name.clone()) [INFO] [stderr] 60 | | .unwrap() [INFO] [stderr] | |_________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/text.rs:94:44 [INFO] [stderr] | [INFO] [stderr] 94 | pub fn cache_glyphs(&mut self, glyphs: &Vec<(usize, &Vec>)>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(usize, &Vec>)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/text.rs:96:17 [INFO] [stderr] | [INFO] [stderr] 96 | for ref glyphs in glyphs { [INFO] [stderr] | ^^^^^^^^^^ ------ help: try: `let glyphs = &glyphs;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/text.rs:192:17 [INFO] [stderr] | [INFO] [stderr] 192 | / match c { [INFO] [stderr] 193 | | '\n' => { [INFO] [stderr] 194 | | caret = point(0.0, caret.y + advance_height); [INFO] [stderr] 195 | | } [INFO] [stderr] 196 | | _ => {} [INFO] [stderr] 197 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 192 | if let '\n' = c { [INFO] [stderr] 193 | caret = point(0.0, caret.y + advance_height); [INFO] [stderr] 194 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `i` [INFO] [stderr] --> src/text.rs:296:23 [INFO] [stderr] | [INFO] [stderr] 296 | vec![[i + 0, i + 1, i + 2], [i + 0, i + 2, i + 3]] [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `i` [INFO] [stderr] --> src/text.rs:296:46 [INFO] [stderr] | [INFO] [stderr] 296 | vec![[i + 0, i + 1, i + 2], [i + 0, i + 2, i + 3]] [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(x + y * width) * 4` [INFO] [stderr] --> src/main.rs:109:32 [INFO] [stderr] | [INFO] [stderr] 109 | pixel_data[(x + y * width) * 4 + 0] = 255; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:215:13 [INFO] [stderr] | [INFO] [stderr] 215 | / match event { [INFO] [stderr] 216 | | glutin::Event::WindowEvent { event, .. } => match event { [INFO] [stderr] 217 | | glutin::WindowEvent::CloseRequested => running = false, [INFO] [stderr] 218 | | glutin::WindowEvent::Resized(w, h) => gl_window.resize(w, h), [INFO] [stderr] ... | [INFO] [stderr] 221 | | _ => (), [INFO] [stderr] 222 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 215 | if let glutin::Event::WindowEvent { event, .. } = event { match event { [INFO] [stderr] 216 | glutin::WindowEvent::CloseRequested => running = false, [INFO] [stderr] 217 | glutin::WindowEvent::Resized(w, h) => gl_window.resize(w, h), [INFO] [stderr] 218 | _ => (), [INFO] [stderr] 219 | } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `android_rust_test`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "7d43d8e119101fd197f421faaeb63bfe434c48031db3475664966bc805504089"` [INFO] running `"docker" "rm" "-f" "7d43d8e119101fd197f421faaeb63bfe434c48031db3475664966bc805504089"` [INFO] [stdout] 7d43d8e119101fd197f421faaeb63bfe434c48031db3475664966bc805504089