[INFO] updating cached repository wmmnola/NumberGuess [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/wmmnola/NumberGuess [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/wmmnola/NumberGuess" "work/ex/clippy-test-run/sources/stable/gh/wmmnola/NumberGuess"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/wmmnola/NumberGuess'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/wmmnola/NumberGuess" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wmmnola/NumberGuess"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wmmnola/NumberGuess'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3cc1a9e1fd3bc731e946c78e4222dcab457e16de [INFO] sha for GitHub repo wmmnola/NumberGuess: 3cc1a9e1fd3bc731e946c78e4222dcab457e16de [INFO] validating manifest of wmmnola/NumberGuess on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wmmnola/NumberGuess on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wmmnola/NumberGuess [INFO] finished frobbing wmmnola/NumberGuess [INFO] frobbed toml for wmmnola/NumberGuess written to work/ex/clippy-test-run/sources/stable/gh/wmmnola/NumberGuess/Cargo.toml [INFO] started frobbing wmmnola/NumberGuess [INFO] finished frobbing wmmnola/NumberGuess [INFO] frobbed toml for wmmnola/NumberGuess written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wmmnola/NumberGuess/Cargo.toml [INFO] crate wmmnola/NumberGuess has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wmmnola/NumberGuess against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/wmmnola/NumberGuess:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a436fe51a3b22c523cac457617fe94925bd3afbe30bb934793cac372c4f8dd71 [INFO] running `"docker" "start" "-a" "a436fe51a3b22c523cac457617fe94925bd3afbe30bb934793cac372c4f8dd71"` [INFO] [stderr] Checking rand v0.3.15 [INFO] [stderr] Checking hello_cargo v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:4:22 [INFO] [stderr] | [INFO] [stderr] 4 | pub const MAX: i32 = 214748364; [INFO] [stderr] | ^^^^^^^^^ help: consider: `214_748_364` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:4:22 [INFO] [stderr] | [INFO] [stderr] 4 | pub const MAX: i32 = 214748364; [INFO] [stderr] | ^^^^^^^^^ help: consider: `214_748_364` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: function is never used: `dialog` [INFO] [stderr] --> src/main.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | fn dialog() -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `guessANumber` [INFO] [stderr] --> src/main.rs:51:1 [INFO] [stderr] | [INFO] [stderr] 51 | fn guessANumber(number: i32 , guess: i32 ) -> bool{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:28:73 [INFO] [stderr] | [INFO] [stderr] 28 | fn computer_guess(upperBound: i32, lowerBound :i32, random: i32, steps: &i32){ [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: variable `upperBound` should have a snake case name such as `upper_bound` [INFO] [stderr] --> src/main.rs:28:19 [INFO] [stderr] | [INFO] [stderr] 28 | fn computer_guess(upperBound: i32, lowerBound :i32, random: i32, steps: &i32){ [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `lowerBound` should have a snake case name such as `lower_bound` [INFO] [stderr] --> src/main.rs:28:36 [INFO] [stderr] | [INFO] [stderr] 28 | fn computer_guess(upperBound: i32, lowerBound :i32, random: i32, steps: &i32){ [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:30:19 [INFO] [stderr] | [INFO] [stderr] 30 | let sum:i64 = (upperBound + lowerBound) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(upperBound + lowerBound)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: variable `oldUpperBound` should have a snake case name such as `old_upper_bound` [INFO] [stderr] --> src/main.rs:35:54 [INFO] [stderr] | [INFO] [stderr] 35 | fn computer_guess_a_number(number: i32 , guess: i32, oldUpperBound: i32, oldLowerBound: i32, steps:i32){ [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `oldLowerBound` should have a snake case name such as `old_lower_bound` [INFO] [stderr] --> src/main.rs:35:74 [INFO] [stderr] | [INFO] [stderr] 35 | fn computer_guess_a_number(number: i32 , guess: i32, oldUpperBound: i32, oldLowerBound: i32, steps:i32){ [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/main.rs:36:15 [INFO] [stderr] | [INFO] [stderr] 36 | let dif = &guess - &number; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 36 | let dif = guess - number; [INFO] [stderr] | ^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function `guessANumber` should have a snake case name such as `guess_anumber` [INFO] [stderr] --> src/main.rs:51:1 [INFO] [stderr] | [INFO] [stderr] 51 | / fn guessANumber(number: i32 , guess: i32 ) -> bool{ [INFO] [stderr] 52 | | if number == guess { [INFO] [stderr] 53 | | return false; [INFO] [stderr] 54 | | } [INFO] [stderr] ... | [INFO] [stderr] 64 | | } [INFO] [stderr] 65 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `dialog` [INFO] [stderr] --> src/main.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | fn dialog() -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `guessANumber` [INFO] [stderr] --> src/main.rs:51:1 [INFO] [stderr] | [INFO] [stderr] 51 | fn guessANumber(number: i32 , guess: i32 ) -> bool{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:28:73 [INFO] [stderr] | [INFO] [stderr] 28 | fn computer_guess(upperBound: i32, lowerBound :i32, random: i32, steps: &i32){ [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: variable `upperBound` should have a snake case name such as `upper_bound` [INFO] [stderr] --> src/main.rs:28:19 [INFO] [stderr] | [INFO] [stderr] 28 | fn computer_guess(upperBound: i32, lowerBound :i32, random: i32, steps: &i32){ [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `lowerBound` should have a snake case name such as `lower_bound` [INFO] [stderr] --> src/main.rs:28:36 [INFO] [stderr] | [INFO] [stderr] 28 | fn computer_guess(upperBound: i32, lowerBound :i32, random: i32, steps: &i32){ [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:30:19 [INFO] [stderr] | [INFO] [stderr] 30 | let sum:i64 = (upperBound + lowerBound) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(upperBound + lowerBound)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: variable `oldUpperBound` should have a snake case name such as `old_upper_bound` [INFO] [stderr] --> src/main.rs:35:54 [INFO] [stderr] | [INFO] [stderr] 35 | fn computer_guess_a_number(number: i32 , guess: i32, oldUpperBound: i32, oldLowerBound: i32, steps:i32){ [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `oldLowerBound` should have a snake case name such as `old_lower_bound` [INFO] [stderr] --> src/main.rs:35:74 [INFO] [stderr] | [INFO] [stderr] 35 | fn computer_guess_a_number(number: i32 , guess: i32, oldUpperBound: i32, oldLowerBound: i32, steps:i32){ [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/main.rs:36:15 [INFO] [stderr] | [INFO] [stderr] 36 | let dif = &guess - &number; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 36 | let dif = guess - number; [INFO] [stderr] | ^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function `guessANumber` should have a snake case name such as `guess_anumber` [INFO] [stderr] --> src/main.rs:51:1 [INFO] [stderr] | [INFO] [stderr] 51 | / fn guessANumber(number: i32 , guess: i32 ) -> bool{ [INFO] [stderr] 52 | | if number == guess { [INFO] [stderr] 53 | | return false; [INFO] [stderr] 54 | | } [INFO] [stderr] ... | [INFO] [stderr] 64 | | } [INFO] [stderr] 65 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.06s [INFO] running `"docker" "inspect" "a436fe51a3b22c523cac457617fe94925bd3afbe30bb934793cac372c4f8dd71"` [INFO] running `"docker" "rm" "-f" "a436fe51a3b22c523cac457617fe94925bd3afbe30bb934793cac372c4f8dd71"` [INFO] [stdout] a436fe51a3b22c523cac457617fe94925bd3afbe30bb934793cac372c4f8dd71