[INFO] updating cached repository wmedrano/synth
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/wmedrano/synth
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/wmedrano/synth" "work/ex/clippy-test-run/sources/stable/gh/wmedrano/synth"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/wmedrano/synth'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/wmedrano/synth" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wmedrano/synth"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wmedrano/synth'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 7c4ca0dc31b96065b23099fccfe6d0e8b69a5d09
[INFO] sha for GitHub repo wmedrano/synth: 7c4ca0dc31b96065b23099fccfe6d0e8b69a5d09
[INFO] validating manifest of wmedrano/synth on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of wmedrano/synth on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing wmedrano/synth
[INFO] finished frobbing wmedrano/synth
[INFO] frobbed toml for wmedrano/synth written to work/ex/clippy-test-run/sources/stable/gh/wmedrano/synth/Cargo.toml
[INFO] started frobbing wmedrano/synth
[INFO] finished frobbing wmedrano/synth
[INFO] frobbed toml for wmedrano/synth written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wmedrano/synth/Cargo.toml
[INFO] crate wmedrano/synth has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting wmedrano/synth against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/wmedrano/synth:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 0d351c8f48153964aed2d7c4437487e6d7f8d16006ddd2628ced767d3f695e7e
[INFO] running `"docker" "start" "-a" "0d351c8f48153964aed2d7c4437487e6d7f8d16006ddd2628ced767d3f695e7e"`
[INFO] [stderr]    Compiling libloading v0.4.3
[INFO] [stderr]     Checking wmidi v0.1.2
[INFO] [stderr]     Checking bincode v1.0.1
[INFO] [stderr]    Compiling syn v0.15.13
[INFO] [stderr]     Checking jack-sys v0.2.0
[INFO] [stderr]     Checking jack v0.6.0
[INFO] [stderr]    Compiling serde_derive v1.0.80
[INFO] [stderr]     Checking fmsynth v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/synth/voice.rs:16:13
[INFO] [stderr]    |
[INFO] [stderr] 16 |             note: note,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `note`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/synth/voice.rs:16:13
[INFO] [stderr]    |
[INFO] [stderr] 16 |             note: note,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `note`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `envelope::Envelope`
[INFO] [stderr]   --> src/envelope.rs:39:5
[INFO] [stderr]    |
[INFO] [stderr] 39 | /     pub fn new() -> Envelope {
[INFO] [stderr] 40 | |         Envelope {
[INFO] [stderr] 41 | |             stage: Stage::Attack,
[INFO] [stderr] 42 | |             val: 0.0,
[INFO] [stderr] 43 | |         }
[INFO] [stderr] 44 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 38 | impl Default for envelope::Envelope {
[INFO] [stderr] 39 |     fn default() -> Self {
[INFO] [stderr] 40 |         Self::new()
[INFO] [stderr] 41 |     }
[INFO] [stderr] 42 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/envelope.rs:54:15
[INFO] [stderr]    |
[INFO] [stderr] 54 |         match self.stage.clone() {
[INFO] [stderr]    |               ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.stage`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/envelope.rs:90:20
[INFO] [stderr]    |
[INFO] [stderr] 90 |     pub fn is_done(&self) -> bool {
[INFO] [stderr]    |                    ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name
[INFO] [stderr]   --> src/oscillator.rs:21:5
[INFO] [stderr]    |
[INFO] [stderr] 21 | /     pub fn next(&mut self) -> f32 {
[INFO] [stderr] 22 | |         self.phase = self.phase + self.phase_delta;
[INFO] [stderr] 23 | |         fast_sin(self.phase.rads())
[INFO] [stderr] 24 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::should_implement_trait)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/phase.rs:19:17
[INFO] [stderr]    |
[INFO] [stderr] 19 |     pub fn rads(&self) -> f32 {
[INFO] [stderr]    |                 ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `envelope::Envelope`
[INFO] [stderr]   --> src/envelope.rs:39:5
[INFO] [stderr]    |
[INFO] [stderr] 39 | /     pub fn new() -> Envelope {
[INFO] [stderr] 40 | |         Envelope {
[INFO] [stderr] 41 | |             stage: Stage::Attack,
[INFO] [stderr] 42 | |             val: 0.0,
[INFO] [stderr] 43 | |         }
[INFO] [stderr] 44 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 38 | impl Default for envelope::Envelope {
[INFO] [stderr] 39 |     fn default() -> Self {
[INFO] [stderr] 40 |         Self::new()
[INFO] [stderr] 41 |     }
[INFO] [stderr] 42 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/envelope.rs:54:15
[INFO] [stderr]    |
[INFO] [stderr] 54 |         match self.stage.clone() {
[INFO] [stderr]    |               ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.stage`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/envelope.rs:90:20
[INFO] [stderr]    |
[INFO] [stderr] 90 |     pub fn is_done(&self) -> bool {
[INFO] [stderr]    |                    ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name
[INFO] [stderr]   --> src/oscillator.rs:21:5
[INFO] [stderr]    |
[INFO] [stderr] 21 | /     pub fn next(&mut self) -> f32 {
[INFO] [stderr] 22 | |         self.phase = self.phase + self.phase_delta;
[INFO] [stderr] 23 | |         fast_sin(self.phase.rads())
[INFO] [stderr] 24 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::should_implement_trait)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/phase.rs:19:17
[INFO] [stderr]    |
[INFO] [stderr] 19 |     pub fn rads(&self) -> f32 {
[INFO] [stderr]    |                 ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: casting i8 to f32 may become silently lossy if types change
[INFO] [stderr]   --> src/synth/voice.rs:81:15
[INFO] [stderr]    |
[INFO] [stderr] 81 |     let exp = (note as i8 - 69) as f32 / 12.0;
[INFO] [stderr]    |               ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(note as i8 - 69)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name
[INFO] [stderr]   --> src/synth/mod.rs:23:5
[INFO] [stderr]    |
[INFO] [stderr] 23 | /     pub fn next(&mut self) -> f32 {
[INFO] [stderr] 24 | |         let mut out = 0.0;
[INFO] [stderr] 25 | |         let mut clean_voices = false;
[INFO] [stderr] 26 | |         for v in self.voices.iter_mut() {
[INFO] [stderr] ...  |
[INFO] [stderr] 36 | |         out * self.params.out
[INFO] [stderr] 37 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: casting i8 to f32 may become silently lossy if types change
[INFO] [stderr]   --> src/synth/voice.rs:81:15
[INFO] [stderr]    |
[INFO] [stderr] 81 |     let exp = (note as i8 - 69) as f32 / 12.0;
[INFO] [stderr]    |               ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(note as i8 - 69)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name
[INFO] [stderr]   --> src/synth/mod.rs:23:5
[INFO] [stderr]    |
[INFO] [stderr] 23 | /     pub fn next(&mut self) -> f32 {
[INFO] [stderr] 24 | |         let mut out = 0.0;
[INFO] [stderr] 25 | |         let mut clean_voices = false;
[INFO] [stderr] 26 | |         for v in self.voices.iter_mut() {
[INFO] [stderr] ...  |
[INFO] [stderr] 36 | |         out * self.params.out
[INFO] [stderr] 37 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 22.13s
[INFO] running `"docker" "inspect" "0d351c8f48153964aed2d7c4437487e6d7f8d16006ddd2628ced767d3f695e7e"`
[INFO] running `"docker" "rm" "-f" "0d351c8f48153964aed2d7c4437487e6d7f8d16006ddd2628ced767d3f695e7e"`
[INFO] [stdout] 0d351c8f48153964aed2d7c4437487e6d7f8d16006ddd2628ced767d3f695e7e