[INFO] updating cached repository wismer/rs_torrent [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/wismer/rs_torrent [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/wismer/rs_torrent" "work/ex/clippy-test-run/sources/stable/gh/wismer/rs_torrent"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/wismer/rs_torrent'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/wismer/rs_torrent" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wismer/rs_torrent"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wismer/rs_torrent'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b5209285c8f76a2d44e128239d0b79fb81d93081 [INFO] sha for GitHub repo wismer/rs_torrent: b5209285c8f76a2d44e128239d0b79fb81d93081 [INFO] validating manifest of wismer/rs_torrent on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wismer/rs_torrent on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wismer/rs_torrent [INFO] finished frobbing wismer/rs_torrent [INFO] frobbed toml for wismer/rs_torrent written to work/ex/clippy-test-run/sources/stable/gh/wismer/rs_torrent/Cargo.toml [INFO] started frobbing wismer/rs_torrent [INFO] finished frobbing wismer/rs_torrent [INFO] frobbed toml for wismer/rs_torrent written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wismer/rs_torrent/Cargo.toml [INFO] crate wismer/rs_torrent has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wismer/rs_torrent against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/wismer/rs_torrent:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] eb8f247c60e3cb37f488872ac188447a714d0d314042d27e1d78660e55ea7ca4 [INFO] running `"docker" "start" "-a" "eb8f247c60e3cb37f488872ac188447a714d0d314042d27e1d78660e55ea7ca4"` [INFO] [stderr] Checking byteorder v1.2.4 [INFO] [stderr] Checking futures v0.1.23 [INFO] [stderr] Compiling httparse v1.3.2 [INFO] [stderr] Checking try-lock v0.2.2 [INFO] [stderr] Checking string v0.1.1 [INFO] [stderr] Checking rand v0.4.3 [INFO] [stderr] Checking crossbeam-utils v0.3.2 [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Checking log v0.4.4 [INFO] [stderr] Checking uuid v0.6.5 [INFO] [stderr] Checking crossbeam-epoch v0.4.3 [INFO] [stderr] Checking backtrace v0.3.9 [INFO] [stderr] Checking bytes v0.4.9 [INFO] [stderr] Checking mio v0.6.15 [INFO] [stderr] Checking crossbeam-deque v0.3.1 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking bip_bencode v0.4.4 [INFO] [stderr] Checking http v0.1.10 [INFO] [stderr] Checking tokio-executor v0.1.3 [INFO] [stderr] Checking tokio-io v0.1.7 [INFO] [stderr] Checking want v0.0.6 [INFO] [stderr] Checking futures-cpupool v0.1.8 [INFO] [stderr] Checking tokio-threadpool v0.1.5 [INFO] [stderr] Checking tokio-timer v0.2.5 [INFO] [stderr] Checking tokio-codec v0.1.0 [INFO] [stderr] Checking tokio-reactor v0.1.3 [INFO] [stderr] Checking tokio-fs v0.1.3 [INFO] [stderr] Checking tokio-tcp v0.1.1 [INFO] [stderr] Checking tokio-udp v0.1.1 [INFO] [stderr] Checking tokio v0.1.7 [INFO] [stderr] Checking h2 v0.1.12 [INFO] [stderr] Checking hyper v0.12.8 [INFO] [stderr] Checking rs_bittorrent v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/torrent/torrent.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | files: files, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `files` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/torrent/torrent.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | piece_length: piece_length, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `piece_length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/torrent/torrent.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | files: files, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `files` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/torrent/torrent.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | piece_length: piece_length, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `piece_length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/torrent/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub mod torrent; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unused variable: `torrent` [INFO] [stderr] --> src/main.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | let torrent = Torrent::new(&torrent_content); [INFO] [stderr] | ^^^^^^^ help: consider using `_torrent` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `announce_list` [INFO] [stderr] --> src/torrent/torrent.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | let announce_list = dict.lookup(b"announce-list").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using `_announce_list` instead [INFO] [stderr] [INFO] [stderr] warning: method is never used: `tracker_query_params` [INFO] [stderr] --> src/torrent/torrent.rs:61:5 [INFO] [stderr] | [INFO] [stderr] 61 | fn tracker_query_params(&self) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/torrent/torrent.rs:36:39 [INFO] [stderr] | [INFO] [stderr] 36 | let files: Vec = info.dict().unwrap().lookup(b"files").unwrap() [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 37 | | .list().unwrap() [INFO] [stderr] 38 | | .clone() [INFO] [stderr] | |____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 36 | let files: Vec = &(*info.dict().unwrap().lookup(b"files").unwrap() [INFO] [stderr] 37 | .list().unwrap()).clone() [INFO] [stderr] | [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 36 | let files: Vec = &dyn bip_bencode::BListAccess>::clone(info.dict().unwrap().lookup(b"files").unwrap() [INFO] [stderr] 37 | .list().unwrap()) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/torrent/torrent.rs:71:21 [INFO] [stderr] | [INFO] [stderr] 71 | let file_path = bencode_ref.dict().unwrap().lookup(b"path").unwrap().list().unwrap() [INFO] [stderr] | _____________________^ [INFO] [stderr] 72 | | .clone() [INFO] [stderr] | |________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 71 | let file_path = &(*bencode_ref.dict().unwrap().lookup(b"path").unwrap().list().unwrap()).clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 71 | let file_path = &dyn bip_bencode::BListAccess>::clone(bencode_ref.dict().unwrap().lookup(b"path").unwrap().list().unwrap()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | torrent_file.read_to_end(&mut contents); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rs_bittorrent`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/torrent/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub mod torrent; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unused variable: `torrent` [INFO] [stderr] --> src/main.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | let torrent = Torrent::new(&torrent_content); [INFO] [stderr] | ^^^^^^^ help: consider using `_torrent` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `announce_list` [INFO] [stderr] --> src/torrent/torrent.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | let announce_list = dict.lookup(b"announce-list").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using `_announce_list` instead [INFO] [stderr] [INFO] [stderr] warning: method is never used: `tracker_query_params` [INFO] [stderr] --> src/torrent/torrent.rs:61:5 [INFO] [stderr] | [INFO] [stderr] 61 | fn tracker_query_params(&self) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/torrent/torrent.rs:36:39 [INFO] [stderr] | [INFO] [stderr] 36 | let files: Vec = info.dict().unwrap().lookup(b"files").unwrap() [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 37 | | .list().unwrap() [INFO] [stderr] 38 | | .clone() [INFO] [stderr] | |____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 36 | let files: Vec = &(*info.dict().unwrap().lookup(b"files").unwrap() [INFO] [stderr] 37 | .list().unwrap()).clone() [INFO] [stderr] | [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 36 | let files: Vec = &dyn bip_bencode::BListAccess>::clone(info.dict().unwrap().lookup(b"files").unwrap() [INFO] [stderr] 37 | .list().unwrap()) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/torrent/torrent.rs:71:21 [INFO] [stderr] | [INFO] [stderr] 71 | let file_path = bencode_ref.dict().unwrap().lookup(b"path").unwrap().list().unwrap() [INFO] [stderr] | _____________________^ [INFO] [stderr] 72 | | .clone() [INFO] [stderr] | |________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 71 | let file_path = &(*bencode_ref.dict().unwrap().lookup(b"path").unwrap().list().unwrap()).clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 71 | let file_path = &dyn bip_bencode::BListAccess>::clone(bencode_ref.dict().unwrap().lookup(b"path").unwrap().list().unwrap()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | torrent_file.read_to_end(&mut contents); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rs_bittorrent`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "eb8f247c60e3cb37f488872ac188447a714d0d314042d27e1d78660e55ea7ca4"` [INFO] running `"docker" "rm" "-f" "eb8f247c60e3cb37f488872ac188447a714d0d314042d27e1d78660e55ea7ca4"` [INFO] [stdout] eb8f247c60e3cb37f488872ac188447a714d0d314042d27e1d78660e55ea7ca4