[INFO] updating cached repository wimpykid26/rust-examples [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/wimpykid26/rust-examples [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/wimpykid26/rust-examples" "work/ex/clippy-test-run/sources/stable/gh/wimpykid26/rust-examples"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/wimpykid26/rust-examples'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/wimpykid26/rust-examples" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wimpykid26/rust-examples"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wimpykid26/rust-examples'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] bff1d8f9f6d4c8f38a1297896ecc0afa4860467f [INFO] sha for GitHub repo wimpykid26/rust-examples: bff1d8f9f6d4c8f38a1297896ecc0afa4860467f [INFO] validating manifest of wimpykid26/rust-examples on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wimpykid26/rust-examples on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wimpykid26/rust-examples [INFO] finished frobbing wimpykid26/rust-examples [INFO] frobbed toml for wimpykid26/rust-examples written to work/ex/clippy-test-run/sources/stable/gh/wimpykid26/rust-examples/Cargo.toml [INFO] started frobbing wimpykid26/rust-examples [INFO] finished frobbing wimpykid26/rust-examples [INFO] frobbed toml for wimpykid26/rust-examples written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wimpykid26/rust-examples/Cargo.toml [INFO] crate wimpykid26/rust-examples has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wimpykid26/rust-examples against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/wimpykid26/rust-examples:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2368733f326f0a42f1db4c9edc42a7608ba190ce4b22d16405959e2027763669 [INFO] running `"docker" "start" "-a" "2368733f326f0a42f1db4c9edc42a7608ba190ce4b22d16405959e2027763669"` [INFO] [stderr] Checking rust-examples v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/functions/simple_function.rs:13:21 [INFO] [stderr] | [INFO] [stderr] 13 | fn fizzbuzz(n: u32) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/functions/simple_function.rs:13:21 [INFO] [stderr] | [INFO] [stderr] 13 | fn fizzbuzz(n: u32) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unreachable statement [INFO] [stderr] --> src/expressions/loops.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | println!("This point will never be reached"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unreachable statement [INFO] [stderr] --> src/expressions/loops.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | println!("This point will never be reached"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/expressions/match_cases.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | 1 | 2 | 3 => println!("This is either 1, 2 or 3"), [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_patterns)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `reference` [INFO] [stderr] --> src/expressions/match_cases.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | let ref reference = 5; [INFO] [stderr] | ^^^^^^^^^ help: consider using `_reference` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/expressions/match_cases.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | 1 | 2 | 3 => println!("This is either 1, 2 or 3"), [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_patterns)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `reference` [INFO] [stderr] --> src/expressions/match_cases.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | let ref reference = 5; [INFO] [stderr] | ^^^^^^^^^ help: consider using `_reference` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/expressions/loops.rs:5:9 [INFO] [stderr] | [INFO] [stderr] 5 | count = count + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `count += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unused label `'inner` [INFO] [stderr] --> src/expressions/loops.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | / 'inner: loop { [INFO] [stderr] 24 | | println!("Entered the inner body"); [INFO] [stderr] 25 | | break 'outer; [INFO] [stderr] 26 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_label)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/expressions/loops.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | / 'inner: loop { [INFO] [stderr] 24 | | println!("Entered the inner body"); [INFO] [stderr] 25 | | break 'outer; [INFO] [stderr] 26 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/expressions/loops.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `counter += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/expressions/loops.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | / match name { [INFO] [stderr] 54 | | &"John" => println!("Hi My name is {}", name), [INFO] [stderr] 55 | | _ => println!("Some other name"), [INFO] [stderr] 56 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 53 | match *name { [INFO] [stderr] 54 | "John" => println!("Hi My name is {}", name), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/expressions/match_cases.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / match value { [INFO] [stderr] 23 | | &val => println!("Got a value from a reference {:?}", val), [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 22 | match *value { [INFO] [stderr] 23 | val => println!("Got a value from a reference {:?}", val), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/expressions/match_cases.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | let ref reference = 5; [INFO] [stderr] | ----^^^^^^^^^^^^^----- help: try: `let reference = &5;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let x =` [INFO] [stderr] --> src/expressions/match_cases.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | / let x = match value_2 { [INFO] [stderr] 43 | | ref mut m => { [INFO] [stderr] 44 | | *m = *m + 10; [INFO] [stderr] 45 | | } [INFO] [stderr] 46 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/expressions/match_cases.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | *m = *m + 10; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `*m += 10` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: some ranges overlap [INFO] [stderr] --> src/expressions/match_cases.rs:76:9 [INFO] [stderr] | [INFO] [stderr] 76 | 1 => println!("This is a singular value"), [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_overlapping_arm)] on by default [INFO] [stderr] note: overlaps with this [INFO] [stderr] --> src/expressions/match_cases.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | 1 | 2 | 3 => println!("This is either 1, 2 or 3"), [INFO] [stderr] | ^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/expressions/match_cases.rs:84:18 [INFO] [stderr] | [INFO] [stderr] 84 | let binary = match boolean { [INFO] [stderr] | __________________^ [INFO] [stderr] 85 | | //Should provide all match cases [INFO] [stderr] 86 | | false => 0, [INFO] [stderr] 87 | | true => 1, [INFO] [stderr] 88 | | }; [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if boolean { 1 } else { 0 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions/closures.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | count = count + 10; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `count += 10` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/functions/hof.rs:10:48 [INFO] [stderr] | [INFO] [stderr] 10 | .filter(|&n_squared| is_odd(n_squared)) [INFO] [stderr] | ________________________________________________^ [INFO] [stderr] 11 | | .fold(0, |acc, n_squared| acc + n_squared); [INFO] [stderr] | |__________________________________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/functions/simple_function.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / match divisible_by(n, 20) { [INFO] [stderr] 15 | | true => println!("Numbers are mutually divisible"), [INFO] [stderr] 16 | | false => println!("Numbers are not mutually divisible"), [INFO] [stderr] 17 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if divisible_by(n, 20) { println!("Numbers are mutually divisible") } else { println!("Numbers are not mutually divisible") }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust-examples`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/expressions/loops.rs:5:9 [INFO] [stderr] | [INFO] [stderr] 5 | count = count + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `count += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unused label `'inner` [INFO] [stderr] --> src/expressions/loops.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | / 'inner: loop { [INFO] [stderr] 24 | | println!("Entered the inner body"); [INFO] [stderr] 25 | | break 'outer; [INFO] [stderr] 26 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_label)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/expressions/loops.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | / 'inner: loop { [INFO] [stderr] 24 | | println!("Entered the inner body"); [INFO] [stderr] 25 | | break 'outer; [INFO] [stderr] 26 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/expressions/loops.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `counter += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/expressions/loops.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | / match name { [INFO] [stderr] 54 | | &"John" => println!("Hi My name is {}", name), [INFO] [stderr] 55 | | _ => println!("Some other name"), [INFO] [stderr] 56 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 53 | match *name { [INFO] [stderr] 54 | "John" => println!("Hi My name is {}", name), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/expressions/match_cases.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / match value { [INFO] [stderr] 23 | | &val => println!("Got a value from a reference {:?}", val), [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 22 | match *value { [INFO] [stderr] 23 | val => println!("Got a value from a reference {:?}", val), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/expressions/match_cases.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | let ref reference = 5; [INFO] [stderr] | ----^^^^^^^^^^^^^----- help: try: `let reference = &5;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let x =` [INFO] [stderr] --> src/expressions/match_cases.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | / let x = match value_2 { [INFO] [stderr] 43 | | ref mut m => { [INFO] [stderr] 44 | | *m = *m + 10; [INFO] [stderr] 45 | | } [INFO] [stderr] 46 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/expressions/match_cases.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | *m = *m + 10; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `*m += 10` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: some ranges overlap [INFO] [stderr] --> src/expressions/match_cases.rs:76:9 [INFO] [stderr] | [INFO] [stderr] 76 | 1 => println!("This is a singular value"), [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_overlapping_arm)] on by default [INFO] [stderr] note: overlaps with this [INFO] [stderr] --> src/expressions/match_cases.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | 1 | 2 | 3 => println!("This is either 1, 2 or 3"), [INFO] [stderr] | ^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/expressions/match_cases.rs:84:18 [INFO] [stderr] | [INFO] [stderr] 84 | let binary = match boolean { [INFO] [stderr] | __________________^ [INFO] [stderr] 85 | | //Should provide all match cases [INFO] [stderr] 86 | | false => 0, [INFO] [stderr] 87 | | true => 1, [INFO] [stderr] 88 | | }; [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if boolean { 1 } else { 0 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions/closures.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | count = count + 10; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `count += 10` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/functions/hof.rs:10:48 [INFO] [stderr] | [INFO] [stderr] 10 | .filter(|&n_squared| is_odd(n_squared)) [INFO] [stderr] | ________________________________________________^ [INFO] [stderr] 11 | | .fold(0, |acc, n_squared| acc + n_squared); [INFO] [stderr] | |__________________________________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/functions/simple_function.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / match divisible_by(n, 20) { [INFO] [stderr] 15 | | true => println!("Numbers are mutually divisible"), [INFO] [stderr] 16 | | false => println!("Numbers are not mutually divisible"), [INFO] [stderr] 17 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if divisible_by(n, 20) { println!("Numbers are mutually divisible") } else { println!("Numbers are not mutually divisible") }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust-examples`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "2368733f326f0a42f1db4c9edc42a7608ba190ce4b22d16405959e2027763669"` [INFO] running `"docker" "rm" "-f" "2368733f326f0a42f1db4c9edc42a7608ba190ce4b22d16405959e2027763669"` [INFO] [stdout] 2368733f326f0a42f1db4c9edc42a7608ba190ce4b22d16405959e2027763669