[INFO] updating cached repository williamsandrew/carnac [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/williamsandrew/carnac [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/williamsandrew/carnac" "work/ex/clippy-test-run/sources/stable/gh/williamsandrew/carnac"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/williamsandrew/carnac'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/williamsandrew/carnac" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/williamsandrew/carnac"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/williamsandrew/carnac'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8b49f0c35fa0601d47938d9b483c58e3bb7f1f07 [INFO] sha for GitHub repo williamsandrew/carnac: 8b49f0c35fa0601d47938d9b483c58e3bb7f1f07 [INFO] validating manifest of williamsandrew/carnac on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of williamsandrew/carnac on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing williamsandrew/carnac [INFO] finished frobbing williamsandrew/carnac [INFO] frobbed toml for williamsandrew/carnac written to work/ex/clippy-test-run/sources/stable/gh/williamsandrew/carnac/Cargo.toml [INFO] started frobbing williamsandrew/carnac [INFO] finished frobbing williamsandrew/carnac [INFO] frobbed toml for williamsandrew/carnac written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/williamsandrew/carnac/Cargo.toml [INFO] crate williamsandrew/carnac has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting williamsandrew/carnac against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/williamsandrew/carnac:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4c1b92654f956d77008e515ed3969d78ebb27607b467954b119d3b82646d8ac2 [INFO] running `"docker" "start" "-a" "4c1b92654f956d77008e515ed3969d78ebb27607b467954b119d3b82646d8ac2"` [INFO] [stderr] Compiling rust-crypto v0.2.36 [INFO] [stderr] Checking rand v0.3.14 [INFO] [stderr] Checking snap v0.1.2 [INFO] [stderr] Checking carnac v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:20:25 [INFO] [stderr] | [INFO] [stderr] 20 | let mut buf = match env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:20:25 [INFO] [stderr] | [INFO] [stderr] 20 | let mut buf = match env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:21:25 [INFO] [stderr] | [INFO] [stderr] 21 | Some(path) => { PathBuf::from(path) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `path` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:138:5 [INFO] [stderr] | [INFO] [stderr] 138 | / match io::copy(&mut new_io, &mut child_in) { [INFO] [stderr] 139 | | // TODO handle broken pipes [INFO] [stderr] 140 | | Err(why) => panic!("copy err: {}", why.description()), [INFO] [stderr] 141 | | Ok(_) => {}, [INFO] [stderr] 142 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(why) = io::copy(&mut new_io, &mut child_in) { panic!("copy err: {}", why.description()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:21:25 [INFO] [stderr] | [INFO] [stderr] 21 | Some(path) => { PathBuf::from(path) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `path` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:138:5 [INFO] [stderr] | [INFO] [stderr] 138 | / match io::copy(&mut new_io, &mut child_in) { [INFO] [stderr] 139 | | // TODO handle broken pipes [INFO] [stderr] 140 | | Err(why) => panic!("copy err: {}", why.description()), [INFO] [stderr] 141 | | Ok(_) => {}, [INFO] [stderr] 142 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(why) = io::copy(&mut new_io, &mut child_in) { panic!("copy err: {}", why.description()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.16s [INFO] running `"docker" "inspect" "4c1b92654f956d77008e515ed3969d78ebb27607b467954b119d3b82646d8ac2"` [INFO] running `"docker" "rm" "-f" "4c1b92654f956d77008e515ed3969d78ebb27607b467954b119d3b82646d8ac2"` [INFO] [stdout] 4c1b92654f956d77008e515ed3969d78ebb27607b467954b119d3b82646d8ac2