[INFO] updating cached repository wilkes/churn-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/wilkes/churn-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/wilkes/churn-rs" "work/ex/clippy-test-run/sources/stable/gh/wilkes/churn-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/wilkes/churn-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/wilkes/churn-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wilkes/churn-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wilkes/churn-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] cd6b43066462807d2a3149cf3bef3048c77e50d1 [INFO] sha for GitHub repo wilkes/churn-rs: cd6b43066462807d2a3149cf3bef3048c77e50d1 [INFO] validating manifest of wilkes/churn-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wilkes/churn-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wilkes/churn-rs [INFO] finished frobbing wilkes/churn-rs [INFO] frobbed toml for wilkes/churn-rs written to work/ex/clippy-test-run/sources/stable/gh/wilkes/churn-rs/Cargo.toml [INFO] started frobbing wilkes/churn-rs [INFO] finished frobbing wilkes/churn-rs [INFO] frobbed toml for wilkes/churn-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wilkes/churn-rs/Cargo.toml [INFO] crate wilkes/churn-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wilkes/churn-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/wilkes/churn-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7b2c060730e471371734d6b125ebd3395a606e90212a99f727d50e372732b620 [INFO] running `"docker" "start" "-a" "7b2c060730e471371734d6b125ebd3395a606e90212a99f727d50e372732b620"` [INFO] [stderr] Compiling cc v1.0.4 [INFO] [stderr] Checking regex-syntax v0.4.2 [INFO] [stderr] Checking memchr v2.0.1 [INFO] [stderr] Checking aho-corasick v0.6.4 [INFO] [stderr] Compiling libz-sys v1.0.18 [INFO] [stderr] Compiling openssl-sys v0.9.24 [INFO] [stderr] Compiling cmake v0.1.29 [INFO] [stderr] Compiling curl-sys v0.4.1 [INFO] [stderr] Checking regex v0.2.5 [INFO] [stderr] Compiling libssh2-sys v0.2.6 [INFO] [stderr] Compiling libgit2-sys v0.6.19 [INFO] [stderr] Checking docopt v0.8.3 [INFO] [stderr] Checking git2 v0.6.11 [INFO] [stderr] Checking churn v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:162:19 [INFO] [stderr] | [INFO] [stderr] 162 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:162:19 [INFO] [stderr] | [INFO] [stderr] 162 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:83:54 [INFO] [stderr] | [INFO] [stderr] 83 | get_mut_or_create_with(&mut self.dirs, name, || DirData::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `DirData::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:115:80 [INFO] [stderr] | [INFO] [stderr] 115 | let hashes = get_mut_or_create_with(&mut self.files, name, || HashSet::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `HashSet::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:83:54 [INFO] [stderr] | [INFO] [stderr] 83 | get_mut_or_create_with(&mut self.dirs, name, || DirData::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `DirData::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: the variable `n` is used as a loop counter. Consider using `for (n, item) in revwalk.enumerate()` or similar iterators [INFO] [stderr] --> src/main.rs:138:15 [INFO] [stderr] | [INFO] [stderr] 138 | for id in revwalk { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:115:80 [INFO] [stderr] | [INFO] [stderr] 115 | let hashes = get_mut_or_create_with(&mut self.files, name, || HashSet::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `HashSet::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: the variable `n` is used as a loop counter. Consider using `for (n, item) in revwalk.enumerate()` or similar iterators [INFO] [stderr] --> src/main.rs:138:15 [INFO] [stderr] | [INFO] [stderr] 138 | for id in revwalk { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3m 16s [INFO] running `"docker" "inspect" "7b2c060730e471371734d6b125ebd3395a606e90212a99f727d50e372732b620"` [INFO] running `"docker" "rm" "-f" "7b2c060730e471371734d6b125ebd3395a606e90212a99f727d50e372732b620"` [INFO] [stdout] 7b2c060730e471371734d6b125ebd3395a606e90212a99f727d50e372732b620