[INFO] updating cached repository wildarch/toy-compiler [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/wildarch/toy-compiler [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/wildarch/toy-compiler" "work/ex/clippy-test-run/sources/stable/gh/wildarch/toy-compiler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/wildarch/toy-compiler'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/wildarch/toy-compiler" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wildarch/toy-compiler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wildarch/toy-compiler'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d82ff5478bebc42b608cdffaeaf24fb77fc93509 [INFO] sha for GitHub repo wildarch/toy-compiler: d82ff5478bebc42b608cdffaeaf24fb77fc93509 [INFO] validating manifest of wildarch/toy-compiler on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wildarch/toy-compiler on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wildarch/toy-compiler [INFO] finished frobbing wildarch/toy-compiler [INFO] frobbed toml for wildarch/toy-compiler written to work/ex/clippy-test-run/sources/stable/gh/wildarch/toy-compiler/Cargo.toml [INFO] started frobbing wildarch/toy-compiler [INFO] finished frobbing wildarch/toy-compiler [INFO] frobbed toml for wildarch/toy-compiler written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wildarch/toy-compiler/Cargo.toml [INFO] crate wildarch/toy-compiler has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wildarch/toy-compiler against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/wildarch/toy-compiler:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e9c73e995d8eee914d3a34864d4c5fb6f8eab2c0cc68321d3edf27dd24756f95 [INFO] running `"docker" "start" "-a" "e9c73e995d8eee914d3a34864d4c5fb6f8eab2c0cc68321d3edf27dd24756f95"` [INFO] [stderr] Compiling names v0.11.0 [INFO] [stderr] Checking rand v0.4.3 [INFO] [stderr] Checking memchr v2.0.1 [INFO] [stderr] Checking nom v4.0.0 [INFO] [stderr] Checking rand v0.3.22 [INFO] [stderr] Checking toy-compiler v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `writeln!(f, "")` [INFO] [stderr] --> src/compile_mips.rs:399:13 [INFO] [stderr] | [INFO] [stderr] 399 | writeln!(f, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(f)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(f, "")` [INFO] [stderr] --> src/compile_mips.rs:399:13 [INFO] [stderr] | [INFO] [stderr] 399 | writeln!(f, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(f)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/compile_mips.rs:108:9 [INFO] [stderr] | [INFO] [stderr] 108 | r [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/compile_mips.rs:104:17 [INFO] [stderr] | [INFO] [stderr] 104 | let r = self [INFO] [stderr] | _________________^ [INFO] [stderr] 105 | | .free_temp_regs [INFO] [stderr] 106 | | .pop() [INFO] [stderr] 107 | | .expect("No more registers available"); [INFO] [stderr] | |__________________________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parse/identifier.rs:7:18 [INFO] [stderr] | [INFO] [stderr] 7 | const KEYWORDS: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parse/identifier.rs:7:28 [INFO] [stderr] | [INFO] [stderr] 7 | const KEYWORDS: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/transpile_js/identifier.rs:3:21 [INFO] [stderr] | [INFO] [stderr] 3 | const JS_KEYWORDS: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/transpile_js/identifier.rs:3:31 [INFO] [stderr] | [INFO] [stderr] 3 | const JS_KEYWORDS: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/transpile_js/mod.rs:13:22 [INFO] [stderr] | [INFO] [stderr] 13 | const STANDARD_LIB: &'static str = r#" [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/transpile_js/mod.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | return program; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `program` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/compile_mips.rs:108:9 [INFO] [stderr] | [INFO] [stderr] 108 | r [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/compile_mips.rs:104:17 [INFO] [stderr] | [INFO] [stderr] 104 | let r = self [INFO] [stderr] | _________________^ [INFO] [stderr] 105 | | .free_temp_regs [INFO] [stderr] 106 | | .pop() [INFO] [stderr] 107 | | .expect("No more registers available"); [INFO] [stderr] | |__________________________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parse/identifier.rs:7:18 [INFO] [stderr] | [INFO] [stderr] 7 | const KEYWORDS: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parse/identifier.rs:7:28 [INFO] [stderr] | [INFO] [stderr] 7 | const KEYWORDS: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/transpile_js/identifier.rs:3:21 [INFO] [stderr] | [INFO] [stderr] 3 | const JS_KEYWORDS: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/transpile_js/identifier.rs:3:31 [INFO] [stderr] | [INFO] [stderr] 3 | const JS_KEYWORDS: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/transpile_js/mod.rs:13:22 [INFO] [stderr] | [INFO] [stderr] 13 | const STANDARD_LIB: &'static str = r#" [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/transpile_js/mod.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | return program; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `program` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parse/expression.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | |s| Expr::Ident(s) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Expr::Ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parse/expression.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | |s| Expr::Ident(s) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Expr::Ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parse/literal.rs:73:9 [INFO] [stderr] | [INFO] [stderr] 73 | |s: Vec| List(s) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `List` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parse/literal.rs:73:9 [INFO] [stderr] | [INFO] [stderr] 73 | |s: Vec| List(s) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `List` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parse/mod.rs:27:1 [INFO] [stderr] | [INFO] [stderr] 27 | / pub fn parse<'a>(input: &'a str) -> Result>> { [INFO] [stderr] 28 | | document(input.into()).map(|(_i, r)| r) [INFO] [stderr] 29 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/transpile_js/expression.rs:9:56 [INFO] [stderr] | [INFO] [stderr] 9 | let args_trans: Vec = args.into_iter().map(|e| transpile_expr(e)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `transpile_expr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/transpile_js/expression.rs:50:36 [INFO] [stderr] | [INFO] [stderr] 50 | Box::new(Lit(Float(3.14))) [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/transpile_js/if_cond.rs:9:8 [INFO] [stderr] | [INFO] [stderr] 9 | if if_cond.cases.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `if_cond.cases.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parse/mod.rs:27:1 [INFO] [stderr] | [INFO] [stderr] 27 | / pub fn parse<'a>(input: &'a str) -> Result>> { [INFO] [stderr] 28 | | document(input.into()).map(|(_i, r)| r) [INFO] [stderr] 29 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/transpile_js/expression.rs:9:56 [INFO] [stderr] | [INFO] [stderr] 9 | let args_trans: Vec = args.into_iter().map(|e| transpile_expr(e)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `transpile_expr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `toy-compiler`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/transpile_js/if_cond.rs:9:8 [INFO] [stderr] | [INFO] [stderr] 9 | if if_cond.cases.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `if_cond.cases.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "e9c73e995d8eee914d3a34864d4c5fb6f8eab2c0cc68321d3edf27dd24756f95"` [INFO] running `"docker" "rm" "-f" "e9c73e995d8eee914d3a34864d4c5fb6f8eab2c0cc68321d3edf27dd24756f95"` [INFO] [stdout] e9c73e995d8eee914d3a34864d4c5fb6f8eab2c0cc68321d3edf27dd24756f95