[INFO] updating cached repository wilcoxky/rust-hw04 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/wilcoxky/rust-hw04 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/wilcoxky/rust-hw04" "work/ex/clippy-test-run/sources/stable/gh/wilcoxky/rust-hw04"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/wilcoxky/rust-hw04'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/wilcoxky/rust-hw04" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wilcoxky/rust-hw04"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wilcoxky/rust-hw04'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2567a8394af35830fbaf522f223c6e485873bd3e [INFO] sha for GitHub repo wilcoxky/rust-hw04: 2567a8394af35830fbaf522f223c6e485873bd3e [INFO] validating manifest of wilcoxky/rust-hw04 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wilcoxky/rust-hw04 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wilcoxky/rust-hw04 [INFO] finished frobbing wilcoxky/rust-hw04 [INFO] frobbed toml for wilcoxky/rust-hw04 written to work/ex/clippy-test-run/sources/stable/gh/wilcoxky/rust-hw04/Cargo.toml [INFO] started frobbing wilcoxky/rust-hw04 [INFO] finished frobbing wilcoxky/rust-hw04 [INFO] frobbed toml for wilcoxky/rust-hw04 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wilcoxky/rust-hw04/Cargo.toml [INFO] crate wilcoxky/rust-hw04 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wilcoxky/rust-hw04 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/wilcoxky/rust-hw04:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 89d2b9a0247be0b1cf67c28f3a82cc5cd0ccf8bb1a9cee8ca35af92f11e8c75f [INFO] running `"docker" "start" "-a" "89d2b9a0247be0b1cf67c28f3a82cc5cd0ccf8bb1a9cee8ca35af92f11e8c75f"` [INFO] [stderr] Checking libc v0.2.31 [INFO] [stderr] Checking rand v0.3.16 [INFO] [stderr] Checking hw04 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `result` [INFO] [stderr] --> src/main.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | let result = evaluate_line(&mut stack, &buffer); [INFO] [stderr] | ^^^^^^ help: consider using `_result` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `rpn::Stack` [INFO] [stderr] --> src/rpn.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | / pub fn new() -> Stack { [INFO] [stderr] 51 | | Stack(Vec::new()) [INFO] [stderr] 52 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 44 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/rpn.rs:106:44 [INFO] [stderr] | [INFO] [stderr] 106 | self.push(Elt::Int(a * -1)) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::neg_multiply)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/rpn.rs:124:21 [INFO] [stderr] | [INFO] [stderr] 124 | self.push(n); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/rpn.rs:133:21 [INFO] [stderr] | [INFO] [stderr] 133 | self.push(first.unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:31:42 [INFO] [stderr] | [INFO] [stderr] 31 | fn evaluate_line(stack: &mut Stack, buf: &String) -> rpn::Result<()> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused variable: `result` [INFO] [stderr] --> src/main.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | let result = evaluate_line(&mut stack, &buffer); [INFO] [stderr] | ^^^^^^ help: consider using `_result` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `rpn::Stack` [INFO] [stderr] --> src/rpn.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | / pub fn new() -> Stack { [INFO] [stderr] 51 | | Stack(Vec::new()) [INFO] [stderr] 52 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 44 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/rpn.rs:106:44 [INFO] [stderr] | [INFO] [stderr] 106 | self.push(Elt::Int(a * -1)) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::neg_multiply)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/rpn.rs:124:21 [INFO] [stderr] | [INFO] [stderr] 124 | self.push(n); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/rpn.rs:133:21 [INFO] [stderr] | [INFO] [stderr] 133 | self.push(first.unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:31:42 [INFO] [stderr] | [INFO] [stderr] 31 | fn evaluate_line(stack: &mut Stack, buf: &String) -> rpn::Result<()> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.71s [INFO] running `"docker" "inspect" "89d2b9a0247be0b1cf67c28f3a82cc5cd0ccf8bb1a9cee8ca35af92f11e8c75f"` [INFO] running `"docker" "rm" "-f" "89d2b9a0247be0b1cf67c28f3a82cc5cd0ccf8bb1a9cee8ca35af92f11e8c75f"` [INFO] [stdout] 89d2b9a0247be0b1cf67c28f3a82cc5cd0ccf8bb1a9cee8ca35af92f11e8c75f