[INFO] updating cached repository widelands/bunnybot
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/widelands/bunnybot
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/widelands/bunnybot" "work/ex/clippy-test-run/sources/stable/gh/widelands/bunnybot"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/widelands/bunnybot'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/widelands/bunnybot" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/widelands/bunnybot"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/widelands/bunnybot'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 9d04274e5f117416c42a932f06ce7edcdb8665a5
[INFO] sha for GitHub repo widelands/bunnybot: 9d04274e5f117416c42a932f06ce7edcdb8665a5
[INFO] validating manifest of widelands/bunnybot on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of widelands/bunnybot on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing widelands/bunnybot
[INFO] finished frobbing widelands/bunnybot
[INFO] frobbed toml for widelands/bunnybot written to work/ex/clippy-test-run/sources/stable/gh/widelands/bunnybot/Cargo.toml
[INFO] started frobbing widelands/bunnybot
[INFO] finished frobbing widelands/bunnybot
[INFO] frobbed toml for widelands/bunnybot written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/widelands/bunnybot/Cargo.toml
[INFO] crate widelands/bunnybot has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting widelands/bunnybot against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/widelands/bunnybot:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] cfb6b5d3dbb1dbd8838781475e4d95a2109b8215dad3f59f815f0bb4c9972a29
[INFO] running `"docker" "start" "-a" "cfb6b5d3dbb1dbd8838781475e4d95a2109b8215dad3f59f815f0bb4c9972a29"`
[INFO] [stderr]     Checking libc v0.2.29
[INFO] [stderr]     Checking byteorder v1.1.0
[INFO] [stderr]     Checking lazycell v0.5.1
[INFO] [stderr]    Compiling openssl v0.9.15
[INFO] [stderr]     Checking adler32 v1.0.1
[INFO] [stderr]     Checking serde v1.0.11
[INFO] [stderr]     Checking unicode-segmentation v1.2.0
[INFO] [stderr]     Checking ansi_term v0.9.0
[INFO] [stderr]     Checking dtoa v0.2.2
[INFO] [stderr]     Checking itoa v0.1.1
[INFO] [stderr]    Compiling backtrace-sys v0.1.12
[INFO] [stderr]    Compiling openssl-sys v0.9.15
[INFO] [stderr]    Compiling syn v0.10.8
[INFO] [stderr]     Checking base64 v0.6.0
[INFO] [stderr]     Checking libflate v0.1.10
[INFO] [stderr]     Checking thread_local v0.3.4
[INFO] [stderr]     Checking serde_json v0.8.6
[INFO] [stderr]     Checking url v1.5.1
[INFO] [stderr]     Checking iovec v0.1.0
[INFO] [stderr]     Checking net2 v0.2.30
[INFO] [stderr]     Checking num_cpus v1.6.2
[INFO] [stderr]     Checking rand v0.3.16
[INFO] [stderr]     Checking time v0.1.38
[INFO] [stderr]     Checking term_size v0.3.0
[INFO] [stderr]     Checking memchr v1.0.1
[INFO] [stderr]     Checking errno v0.2.3
[INFO] [stderr]     Checking atty v0.2.2
[INFO] [stderr]     Checking bytes v0.4.4
[INFO] [stderr]     Checking mio v0.6.10
[INFO] [stderr]     Checking futures-cpupool v0.1.5
[INFO] [stderr]     Checking aho-corasick v0.6.3
[INFO] [stderr]     Checking textwrap v0.7.0
[INFO] [stderr]     Checking scheduler v0.1.3
[INFO] [stderr]     Checking chrono v0.4.0
[INFO] [stderr]     Checking tokio-io v0.1.2
[INFO] [stderr]    Compiling serde_codegen_internals v0.11.3
[INFO] [stderr]     Checking clap v2.26.0
[INFO] [stderr]     Checking regex v0.2.2
[INFO] [stderr]     Checking tokio-core v0.1.9
[INFO] [stderr]    Compiling serde_codegen v0.8.23
[INFO] [stderr]     Checking tokio-proto v0.1.1
[INFO] [stderr]    Compiling serde_derive v0.8.23
[INFO] [stderr]     Checking hyper v0.11.2
[INFO] [stderr]     Checking serde_json v1.0.2
[INFO] [stderr]     Checking serde_urlencoded v0.5.1
[INFO] [stderr]     Checking native-tls v0.1.4
[INFO] [stderr]     Checking tokio-tls v0.1.3
[INFO] [stderr]     Checking backtrace v0.3.2
[INFO] [stderr]     Checking error-chain v0.10.0
[INFO] [stderr]     Checking hyper-tls v0.1.2
[INFO] [stderr]     Checking reqwest v0.7.2
[INFO] [stderr]     Checking bunnybot v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: lint `unused_doc_comment` has been renamed to `unused_doc_comments`
[INFO] [stderr]  --> src/errors.rs:1:10
[INFO] [stderr]   |
[INFO] [stderr] 1 | #![allow(unused_doc_comment)]
[INFO] [stderr]   |          ^^^^^^^^^^^^^^^^^^ help: use the new name: `unused_doc_comments`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(renamed_and_removed_lints)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/launchpad.rs:132:13
[INFO] [stderr]     |
[INFO] [stderr] 132 |             slug: slug,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `slug`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/launchpad.rs:337:13
[INFO] [stderr]     |
[INFO] [stderr] 337 |             comments: comments,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `comments`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: lint `unused_doc_comment` has been renamed to `unused_doc_comments`
[INFO] [stderr]  --> src/errors.rs:1:10
[INFO] [stderr]   |
[INFO] [stderr] 1 | #![allow(unused_doc_comment)]
[INFO] [stderr]   |          ^^^^^^^^^^^^^^^^^^ help: use the new name: `unused_doc_comments`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(renamed_and_removed_lints)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/launchpad.rs:132:13
[INFO] [stderr]     |
[INFO] [stderr] 132 |             slug: slug,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `slug`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/launchpad.rs:337:13
[INFO] [stderr]     |
[INFO] [stderr] 337 |             comments: comments,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `comments`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/launchpad.rs:17:16
[INFO] [stderr]    |
[INFO] [stderr] 17 | const LP_API: &'static str = "https://api.launchpad.net/1.0/";
[INFO] [stderr]    |               -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/launchpad.rs:18:21
[INFO] [stderr]    |
[INFO] [stderr] 18 | const TRAVIS_ROOT: &'static str = "https://api.travis-ci.org/repos/widelands/widelands/branches";
[INFO] [stderr]    |                    -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/launchpad.rs:19:23
[INFO] [stderr]    |
[INFO] [stderr] 19 | const APPVEYOR_ROOT: &'static str = "https://ci.appveyor.\
[INFO] [stderr]    |                      -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/launchpad.rs:253:28
[INFO] [stderr]     |
[INFO] [stderr] 253 |         const FORMATTING: &'static str = "utils/fix_formatting.py";
[INFO] [stderr]     |                           -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/launchpad.rs:17:16
[INFO] [stderr]    |
[INFO] [stderr] 17 | const LP_API: &'static str = "https://api.launchpad.net/1.0/";
[INFO] [stderr]    |               -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/launchpad.rs:18:21
[INFO] [stderr]    |
[INFO] [stderr] 18 | const TRAVIS_ROOT: &'static str = "https://api.travis-ci.org/repos/widelands/widelands/branches";
[INFO] [stderr]    |                    -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/launchpad.rs:19:23
[INFO] [stderr]    |
[INFO] [stderr] 19 | const APPVEYOR_ROOT: &'static str = "https://ci.appveyor.\
[INFO] [stderr]    |                      -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/launchpad.rs:253:28
[INFO] [stderr]     |
[INFO] [stderr] 253 |         const FORMATTING: &'static str = "utils/fix_formatting.py";
[INFO] [stderr]     |                           -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]  --> src/git.rs:9:29
[INFO] [stderr]   |
[INFO] [stderr] 9 |         if line.starts_with("*") {
[INFO] [stderr]   |                             ^^^ help: try using a char instead: `'*'`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]  --> src/git.rs:9:29
[INFO] [stderr]   |
[INFO] [stderr] 9 |         if line.starts_with("*") {
[INFO] [stderr]   |                             ^^^ help: try using a char instead: `'*'`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/bin/bunnybot.rs:88:9
[INFO] [stderr]    |
[INFO] [stderr] 88 |         self.merge_proposals.get_mut(index.unwrap()).unwrap()
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.merge_proposals[index.unwrap()]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/bin/bunnybot.rs:88:9
[INFO] [stderr]    |
[INFO] [stderr] 88 |         self.merge_proposals.get_mut(index.unwrap()).unwrap()
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.merge_proposals[index.unwrap()]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]    --> src/bin/bunnybot.rs:246:14
[INFO] [stderr]     |
[INFO] [stderr] 246 |             .or_insert(BranchState::default());
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(BranchState::default)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]    --> src/bin/bunnybot.rs:246:14
[INFO] [stderr]     |
[INFO] [stderr] 246 |             .or_insert(BranchState::default());
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(BranchState::default)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 57.75s
[INFO] running `"docker" "inspect" "cfb6b5d3dbb1dbd8838781475e4d95a2109b8215dad3f59f815f0bb4c9972a29"`
[INFO] running `"docker" "rm" "-f" "cfb6b5d3dbb1dbd8838781475e4d95a2109b8215dad3f59f815f0bb4c9972a29"`
[INFO] [stdout] cfb6b5d3dbb1dbd8838781475e4d95a2109b8215dad3f59f815f0bb4c9972a29