[INFO] updating cached repository whytekieran/RustProgrammingLanguage-Basics [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/whytekieran/RustProgrammingLanguage-Basics [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/whytekieran/RustProgrammingLanguage-Basics" "work/ex/clippy-test-run/sources/stable/gh/whytekieran/RustProgrammingLanguage-Basics"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/whytekieran/RustProgrammingLanguage-Basics'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/whytekieran/RustProgrammingLanguage-Basics" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/whytekieran/RustProgrammingLanguage-Basics"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/whytekieran/RustProgrammingLanguage-Basics'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] cf7cbb654ac9b7ba174d109cdfae1fa16289182c [INFO] sha for GitHub repo whytekieran/RustProgrammingLanguage-Basics: cf7cbb654ac9b7ba174d109cdfae1fa16289182c [INFO] validating manifest of whytekieran/RustProgrammingLanguage-Basics on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of whytekieran/RustProgrammingLanguage-Basics on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing whytekieran/RustProgrammingLanguage-Basics [INFO] finished frobbing whytekieran/RustProgrammingLanguage-Basics [INFO] frobbed toml for whytekieran/RustProgrammingLanguage-Basics written to work/ex/clippy-test-run/sources/stable/gh/whytekieran/RustProgrammingLanguage-Basics/Cargo.toml [INFO] started frobbing whytekieran/RustProgrammingLanguage-Basics [INFO] finished frobbing whytekieran/RustProgrammingLanguage-Basics [INFO] frobbed toml for whytekieran/RustProgrammingLanguage-Basics written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/whytekieran/RustProgrammingLanguage-Basics/Cargo.toml [INFO] crate whytekieran/RustProgrammingLanguage-Basics has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting whytekieran/RustProgrammingLanguage-Basics against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/whytekieran/RustProgrammingLanguage-Basics:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c61f62170845215498f5d570877203095b700573131fa87adf252a1377dc6d94 [INFO] running `"docker" "start" "-a" "c61f62170845215498f5d570877203095b700573131fa87adf252a1377dc6d94"` [INFO] [stderr] Checking 2_rust_basics v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:229:10 [INFO] [stderr] | [INFO] [stderr] 229 | let (a,b,c,d) = tuple1; //We can destructure a tuple and access al variables in it in a single expression like so: [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/main.rs:229:12 [INFO] [stderr] | [INFO] [stderr] 229 | let (a,b,c,d) = tuple1; //We can destructure a tuple and access al variables in it in a single expression like so: [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/main.rs:243:9 [INFO] [stderr] | [INFO] [stderr] 243 | let mut v = Vec::<(i32, f32)>::with_capacity(2); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/main.rs:398:8 [INFO] [stderr] | [INFO] [stderr] 398 | Ok(i) => println!("Your integer input is: {0}", i), [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:229:10 [INFO] [stderr] | [INFO] [stderr] 229 | let (a,b,c,d) = tuple1; //We can destructure a tuple and access al variables in it in a single expression like so: [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/main.rs:229:12 [INFO] [stderr] | [INFO] [stderr] 229 | let (a,b,c,d) = tuple1; //We can destructure a tuple and access al variables in it in a single expression like so: [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/main.rs:243:9 [INFO] [stderr] | [INFO] [stderr] 243 | let mut v = Vec::<(i32, f32)>::with_capacity(2); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/main.rs:398:8 [INFO] [stderr] | [INFO] [stderr] 398 | Ok(i) => println!("Your integer input is: {0}", i), [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:426:5 [INFO] [stderr] | [INFO] [stderr] 426 | return x; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:426:5 [INFO] [stderr] | [INFO] [stderr] 426 | return x; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: function is never used: `acceptdarray` [INFO] [stderr] --> src/main.rs:479:1 [INFO] [stderr] | [INFO] [stderr] 479 | fn acceptdarray(x: &mut [[i32; 4]]) -> &[[i32; 4]] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: the variable `index` is used as a loop counter. Consider using `for (index, item) in &mut array2.enumerate()` or similar iterators [INFO] [stderr] --> src/main.rs:147:14 [INFO] [stderr] | [INFO] [stderr] 147 | for value in &mut array2 { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:372:1 [INFO] [stderr] | [INFO] [stderr] 372 | / io::stdin().read_line(&mut input1) [INFO] [stderr] 373 | | .ok() [INFO] [stderr] 374 | | .expect("Couldn't read line"); [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: function is never used: `acceptdarray` [INFO] [stderr] --> src/main.rs:479:1 [INFO] [stderr] | [INFO] [stderr] 479 | fn acceptdarray(x: &mut [[i32; 4]]) -> &[[i32; 4]] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: the variable `index` is used as a loop counter. Consider using `for (index, item) in &mut array2.enumerate()` or similar iterators [INFO] [stderr] --> src/main.rs:147:14 [INFO] [stderr] | [INFO] [stderr] 147 | for value in &mut array2 { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:372:1 [INFO] [stderr] | [INFO] [stderr] 372 | / io::stdin().read_line(&mut input1) [INFO] [stderr] 373 | | .ok() [INFO] [stderr] 374 | | .expect("Couldn't read line"); [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.94s [INFO] running `"docker" "inspect" "c61f62170845215498f5d570877203095b700573131fa87adf252a1377dc6d94"` [INFO] running `"docker" "rm" "-f" "c61f62170845215498f5d570877203095b700573131fa87adf252a1377dc6d94"` [INFO] [stdout] c61f62170845215498f5d570877203095b700573131fa87adf252a1377dc6d94