[INFO] updating cached repository whostolemyhat/snowflakes [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/whostolemyhat/snowflakes [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/whostolemyhat/snowflakes" "work/ex/clippy-test-run/sources/stable/gh/whostolemyhat/snowflakes"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/whostolemyhat/snowflakes'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/whostolemyhat/snowflakes" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/whostolemyhat/snowflakes"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/whostolemyhat/snowflakes'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 583546befdc15b4b1a7d65b472f4751b0ca07013 [INFO] sha for GitHub repo whostolemyhat/snowflakes: 583546befdc15b4b1a7d65b472f4751b0ca07013 [INFO] validating manifest of whostolemyhat/snowflakes on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of whostolemyhat/snowflakes on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing whostolemyhat/snowflakes [INFO] finished frobbing whostolemyhat/snowflakes [INFO] frobbed toml for whostolemyhat/snowflakes written to work/ex/clippy-test-run/sources/stable/gh/whostolemyhat/snowflakes/Cargo.toml [INFO] started frobbing whostolemyhat/snowflakes [INFO] finished frobbing whostolemyhat/snowflakes [INFO] frobbed toml for whostolemyhat/snowflakes written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/whostolemyhat/snowflakes/Cargo.toml [INFO] crate whostolemyhat/snowflakes has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting whostolemyhat/snowflakes against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/whostolemyhat/snowflakes:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bffe2c5acf1022d9c9b99316a0a0ded4a6ef62346f1b62f9acd513374ee68ed3 [INFO] running `"docker" "start" "-a" "bffe2c5acf1022d9c9b99316a0a0ded4a6ef62346f1b62f9acd513374ee68ed3"` [INFO] [stderr] Compiling cairo-rs v0.3.0 [INFO] [stderr] Checking c_vec v1.2.1 [INFO] [stderr] Compiling glib-sys v0.5.0 [INFO] [stderr] Compiling gobject-sys v0.5.0 [INFO] [stderr] Compiling cairo-sys-rs v0.5.0 [INFO] [stderr] Checking rand v0.4.2 [INFO] [stderr] Checking glib v0.4.1 [INFO] [stderr] Checking snowflake v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/draw.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | let b = r / 2.0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/draw.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | let b = r / 2.0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: unary minus has lower precedence than method call [INFO] [stderr] --> src/draw.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | let a = -3f64.sqrt() / 2.0 * r; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider adding parentheses to clarify your intent: `-(3f64.sqrt())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: unary minus has lower precedence than method call [INFO] [stderr] --> src/draw.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | let a = -3f64.sqrt() / 2.0 * r; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider adding parentheses to clarify your intent: `-(3f64.sqrt())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/draw.rs:11:39 [INFO] [stderr] | [INFO] [stderr] 11 | fn draw_points(ctx: &Context, points: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/draw.rs:13:23 [INFO] [stderr] | [INFO] [stderr] 13 | let offset = (IMAGE_SIZE as f64 - SCALE) / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(IMAGE_SIZE)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/draw.rs:11:39 [INFO] [stderr] | [INFO] [stderr] 11 | fn draw_points(ctx: &Context, points: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/draw.rs:13:23 [INFO] [stderr] | [INFO] [stderr] 13 | let offset = (IMAGE_SIZE as f64 - SCALE) / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(IMAGE_SIZE)` [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/lib.rs:14:21 [INFO] [stderr] | [INFO] [stderr] 14 | hash.as_bytes().into_iter().fold(0, |acc, byte| acc + *byte as usize) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:17:38 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn extend(point: &Point, closed: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/lib.rs:14:21 [INFO] [stderr] | [INFO] [stderr] 14 | hash.as_bytes().into_iter().fold(0, |acc, byte| acc + *byte as usize) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:17:38 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn extend(point: &Point, closed: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 14.15s [INFO] running `"docker" "inspect" "bffe2c5acf1022d9c9b99316a0a0ded4a6ef62346f1b62f9acd513374ee68ed3"` [INFO] running `"docker" "rm" "-f" "bffe2c5acf1022d9c9b99316a0a0ded4a6ef62346f1b62f9acd513374ee68ed3"` [INFO] [stdout] bffe2c5acf1022d9c9b99316a0a0ded4a6ef62346f1b62f9acd513374ee68ed3