[INFO] updating cached repository whostolemyhat/serial-key-generator [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/whostolemyhat/serial-key-generator [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/whostolemyhat/serial-key-generator" "work/ex/clippy-test-run/sources/stable/gh/whostolemyhat/serial-key-generator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/whostolemyhat/serial-key-generator'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/whostolemyhat/serial-key-generator" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/whostolemyhat/serial-key-generator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/whostolemyhat/serial-key-generator'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 672a6f87572d3b723cc6f43e2121133d2aa44d00 [INFO] sha for GitHub repo whostolemyhat/serial-key-generator: 672a6f87572d3b723cc6f43e2121133d2aa44d00 [INFO] validating manifest of whostolemyhat/serial-key-generator on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of whostolemyhat/serial-key-generator on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing whostolemyhat/serial-key-generator [INFO] finished frobbing whostolemyhat/serial-key-generator [INFO] frobbed toml for whostolemyhat/serial-key-generator written to work/ex/clippy-test-run/sources/stable/gh/whostolemyhat/serial-key-generator/Cargo.toml [INFO] started frobbing whostolemyhat/serial-key-generator [INFO] finished frobbing whostolemyhat/serial-key-generator [INFO] frobbed toml for whostolemyhat/serial-key-generator written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/whostolemyhat/serial-key-generator/Cargo.toml [INFO] crate whostolemyhat/serial-key-generator has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting whostolemyhat/serial-key-generator against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/whostolemyhat/serial-key-generator:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9597f696f5e03d048d01c9ef88d6797cfd68bce01b62c36412b785cd1bf63124 [INFO] running `"docker" "start" "-a" "9597f696f5e03d048d01c9ef88d6797cfd68bce01b62c36412b785cd1bf63124"` [INFO] [stderr] Checking libc v0.2.28 [INFO] [stderr] Compiling crc-core v0.1.0 [INFO] [stderr] Checking dtoa v0.4.1 [INFO] [stderr] Checking itoa v0.3.1 [INFO] [stderr] Checking build_const v0.2.0 [INFO] [stderr] Checking serde v1.0.11 [INFO] [stderr] Compiling serde_derive v1.0.11 [INFO] [stderr] Compiling crc v1.5.0 [INFO] [stderr] Checking memchr v1.0.1 [INFO] [stderr] Checking term_size v0.3.0 [INFO] [stderr] Checking rand v0.3.16 [INFO] [stderr] Checking atty v0.2.2 [INFO] [stderr] Checking textwrap v0.7.0 [INFO] [stderr] Checking aho-corasick v0.6.3 [INFO] [stderr] Checking clap v2.26.0 [INFO] [stderr] Checking regex v0.2.2 [INFO] [stderr] Checking serial-key v2.0.0 [INFO] [stderr] Checking serde_json v1.0.2 [INFO] [stderr] Checking keygen v2.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | num_bytes: num_bytes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_bytes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | num_bytes: num_bytes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_bytes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:218:25 [INFO] [stderr] | [INFO] [stderr] 218 | / let mut blacklist: Vec = vec![]; [INFO] [stderr] 219 | | if matches.is_present("blacklist") { [INFO] [stderr] 220 | | // convert Vec to Vec [INFO] [stderr] 221 | | blacklist = matches.values_of("blacklist").unwrap().map(|s| s.to_string()).collect(); [INFO] [stderr] 222 | | } [INFO] [stderr] | |_________________________^ help: it is more idiomatic to write: `let blacklist = if matches.is_present("blacklist") { matches.values_of("blacklist").unwrap().map(|s| s.to_string()).collect() } else { < [ _ ] > :: into_vec ( box [ $ ( $ x ) , * ] ) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:226:63 [INFO] [stderr] | [INFO] [stderr] 226 | let bytes: Vec = s.split(",").map(|s| s.parse().unwrap()).collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:270:30 [INFO] [stderr] | [INFO] [stderr] 270 | let config = match matches.is_present("config") { [INFO] [stderr] | ______________________________^ [INFO] [stderr] 271 | | true => { [INFO] [stderr] 272 | | // read existing config [INFO] [stderr] 273 | | let path = matches.value_of("config").unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 310 | | } [INFO] [stderr] 311 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 270 | let config = if matches.is_present("config") { [INFO] [stderr] 271 | // read existing config [INFO] [stderr] 272 | let path = matches.value_of("config").unwrap(); [INFO] [stderr] 273 | match read_config_from_file(Path::new(path)) { [INFO] [stderr] 274 | Ok(config) => config, [INFO] [stderr] 275 | Err(e) => panic!("Error reading config: {:?}", e) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:285:25 [INFO] [stderr] | [INFO] [stderr] 285 | / let mut blacklist: Vec = vec![]; [INFO] [stderr] 286 | | if matches.is_present("blacklist") { [INFO] [stderr] 287 | | // convert Vec to Vec [INFO] [stderr] 288 | | blacklist = matches.values_of("blacklist").unwrap().map(|s| s.to_string()).collect(); [INFO] [stderr] 289 | | } [INFO] [stderr] | |_________________________^ help: it is more idiomatic to write: `let blacklist = if matches.is_present("blacklist") { matches.values_of("blacklist").unwrap().map(|s| s.to_string()).collect() } else { < [ _ ] > :: into_vec ( box [ $ ( $ x ) , * ] ) };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:294:63 [INFO] [stderr] | [INFO] [stderr] 294 | let bytes: Vec = s.split(",").map(|s| s.parse().unwrap()).collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:314:28 [INFO] [stderr] | [INFO] [stderr] 314 | let seed = crc32::checksum_ieee(format!("{}+{}", input, &config.hash).as_bytes()) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(crc32::checksum_ieee(format!("{}+{}", input, &config.hash).as_bytes()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:218:25 [INFO] [stderr] | [INFO] [stderr] 218 | / let mut blacklist: Vec = vec![]; [INFO] [stderr] 219 | | if matches.is_present("blacklist") { [INFO] [stderr] 220 | | // convert Vec to Vec [INFO] [stderr] 221 | | blacklist = matches.values_of("blacklist").unwrap().map(|s| s.to_string()).collect(); [INFO] [stderr] 222 | | } [INFO] [stderr] | |_________________________^ help: it is more idiomatic to write: `let blacklist = if matches.is_present("blacklist") { matches.values_of("blacklist").unwrap().map(|s| s.to_string()).collect() } else { < [ _ ] > :: into_vec ( box [ $ ( $ x ) , * ] ) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:226:63 [INFO] [stderr] | [INFO] [stderr] 226 | let bytes: Vec = s.split(",").map(|s| s.parse().unwrap()).collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:270:30 [INFO] [stderr] | [INFO] [stderr] 270 | let config = match matches.is_present("config") { [INFO] [stderr] | ______________________________^ [INFO] [stderr] 271 | | true => { [INFO] [stderr] 272 | | // read existing config [INFO] [stderr] 273 | | let path = matches.value_of("config").unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 310 | | } [INFO] [stderr] 311 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 270 | let config = if matches.is_present("config") { [INFO] [stderr] 271 | // read existing config [INFO] [stderr] 272 | let path = matches.value_of("config").unwrap(); [INFO] [stderr] 273 | match read_config_from_file(Path::new(path)) { [INFO] [stderr] 274 | Ok(config) => config, [INFO] [stderr] 275 | Err(e) => panic!("Error reading config: {:?}", e) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:285:25 [INFO] [stderr] | [INFO] [stderr] 285 | / let mut blacklist: Vec = vec![]; [INFO] [stderr] 286 | | if matches.is_present("blacklist") { [INFO] [stderr] 287 | | // convert Vec to Vec [INFO] [stderr] 288 | | blacklist = matches.values_of("blacklist").unwrap().map(|s| s.to_string()).collect(); [INFO] [stderr] 289 | | } [INFO] [stderr] | |_________________________^ help: it is more idiomatic to write: `let blacklist = if matches.is_present("blacklist") { matches.values_of("blacklist").unwrap().map(|s| s.to_string()).collect() } else { < [ _ ] > :: into_vec ( box [ $ ( $ x ) , * ] ) };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:294:63 [INFO] [stderr] | [INFO] [stderr] 294 | let bytes: Vec = s.split(",").map(|s| s.parse().unwrap()).collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:314:28 [INFO] [stderr] | [INFO] [stderr] 314 | let seed = crc32::checksum_ieee(format!("{}+{}", input, &config.hash).as_bytes()) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(crc32::checksum_ieee(format!("{}+{}", input, &config.hash).as_bytes()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 26.15s [INFO] running `"docker" "inspect" "9597f696f5e03d048d01c9ef88d6797cfd68bce01b62c36412b785cd1bf63124"` [INFO] running `"docker" "rm" "-f" "9597f696f5e03d048d01c9ef88d6797cfd68bce01b62c36412b785cd1bf63124"` [INFO] [stdout] 9597f696f5e03d048d01c9ef88d6797cfd68bce01b62c36412b785cd1bf63124