[INFO] updating cached repository whitfin/s3-meta [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/whitfin/s3-meta [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/whitfin/s3-meta" "work/ex/clippy-test-run/sources/stable/gh/whitfin/s3-meta"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/whitfin/s3-meta'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/whitfin/s3-meta" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/whitfin/s3-meta"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/whitfin/s3-meta'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d6eeacf050497bdd0655c0f13ffc50b5f87b8362 [INFO] sha for GitHub repo whitfin/s3-meta: d6eeacf050497bdd0655c0f13ffc50b5f87b8362 [INFO] validating manifest of whitfin/s3-meta on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of whitfin/s3-meta on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing whitfin/s3-meta [INFO] finished frobbing whitfin/s3-meta [INFO] frobbed toml for whitfin/s3-meta written to work/ex/clippy-test-run/sources/stable/gh/whitfin/s3-meta/Cargo.toml [INFO] started frobbing whitfin/s3-meta [INFO] finished frobbing whitfin/s3-meta [INFO] frobbed toml for whitfin/s3-meta written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/whitfin/s3-meta/Cargo.toml [INFO] crate whitfin/s3-meta has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting whitfin/s3-meta against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/whitfin/s3-meta:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fb338b63018dc0a64f50ac042835d59c6e2aa4246b672b665b8301fc73ba2ffa [INFO] running `"docker" "start" "-a" "fb338b63018dc0a64f50ac042835d59c6e2aa4246b672b665b8301fc73ba2ffa"` [INFO] [stderr] Compiling cc v1.0.24 [INFO] [stderr] Compiling proc-macro2 v0.4.18 [INFO] [stderr] Compiling num-traits v0.2.5 [INFO] [stderr] Compiling typenum v1.10.0 [INFO] [stderr] Compiling serde v1.0.77 [INFO] [stderr] Compiling openssl v0.10.11 [INFO] [stderr] Checking byte-tools v0.2.0 [INFO] [stderr] Checking constant_time_eq v0.1.3 [INFO] [stderr] Checking arrayref v0.3.5 [INFO] [stderr] Compiling failure_derive v0.1.2 [INFO] [stderr] Checking fake-simd v0.1.2 [INFO] [stderr] Checking rustc-demangle v0.1.9 [INFO] [stderr] Checking hex v0.3.2 [INFO] [stderr] Checking md5 v0.3.8 [INFO] [stderr] Checking dirs v1.0.3 [INFO] [stderr] Checking xml-rs v0.7.0 [INFO] [stderr] Checking block-buffer v0.3.3 [INFO] [stderr] Checking base64 v0.9.2 [INFO] [stderr] Checking getopts v0.2.18 [INFO] [stderr] Checking mio v0.6.16 [INFO] [stderr] Checking parking_lot_core v0.3.0 [INFO] [stderr] Checking http v0.1.12 [INFO] [stderr] Checking pretty-bytes v0.2.2 [INFO] [stderr] Compiling rusoto_core v0.34.0 [INFO] [stderr] Compiling openssl-sys v0.9.35 [INFO] [stderr] Compiling backtrace-sys v0.1.24 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking regex v0.2.11 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking tokio-reactor v0.1.5 [INFO] [stderr] Checking num-integer v0.1.39 [INFO] [stderr] Compiling quote v0.6.8 [INFO] [stderr] Checking tokio-udp v0.1.2 [INFO] [stderr] Checking tokio-tcp v0.1.1 [INFO] [stderr] Checking tokio-uds v0.2.1 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Compiling syn v0.14.9 [INFO] [stderr] Compiling native-tls v0.2.1 [INFO] [stderr] Checking generic-array v0.9.0 [INFO] [stderr] Checking backtrace v0.3.9 [INFO] [stderr] Checking tokio v0.1.8 [INFO] [stderr] Checking crypto-mac v0.5.2 [INFO] [stderr] Checking digest v0.7.5 [INFO] [stderr] Checking sha2 v0.7.1 [INFO] [stderr] Checking hmac v0.5.0 [INFO] [stderr] Checking h2 v0.1.12 [INFO] [stderr] Checking hyper v0.12.9 [INFO] [stderr] Checking serde_json v1.0.27 [INFO] [stderr] Compiling synstructure v0.9.0 [INFO] [stderr] Checking hyper-tls v0.3.0 [INFO] [stderr] Checking rusoto_credential v0.13.0 [INFO] [stderr] Checking failure v0.1.2 [INFO] [stderr] Checking quick-xml v0.12.3 [INFO] [stderr] Checking rusoto_s3 v0.34.0 [INFO] [stderr] Checking s3-meta v1.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/metrics/general.rs:27:36 [INFO] [stderr] | [INFO] [stderr] 27 | .map(|s| s.matches("/").count() - 1) [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/metrics/general.rs:44:26 [INFO] [stderr] | [INFO] [stderr] 44 | let nest_count = key.match_indices("/") [INFO] [stderr] | __________________________^ [INFO] [stderr] 45 | | .skip(self.nest_count) [INFO] [stderr] 46 | | .next() [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/metrics/general.rs:44:44 [INFO] [stderr] | [INFO] [stderr] 44 | let nest_count = key.match_indices("/") [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/util.rs:19:12 [INFO] [stderr] | [INFO] [stderr] 19 | if let None = bounded_key { [INFO] [stderr] | _____- ^^^^ [INFO] [stderr] 20 | | return; [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____- help: try this: `if bounded_key.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/main.rs:25:22 [INFO] [stderr] | [INFO] [stderr] 25 | let root_paths = std::env::args() [INFO] [stderr] | ______________________^ [INFO] [stderr] 26 | | .skip(1) [INFO] [stderr] 27 | | .next() [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/main.rs:78:16 [INFO] [stderr] | [INFO] [stderr] 78 | if let None = response.next_continuation_token { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 79 | | break; [INFO] [stderr] 80 | | } [INFO] [stderr] | |_________- help: try this: `if response.next_continuation_token.is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/metrics/general.rs:27:36 [INFO] [stderr] | [INFO] [stderr] 27 | .map(|s| s.matches("/").count() - 1) [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/metrics/general.rs:44:26 [INFO] [stderr] | [INFO] [stderr] 44 | let nest_count = key.match_indices("/") [INFO] [stderr] | __________________________^ [INFO] [stderr] 45 | | .skip(self.nest_count) [INFO] [stderr] 46 | | .next() [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/metrics/general.rs:44:44 [INFO] [stderr] | [INFO] [stderr] 44 | let nest_count = key.match_indices("/") [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/util.rs:19:12 [INFO] [stderr] | [INFO] [stderr] 19 | if let None = bounded_key { [INFO] [stderr] | _____- ^^^^ [INFO] [stderr] 20 | | return; [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____- help: try this: `if bounded_key.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/main.rs:25:22 [INFO] [stderr] | [INFO] [stderr] 25 | let root_paths = std::env::args() [INFO] [stderr] | ______________________^ [INFO] [stderr] 26 | | .skip(1) [INFO] [stderr] 27 | | .next() [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/main.rs:78:16 [INFO] [stderr] | [INFO] [stderr] 78 | if let None = response.next_continuation_token { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 79 | | break; [INFO] [stderr] 80 | | } [INFO] [stderr] | |_________- help: try this: `if response.next_continuation_token.is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 13s [INFO] running `"docker" "inspect" "fb338b63018dc0a64f50ac042835d59c6e2aa4246b672b665b8301fc73ba2ffa"` [INFO] running `"docker" "rm" "-f" "fb338b63018dc0a64f50ac042835d59c6e2aa4246b672b665b8301fc73ba2ffa"` [INFO] [stdout] fb338b63018dc0a64f50ac042835d59c6e2aa4246b672b665b8301fc73ba2ffa