[INFO] updating cached repository whiteavian/cryptopals_rust
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/whiteavian/cryptopals_rust
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/whiteavian/cryptopals_rust" "work/ex/clippy-test-run/sources/stable/gh/whiteavian/cryptopals_rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/whiteavian/cryptopals_rust'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/whiteavian/cryptopals_rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/whiteavian/cryptopals_rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/whiteavian/cryptopals_rust'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 584a3ebb16389e2b7750c27ec70048bd6485c7aa
[INFO] sha for GitHub repo whiteavian/cryptopals_rust: 584a3ebb16389e2b7750c27ec70048bd6485c7aa
[INFO] validating manifest of whiteavian/cryptopals_rust on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of whiteavian/cryptopals_rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing whiteavian/cryptopals_rust
[INFO] finished frobbing whiteavian/cryptopals_rust
[INFO] frobbed toml for whiteavian/cryptopals_rust written to work/ex/clippy-test-run/sources/stable/gh/whiteavian/cryptopals_rust/Cargo.toml
[INFO] started frobbing whiteavian/cryptopals_rust
[INFO] finished frobbing whiteavian/cryptopals_rust
[INFO] frobbed toml for whiteavian/cryptopals_rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/whiteavian/cryptopals_rust/Cargo.toml
[INFO] crate whiteavian/cryptopals_rust has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting whiteavian/cryptopals_rust against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/whiteavian/cryptopals_rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] a321ce05d9e4ba6aa36373f50309d3c2bde9c847dad04a13c97062357f04aa22
[INFO] running `"docker" "start" "-a" "a321ce05d9e4ba6aa36373f50309d3c2bde9c847dad04a13c97062357f04aa22"`
[INFO] [stderr]     Checking hamming v0.1.3
[INFO] [stderr]     Checking data-encoding v2.0.0-rc.2
[INFO] [stderr]     Checking cryptopals v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unused import: `std::io::Read`
[INFO] [stderr]   --> src/main.rs:13:5
[INFO] [stderr]    |
[INFO] [stderr] 13 | use std::io::Read;
[INFO] [stderr]    |     ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::io::Read`
[INFO] [stderr]   --> src/main.rs:13:5
[INFO] [stderr]    |
[INFO] [stderr] 13 | use std::io::Read;
[INFO] [stderr]    |     ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `j` is only used to index `input_bytes`.
[INFO] [stderr]    --> src/main.rs:122:22
[INFO] [stderr]     |
[INFO] [stderr] 122 |             for j in m * i..(m + 1) * i {
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 122 |             for <item> in input_bytes.iter().take((m + 1) * i).skip(m * i) {
[INFO] [stderr]     |                 ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/main.rs:170:22
[INFO] [stderr]     |
[INFO] [stderr] 170 |         for block in transpositions.get(k).unwrap() {
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&transpositions[k]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:188:46
[INFO] [stderr]     |
[INFO] [stderr] 188 | fn get_transpositions(potential_key_lengths: &Vec<usize>, input_bytes: &Vec<u8>) -> HashMap<usize, Vec<Vec<u8>>> {
[INFO] [stderr]     |                                              ^^^^^^^^^^^ help: change this to: `&[usize]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:188:72
[INFO] [stderr]     |
[INFO] [stderr] 188 | fn get_transpositions(potential_key_lengths: &Vec<usize>, input_bytes: &Vec<u8>) -> HashMap<usize, Vec<Vec<u8>>> {
[INFO] [stderr]     |                                                                        ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:207:55
[INFO] [stderr]     |
[INFO] [stderr] 207 | fn ith_block_byte(block_length: usize, i: usize, vec: &Vec<u8>) -> Vec<u8> {
[INFO] [stderr]     |                                                       ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:235:26
[INFO] [stderr]     |
[INFO] [stderr] 235 | fn likely_english(input: &Vec<u8>) -> bool {
[INFO] [stderr]     |                          ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `bc`.
[INFO] [stderr]    --> src/main.rs:243:14
[INFO] [stderr]     |
[INFO] [stderr] 243 |     for i in 1..5 {
[INFO] [stderr]     |              ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 243 |     for <item> in bc.iter().take(5).skip(1) {
[INFO] [stderr]     |         ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]    --> src/main.rs:253:5
[INFO] [stderr]     |
[INFO] [stderr] 253 |     String::from_utf8(input).unwrap_or(String::new())
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `String::from_utf8(input).unwrap_or_default()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:257:38
[INFO] [stderr]     |
[INFO] [stderr] 257 | fn key_from_space_most_common(bytes: &Vec<u8>) -> u8 {
[INFO] [stderr]     |                                      ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]    --> src/main.rs:261:18
[INFO] [stderr]     |
[INFO] [stderr] 261 |     top_letter ^ " ".as_bytes()[0]
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b" "`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::string_lit_as_bytes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:266:39
[INFO] [stderr]     |
[INFO] [stderr] 266 | fn decode_by_space_most_common(bytes: &Vec<u8>) -> Vec<u8> {
[INFO] [stderr]     |                                       ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:278:30
[INFO] [stderr]     |
[INFO] [stderr] 278 | fn sorted_byte_counts(bytes: &Vec<u8>) -> Vec<(u8, u8)> {
[INFO] [stderr]     |                              ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `j` is only used to index `input_bytes`.
[INFO] [stderr]    --> src/main.rs:122:22
[INFO] [stderr]     |
[INFO] [stderr] 122 |             for j in m * i..(m + 1) * i {
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 122 |             for <item> in input_bytes.iter().take((m + 1) * i).skip(m * i) {
[INFO] [stderr]     |                 ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/main.rs:170:22
[INFO] [stderr]     |
[INFO] [stderr] 170 |         for block in transpositions.get(k).unwrap() {
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&transpositions[k]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:188:46
[INFO] [stderr]     |
[INFO] [stderr] 188 | fn get_transpositions(potential_key_lengths: &Vec<usize>, input_bytes: &Vec<u8>) -> HashMap<usize, Vec<Vec<u8>>> {
[INFO] [stderr]     |                                              ^^^^^^^^^^^ help: change this to: `&[usize]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:188:72
[INFO] [stderr]     |
[INFO] [stderr] 188 | fn get_transpositions(potential_key_lengths: &Vec<usize>, input_bytes: &Vec<u8>) -> HashMap<usize, Vec<Vec<u8>>> {
[INFO] [stderr]     |                                                                        ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:207:55
[INFO] [stderr]     |
[INFO] [stderr] 207 | fn ith_block_byte(block_length: usize, i: usize, vec: &Vec<u8>) -> Vec<u8> {
[INFO] [stderr]     |                                                       ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:235:26
[INFO] [stderr]     |
[INFO] [stderr] 235 | fn likely_english(input: &Vec<u8>) -> bool {
[INFO] [stderr]     |                          ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `bc`.
[INFO] [stderr]    --> src/main.rs:243:14
[INFO] [stderr]     |
[INFO] [stderr] 243 |     for i in 1..5 {
[INFO] [stderr]     |              ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 243 |     for <item> in bc.iter().take(5).skip(1) {
[INFO] [stderr]     |         ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]    --> src/main.rs:253:5
[INFO] [stderr]     |
[INFO] [stderr] 253 |     String::from_utf8(input).unwrap_or(String::new())
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `String::from_utf8(input).unwrap_or_default()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:257:38
[INFO] [stderr]     |
[INFO] [stderr] 257 | fn key_from_space_most_common(bytes: &Vec<u8>) -> u8 {
[INFO] [stderr]     |                                      ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]    --> src/main.rs:261:18
[INFO] [stderr]     |
[INFO] [stderr] 261 |     top_letter ^ " ".as_bytes()[0]
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b" "`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::string_lit_as_bytes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:266:39
[INFO] [stderr]     |
[INFO] [stderr] 266 | fn decode_by_space_most_common(bytes: &Vec<u8>) -> Vec<u8> {
[INFO] [stderr]     |                                       ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:278:30
[INFO] [stderr]     |
[INFO] [stderr] 278 | fn sorted_byte_counts(bytes: &Vec<u8>) -> Vec<(u8, u8)> {
[INFO] [stderr]     |                              ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.41s
[INFO] running `"docker" "inspect" "a321ce05d9e4ba6aa36373f50309d3c2bde9c847dad04a13c97062357f04aa22"`
[INFO] running `"docker" "rm" "-f" "a321ce05d9e4ba6aa36373f50309d3c2bde9c847dad04a13c97062357f04aa22"`
[INFO] [stdout] a321ce05d9e4ba6aa36373f50309d3c2bde9c847dad04a13c97062357f04aa22