[INFO] updating cached repository whelanc5/rust_hw [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/whelanc5/rust_hw [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/whelanc5/rust_hw" "work/ex/clippy-test-run/sources/stable/gh/whelanc5/rust_hw"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/whelanc5/rust_hw'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/whelanc5/rust_hw" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/whelanc5/rust_hw"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/whelanc5/rust_hw'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8db3e362a4810de15fdebe265bc9600ae1a2d5e4 [INFO] sha for GitHub repo whelanc5/rust_hw: 8db3e362a4810de15fdebe265bc9600ae1a2d5e4 [INFO] validating manifest of whelanc5/rust_hw on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of whelanc5/rust_hw on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing whelanc5/rust_hw [INFO] finished frobbing whelanc5/rust_hw [INFO] frobbed toml for whelanc5/rust_hw written to work/ex/clippy-test-run/sources/stable/gh/whelanc5/rust_hw/Cargo.toml [INFO] started frobbing whelanc5/rust_hw [INFO] finished frobbing whelanc5/rust_hw [INFO] frobbed toml for whelanc5/rust_hw written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/whelanc5/rust_hw/Cargo.toml [INFO] crate whelanc5/rust_hw has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting whelanc5/rust_hw against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/whelanc5/rust_hw:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4dfdf0f6223393073298950a2decadf379f05d9c2927954a3ab0e358a8c206ff [INFO] running `"docker" "start" "-a" "4dfdf0f6223393073298950a2decadf379f05d9c2927954a3ab0e358a8c206ff"` [INFO] [stderr] Checking rust_hw v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:153:31 [INFO] [stderr] | [INFO] [stderr] 153 | Ok(_) => print!("{}", ""), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:153:31 [INFO] [stderr] | [INFO] [stderr] 153 | Ok(_) => print!("{}", ""), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: this is an `else if` but the formatting might hide it [INFO] [stderr] --> src/main.rs:103:5 [INFO] [stderr] | [INFO] [stderr] 103 | } else [INFO] [stderr] | ______________^ [INFO] [stderr] 104 | | if y == 1{ //checks slot two phones [INFO] [stderr] | |____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::suspicious_else_formatting)] on by default [INFO] [stderr] = note: to remove this lint, remove the `else` or remove the new line between `else` and `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: this is an `else if` but the formatting might hide it [INFO] [stderr] --> src/main.rs:109:5 [INFO] [stderr] | [INFO] [stderr] 109 | } else [INFO] [stderr] | ______________^ [INFO] [stderr] 110 | | if y == 2{ //checks computer [INFO] [stderr] | |____________^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this lint, remove the `else` or remove the new line between `else` and `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: this is an `else if` but the formatting might hide it [INFO] [stderr] --> src/main.rs:115:5 [INFO] [stderr] | [INFO] [stderr] 115 | } else [INFO] [stderr] | ______________^ [INFO] [stderr] 116 | | if y == 3{ //checks network [INFO] [stderr] | |____________^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this lint, remove the `else` or remove the new line between `else` and `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: this is an `else if` but the formatting might hide it [INFO] [stderr] --> src/main.rs:103:5 [INFO] [stderr] | [INFO] [stderr] 103 | } else [INFO] [stderr] | ______________^ [INFO] [stderr] 104 | | if y == 1{ //checks slot two phones [INFO] [stderr] | |____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::suspicious_else_formatting)] on by default [INFO] [stderr] = note: to remove this lint, remove the `else` or remove the new line between `else` and `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: this is an `else if` but the formatting might hide it [INFO] [stderr] --> src/main.rs:109:5 [INFO] [stderr] | [INFO] [stderr] 109 | } else [INFO] [stderr] | ______________^ [INFO] [stderr] 110 | | if y == 2{ //checks computer [INFO] [stderr] | |____________^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this lint, remove the `else` or remove the new line between `else` and `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: this is an `else if` but the formatting might hide it [INFO] [stderr] --> src/main.rs:115:5 [INFO] [stderr] | [INFO] [stderr] 115 | } else [INFO] [stderr] | ______________^ [INFO] [stderr] 116 | | if y == 3{ //checks network [INFO] [stderr] | |____________^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this lint, remove the `else` or remove the new line between `else` and `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: the loop variable `x` is only used to index `shifts`. [INFO] [stderr] --> src/main.rs:66:11 [INFO] [stderr] | [INFO] [stderr] 66 | for x in 0..4{ //for loop for going through each shift [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 66 | for in shifts.iter().take(4){ //for loop for going through each shift [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `y` is only used to index `employees`. [INFO] [stderr] --> src/main.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | for y in 0..20{ //for loop to iterate through list until the employee name matches the current shift name being looked at [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 72 | for in employees.iter().take(20){ //for loop to iterate through list until the employee name matches the current shift name being looked at [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `x` is only used to index `shift_and_skills`. [INFO] [stderr] --> src/main.rs:94:11 [INFO] [stderr] | [INFO] [stderr] 94 | for x in 0..4{ //loop for list of shifts [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 94 | for in shift_and_skills.iter().take(4){ //loop for list of shifts [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/main.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | if y == 1{ //checks slot two phones [INFO] [stderr] | ______________________^ [INFO] [stderr] 105 | | if shift_and_skills[x][y][1].trim() == "0"{ [INFO] [stderr] 106 | | bool_val = false; [INFO] [stderr] 107 | | println!("this employee is assigned to handle the phone, but is not qualified: {}", shift_and_skills[x][y][0].trim()); [INFO] [stderr] 108 | | } [INFO] [stderr] 109 | | } else [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/main.rs:98:13 [INFO] [stderr] | [INFO] [stderr] 98 | if y == 0{ //checks slot one phones [INFO] [stderr] | ______________________^ [INFO] [stderr] 99 | | if shift_and_skills[x][y][1].trim() == "0"{ [INFO] [stderr] 100 | | bool_val = false; [INFO] [stderr] 101 | | println!("this employee is assigned to handle the phone, but is not qualified: {}", shift_and_skills[x][y][0].trim()); [INFO] [stderr] 102 | | } [INFO] [stderr] 103 | | } else [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust_hw`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: the loop variable `x` is only used to index `shifts`. [INFO] [stderr] --> src/main.rs:66:11 [INFO] [stderr] | [INFO] [stderr] 66 | for x in 0..4{ //for loop for going through each shift [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 66 | for in shifts.iter().take(4){ //for loop for going through each shift [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `y` is only used to index `employees`. [INFO] [stderr] --> src/main.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | for y in 0..20{ //for loop to iterate through list until the employee name matches the current shift name being looked at [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 72 | for in employees.iter().take(20){ //for loop to iterate through list until the employee name matches the current shift name being looked at [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `x` is only used to index `shift_and_skills`. [INFO] [stderr] --> src/main.rs:94:11 [INFO] [stderr] | [INFO] [stderr] 94 | for x in 0..4{ //loop for list of shifts [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 94 | for in shift_and_skills.iter().take(4){ //loop for list of shifts [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/main.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | if y == 1{ //checks slot two phones [INFO] [stderr] | ______________________^ [INFO] [stderr] 105 | | if shift_and_skills[x][y][1].trim() == "0"{ [INFO] [stderr] 106 | | bool_val = false; [INFO] [stderr] 107 | | println!("this employee is assigned to handle the phone, but is not qualified: {}", shift_and_skills[x][y][0].trim()); [INFO] [stderr] 108 | | } [INFO] [stderr] 109 | | } else [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/main.rs:98:13 [INFO] [stderr] | [INFO] [stderr] 98 | if y == 0{ //checks slot one phones [INFO] [stderr] | ______________________^ [INFO] [stderr] 99 | | if shift_and_skills[x][y][1].trim() == "0"{ [INFO] [stderr] 100 | | bool_val = false; [INFO] [stderr] 101 | | println!("this employee is assigned to handle the phone, but is not qualified: {}", shift_and_skills[x][y][0].trim()); [INFO] [stderr] 102 | | } [INFO] [stderr] 103 | | } else [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust_hw`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "4dfdf0f6223393073298950a2decadf379f05d9c2927954a3ab0e358a8c206ff"` [INFO] running `"docker" "rm" "-f" "4dfdf0f6223393073298950a2decadf379f05d9c2927954a3ab0e358a8c206ff"` [INFO] [stdout] 4dfdf0f6223393073298950a2decadf379f05d9c2927954a3ab0e358a8c206ff