[INFO] updating cached repository whbboyd/gl-demo
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/whbboyd/gl-demo
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/whbboyd/gl-demo" "work/ex/clippy-test-run/sources/stable/gh/whbboyd/gl-demo"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/whbboyd/gl-demo'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/whbboyd/gl-demo" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/whbboyd/gl-demo"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/whbboyd/gl-demo'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 9d965999cad76737c146b7d9a574a160881c90bb
[INFO] sha for GitHub repo whbboyd/gl-demo: 9d965999cad76737c146b7d9a574a160881c90bb
[INFO] validating manifest of whbboyd/gl-demo on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of whbboyd/gl-demo on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing whbboyd/gl-demo
[INFO] finished frobbing whbboyd/gl-demo
[INFO] frobbed toml for whbboyd/gl-demo written to work/ex/clippy-test-run/sources/stable/gh/whbboyd/gl-demo/Cargo.toml
[INFO] started frobbing whbboyd/gl-demo
[INFO] finished frobbing whbboyd/gl-demo
[INFO] frobbed toml for whbboyd/gl-demo written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/whbboyd/gl-demo/Cargo.toml
[INFO] crate whbboyd/gl-demo has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting whbboyd/gl-demo against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/whbboyd/gl-demo:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 287dfbb8a8669e1c6ae095136b9fc2e9b7da2d33fb557af8690fe44ccf9b24d4
[INFO] running `"docker" "start" "-a" "287dfbb8a8669e1c6ae095136b9fc2e9b7da2d33fb557af8690fe44ccf9b24d4"`
[INFO] [stderr]    Compiling bitflags v1.0.3
[INFO] [stderr]    Compiling khronos_api v2.2.0
[INFO] [stderr]     Checking token_store v0.1.2
[INFO] [stderr]    Compiling cfg-if v0.1.3
[INFO] [stderr]    Compiling num-traits v0.2.4
[INFO] [stderr]    Compiling num-integer v0.1.38
[INFO] [stderr]    Compiling regex v1.0.0
[INFO] [stderr]     Checking inflate v0.1.1
[INFO] [stderr]     Checking termcolor v0.3.6
[INFO] [stderr]     Checking byteorder v0.5.3
[INFO] [stderr]     Checking smallvec v0.6.1
[INFO] [stderr]     Checking error-chain v0.8.1
[INFO] [stderr]     Checking wavefront_obj v5.1.0
[INFO] [stderr]    Compiling libloading v0.5.0
[INFO] [stderr]     Checking log v0.4.1
[INFO] [stderr]     Checking memmap v0.6.2
[INFO] [stderr]     Checking shared_library v0.1.8
[INFO] [stderr]     Checking memchr v2.0.1
[INFO] [stderr]     Checking atty v0.2.10
[INFO] [stderr]     Checking time v0.1.40
[INFO] [stderr]    Compiling x11-dl v2.17.5
[INFO] [stderr]     Checking regex-syntax v0.6.0
[INFO] [stderr]    Compiling xml-rs v0.7.0
[INFO] [stderr]     Checking tempfile v3.0.2
[INFO] [stderr]     Checking osmesa-sys v0.1.2
[INFO] [stderr]     Checking aho-corasick v0.6.4
[INFO] [stderr]     Checking miniz-sys v0.1.10
[INFO] [stderr]     Checking backtrace-sys v0.1.16
[INFO] [stderr]     Checking rayon-core v1.4.0
[INFO] [stderr]     Checking backtrace v0.3.7
[INFO] [stderr]     Checking flate2 v0.2.20
[INFO] [stderr]     Checking dlib v0.4.1
[INFO] [stderr]     Checking wayland-sys v0.12.5
[INFO] [stderr]     Checking rayon v1.0.1
[INFO] [stderr]    Compiling wayland-scanner v0.12.5
[INFO] [stderr]    Compiling gl_generator v0.9.0
[INFO] [stderr]     Checking num-traits v0.1.43
[INFO] [stderr]     Checking enum_primitive v0.1.1
[INFO] [stderr]     Checking num-iter v0.1.37
[INFO] [stderr]     Checking num-bigint v0.1.43
[INFO] [stderr]    Compiling wayland-client v0.12.5
[INFO] [stderr]    Compiling wayland-protocols v0.12.5
[INFO] [stderr]     Checking png v0.5.2
[INFO] [stderr]    Compiling glutin v0.14.0
[INFO] [stderr]    Compiling glium v0.21.0
[INFO] [stderr]     Checking num-rational v0.1.42
[INFO] [stderr]     Checking jpeg-decoder v0.1.14
[INFO] [stderr]     Checking env_logger v0.5.10
[INFO] [stderr]     Checking image v0.11.1
[INFO] [stderr]     Checking wayland-kbd v0.13.1
[INFO] [stderr]     Checking wayland-window v0.13.3
[INFO] [stderr]     Checking winit v0.12.0
[INFO] [stderr]     Checking gl-demo v0.0.1 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/model/disk.rs:90:23
[INFO] [stderr]    |
[INFO] [stderr] 90 |     Ok( (mem::Geometry { vertices: vertices, indices: indices, }, mat) )
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^ help: replace it with: `vertices`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/model/disk.rs:90:43
[INFO] [stderr]    |
[INFO] [stderr] 90 |     Ok( (mem::Geometry { vertices: vertices, indices: indices, }, mat) )
[INFO] [stderr]    |                                              ^^^^^^^^^^^^^^^^ help: replace it with: `indices`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/model/disk.rs:124:5
[INFO] [stderr]     |
[INFO] [stderr] 124 |                 texture: texture } );
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^ help: replace it with: `texture`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/model/heightmap/simpleheightmap.rs:179:4
[INFO] [stderr]     |
[INFO] [stderr] 179 |             display: display,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `display`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/model/heightmap/simpleheightmap.rs:174:5
[INFO] [stderr]     |
[INFO] [stderr] 174 |                 width: width,
[INFO] [stderr]     |                 ^^^^^^^^^^^^ help: replace it with: `width`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/model/heightmap/simpleheightmap.rs:176:5
[INFO] [stderr]     |
[INFO] [stderr] 176 |                 x_offset: x_offset,
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^ help: replace it with: `x_offset`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/model/heightmap/simpleheightmap.rs:177:5
[INFO] [stderr]     |
[INFO] [stderr] 177 |                 z_offset: z_offset,
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^ help: replace it with: `z_offset`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/model/heightmap/simpleheightmap.rs:178:5
[INFO] [stderr]     |
[INFO] [stderr] 178 |                 resolution: resolution, },
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `resolution`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/model/heightmap/simpleheightmap.rs:268:4
[INFO] [stderr]     |
[INFO] [stderr] 268 |             tex_uv: tex_uv,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `tex_uv`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/model/heightmap/simpleheightmap.rs:339:4
[INFO] [stderr]     |
[INFO] [stderr] 339 |             vertices: vertices,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `vertices`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/model/heightmap/simpleheightmap.rs:340:4
[INFO] [stderr]     |
[INFO] [stderr] 340 |             indices: indices,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `indices`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/physics.rs:45:3
[INFO] [stderr]    |
[INFO] [stderr] 45 |         loc: loc,
[INFO] [stderr]    |         ^^^^^^^^ help: replace it with: `loc`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/physics.rs:46:3
[INFO] [stderr]    |
[INFO] [stderr] 46 |         vel: vel,
[INFO] [stderr]    |         ^^^^^^^^ help: replace it with: `vel`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/physics.rs:47:3
[INFO] [stderr]    |
[INFO] [stderr] 47 |         max_speed: max_speed,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_speed`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/physics.rs:48:3
[INFO] [stderr]    |
[INFO] [stderr] 48 |         decel: decel,
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: replace it with: `decel`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/physics.rs:49:3
[INFO] [stderr]    |
[INFO] [stderr] 49 |         max_jump: max_jump,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^ help: replace it with: `max_jump`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/physics.rs:50:3
[INFO] [stderr]    |
[INFO] [stderr] 50 |         gravity: gravity}
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^ help: replace it with: `gravity`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/renderable.rs:88:4
[INFO] [stderr]    |
[INFO] [stderr] 88 |             text: text,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `text`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/renderable.rs:89:4
[INFO] [stderr]    |
[INFO] [stderr] 89 |             font: font,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `font`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/renderable.rs:90:4
[INFO] [stderr]    |
[INFO] [stderr] 90 |             chars_wide: chars_wide,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `chars_wide`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/renderable.rs:91:4
[INFO] [stderr]    |
[INFO] [stderr] 91 |             chars_high: chars_high,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `chars_high`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/renderable.rs:92:4
[INFO] [stderr]    |
[INFO] [stderr] 92 |             char_width: char_width,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `char_width`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/renderable.rs:93:4
[INFO] [stderr]    |
[INFO] [stderr] 93 |             char_height: char_height,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `char_height`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:233:4
[INFO] [stderr]     |
[INFO] [stderr] 233 |             view: view,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `view`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:234:4
[INFO] [stderr]     |
[INFO] [stderr] 234 |             perspective: perspective,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `perspective`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:235:4
[INFO] [stderr]     |
[INFO] [stderr] 235 |             light_pos: light_pos,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `light_pos`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:236:4
[INFO] [stderr]     |
[INFO] [stderr] 236 |             light_color: light_color,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `light_color`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/main.rs:349:4
[INFO] [stderr]     |
[INFO] [stderr] 349 |               write!(buf, "[{}] [{} {}:{}] [{}] {}\n",
[INFO] [stderr]     |  _____________^
[INFO] [stderr] 350 | |                 now().rfc3339(),
[INFO] [stderr] 351 | |                 record.module_path().unwrap_or("unknown module"),
[INFO] [stderr] 352 | |                 record.file().unwrap_or("unknown source file"),
[INFO] [stderr] ...   |
[INFO] [stderr] 355 | |                 record.level(),
[INFO] [stderr] 356 | |                 record.args()) } )
[INFO] [stderr]     | |______________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::write_with_newline)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/model/disk.rs:90:23
[INFO] [stderr]    |
[INFO] [stderr] 90 |     Ok( (mem::Geometry { vertices: vertices, indices: indices, }, mat) )
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^ help: replace it with: `vertices`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/model/disk.rs:90:43
[INFO] [stderr]    |
[INFO] [stderr] 90 |     Ok( (mem::Geometry { vertices: vertices, indices: indices, }, mat) )
[INFO] [stderr]    |                                              ^^^^^^^^^^^^^^^^ help: replace it with: `indices`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/model/disk.rs:124:5
[INFO] [stderr]     |
[INFO] [stderr] 124 |                 texture: texture } );
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^ help: replace it with: `texture`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/model/heightmap/simpleheightmap.rs:179:4
[INFO] [stderr]     |
[INFO] [stderr] 179 |             display: display,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `display`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/model/heightmap/simpleheightmap.rs:174:5
[INFO] [stderr]     |
[INFO] [stderr] 174 |                 width: width,
[INFO] [stderr]     |                 ^^^^^^^^^^^^ help: replace it with: `width`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/model/heightmap/simpleheightmap.rs:176:5
[INFO] [stderr]     |
[INFO] [stderr] 176 |                 x_offset: x_offset,
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^ help: replace it with: `x_offset`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/model/heightmap/simpleheightmap.rs:177:5
[INFO] [stderr]     |
[INFO] [stderr] 177 |                 z_offset: z_offset,
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^ help: replace it with: `z_offset`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/model/heightmap/simpleheightmap.rs:178:5
[INFO] [stderr]     |
[INFO] [stderr] 178 |                 resolution: resolution, },
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `resolution`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/model/heightmap/simpleheightmap.rs:268:4
[INFO] [stderr]     |
[INFO] [stderr] 268 |             tex_uv: tex_uv,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `tex_uv`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/model/heightmap/simpleheightmap.rs:339:4
[INFO] [stderr]     |
[INFO] [stderr] 339 |             vertices: vertices,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `vertices`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/model/heightmap/simpleheightmap.rs:340:4
[INFO] [stderr]     |
[INFO] [stderr] 340 |             indices: indices,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `indices`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/physics.rs:45:3
[INFO] [stderr]    |
[INFO] [stderr] 45 |         loc: loc,
[INFO] [stderr]    |         ^^^^^^^^ help: replace it with: `loc`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/physics.rs:46:3
[INFO] [stderr]    |
[INFO] [stderr] 46 |         vel: vel,
[INFO] [stderr]    |         ^^^^^^^^ help: replace it with: `vel`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/physics.rs:47:3
[INFO] [stderr]    |
[INFO] [stderr] 47 |         max_speed: max_speed,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_speed`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/physics.rs:48:3
[INFO] [stderr]    |
[INFO] [stderr] 48 |         decel: decel,
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: replace it with: `decel`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/physics.rs:49:3
[INFO] [stderr]    |
[INFO] [stderr] 49 |         max_jump: max_jump,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^ help: replace it with: `max_jump`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/physics.rs:50:3
[INFO] [stderr]    |
[INFO] [stderr] 50 |         gravity: gravity}
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^ help: replace it with: `gravity`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/renderable.rs:88:4
[INFO] [stderr]    |
[INFO] [stderr] 88 |             text: text,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `text`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/renderable.rs:89:4
[INFO] [stderr]    |
[INFO] [stderr] 89 |             font: font,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `font`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/renderable.rs:90:4
[INFO] [stderr]    |
[INFO] [stderr] 90 |             chars_wide: chars_wide,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `chars_wide`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/renderable.rs:91:4
[INFO] [stderr]    |
[INFO] [stderr] 91 |             chars_high: chars_high,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `chars_high`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/renderable.rs:92:4
[INFO] [stderr]    |
[INFO] [stderr] 92 |             char_width: char_width,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `char_width`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/renderable.rs:93:4
[INFO] [stderr]    |
[INFO] [stderr] 93 |             char_height: char_height,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `char_height`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:233:4
[INFO] [stderr]     |
[INFO] [stderr] 233 |             view: view,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `view`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:234:4
[INFO] [stderr]     |
[INFO] [stderr] 234 |             perspective: perspective,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `perspective`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:235:4
[INFO] [stderr]     |
[INFO] [stderr] 235 |             light_pos: light_pos,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `light_pos`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:236:4
[INFO] [stderr]     |
[INFO] [stderr] 236 |             light_color: light_color,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `light_color`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/main.rs:349:4
[INFO] [stderr]     |
[INFO] [stderr] 349 |               write!(buf, "[{}] [{} {}:{}] [{}] {}\n",
[INFO] [stderr]     |  _____________^
[INFO] [stderr] 350 | |                 now().rfc3339(),
[INFO] [stderr] 351 | |                 record.module_path().unwrap_or("unknown module"),
[INFO] [stderr] 352 | |                 record.file().unwrap_or("unknown source file"),
[INFO] [stderr] ...   |
[INFO] [stderr] 355 | |                 record.level(),
[INFO] [stderr] 356 | |                 record.args()) } )
[INFO] [stderr]     | |______________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::write_with_newline)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/display_math.rs:50:13
[INFO] [stderr]    |
[INFO] [stderr] 50 |     let zfar = 1048576.0;
[INFO] [stderr]    |                ^^^^^^^^^ help: consider: `1_048_576.0`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/model/heightmap/simpleheightmap.rs:14:26
[INFO] [stderr]    |
[INFO] [stderr] 14 | const ROW_SPACING: f32 = 0.8660254037844386;
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^ help: consider: `0.866_025_403_784_438_6`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/model/heightmap/simpleheightmap.rs:70:4
[INFO] [stderr]    |
[INFO] [stderr] 70 |             return [vtx_a_pos, vtx_d_pos, vtx_c_pos];
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `[vtx_a_pos, vtx_d_pos, vtx_c_pos]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/model/heightmap/simpleheightmap.rs:78:5
[INFO] [stderr]    |
[INFO] [stderr] 78 |                 return [vtx_a_pos, vtx_b_pos, vtx_d_pos];
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `[vtx_a_pos, vtx_b_pos, vtx_d_pos]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/model/heightmap/simpleheightmap.rs:82:5
[INFO] [stderr]    |
[INFO] [stderr] 82 |                 return [vtx_b_pos, vtx_e_pos, vtx_d_pos];
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `[vtx_b_pos, vtx_e_pos, vtx_d_pos]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:67:21
[INFO] [stderr]    |
[INFO] [stderr] 67 | const TEAPOT_PATH: &'static str = "data/wt-teapot.obj";
[INFO] [stderr]    |                    -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:68:25
[INFO] [stderr]    |
[INFO] [stderr] 68 | const FLOOR_HEIGHTMAP: &'static str = "data/heightmap.png";
[INFO] [stderr]    |                        -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:69:25
[INFO] [stderr]    |
[INFO] [stderr] 69 | const FLOOR_MATERIALS: &'static str = "data/materials.mtl";
[INFO] [stderr]    |                        -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:70:22
[INFO] [stderr]    |
[INFO] [stderr] 70 | const FONT_TEXTURE: &'static str = "data/font-texture.png";
[INFO] [stderr]    |                     -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:71:28
[INFO] [stderr]    |
[INFO] [stderr] 71 | const VERTEX_SHADER_PATH: &'static str = "data/vertex-shader.vert";
[INFO] [stderr]    |                           -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:72:30
[INFO] [stderr]    |
[INFO] [stderr] 72 | const FRAGMENT_SHADER_PATH: &'static str = "data/fragment-shader.frag";
[INFO] [stderr]    |                             -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/display_math.rs:50:13
[INFO] [stderr]    |
[INFO] [stderr] 50 |     let zfar = 1048576.0;
[INFO] [stderr]    |                ^^^^^^^^^ help: consider: `1_048_576.0`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/model/heightmap/simpleheightmap.rs:14:26
[INFO] [stderr]    |
[INFO] [stderr] 14 | const ROW_SPACING: f32 = 0.8660254037844386;
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^ help: consider: `0.866_025_403_784_438_6`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/model/heightmap/simpleheightmap.rs:70:4
[INFO] [stderr]    |
[INFO] [stderr] 70 |             return [vtx_a_pos, vtx_d_pos, vtx_c_pos];
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `[vtx_a_pos, vtx_d_pos, vtx_c_pos]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/model/heightmap/simpleheightmap.rs:78:5
[INFO] [stderr]    |
[INFO] [stderr] 78 |                 return [vtx_a_pos, vtx_b_pos, vtx_d_pos];
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `[vtx_a_pos, vtx_b_pos, vtx_d_pos]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/model/heightmap/simpleheightmap.rs:82:5
[INFO] [stderr]    |
[INFO] [stderr] 82 |                 return [vtx_b_pos, vtx_e_pos, vtx_d_pos];
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `[vtx_b_pos, vtx_e_pos, vtx_d_pos]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:67:21
[INFO] [stderr]    |
[INFO] [stderr] 67 | const TEAPOT_PATH: &'static str = "data/wt-teapot.obj";
[INFO] [stderr]    |                    -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:68:25
[INFO] [stderr]    |
[INFO] [stderr] 68 | const FLOOR_HEIGHTMAP: &'static str = "data/heightmap.png";
[INFO] [stderr]    |                        -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:69:25
[INFO] [stderr]    |
[INFO] [stderr] 69 | const FLOOR_MATERIALS: &'static str = "data/materials.mtl";
[INFO] [stderr]    |                        -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:70:22
[INFO] [stderr]    |
[INFO] [stderr] 70 | const FONT_TEXTURE: &'static str = "data/font-texture.png";
[INFO] [stderr]    |                     -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:71:28
[INFO] [stderr]    |
[INFO] [stderr] 71 | const VERTEX_SHADER_PATH: &'static str = "data/vertex-shader.vert";
[INFO] [stderr]    |                           -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:72:30
[INFO] [stderr]    |
[INFO] [stderr] 72 | const FRAGMENT_SHADER_PATH: &'static str = "data/fragment-shader.frag";
[INFO] [stderr]    |                             -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/display_math.rs:76:27
[INFO] [stderr]    |
[INFO] [stderr] 76 |         window.get_inner_size().ok_or(Error::from("Could not get window size"))
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from("Could not get window size"))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/model/disk.rs:25:14
[INFO] [stderr]    |
[INFO] [stderr] 25 |         obj::parse(object_str.into())
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `object_str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/model/disk.rs:31:5
[INFO] [stderr]    |
[INFO] [stderr] 31 |             .ok_or(Error::from("Object lacks material specification (usemtl)"))
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from("Object lacks material specification (usemtl)"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/model/disk.rs:44:5
[INFO] [stderr]    |
[INFO] [stderr] 44 |             .ok_or(Error::from("No objects in object file"))
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from("No objects in object file"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/model/disk.rs:104:14
[INFO] [stderr]     |
[INFO] [stderr] 104 |         mtl::parse(mat_str.into())
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^ help: consider removing `.into()`: `mat_str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/model/disk.rs:111:6
[INFO] [stderr]     |
[INFO] [stderr] 111 |                 .ok_or(Error::from("Material lacks texture specification (map_Kd)"))
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from("Material lacks texture specification (map_Kd)"))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]    --> src/model/disk.rs:135:41
[INFO] [stderr]     |
[INFO] [stderr] 135 | pub fn load_texture<T>(read: &mut T) -> Result<Vec<Vec<(u8, u8, u8, u8)>>>
[INFO] [stderr]     |                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::type_complexity)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: float has excessive precision
[INFO] [stderr]   --> src/model/heightmap/simpleheightmap.rs:14:26
[INFO] [stderr]    |
[INFO] [stderr] 14 | const ROW_SPACING: f32 = 0.8660254037844386;
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.866_025_4`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::excessive_precision)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/model/heightmap/simpleheightmap.rs:192:23
[INFO] [stderr]     |
[INFO] [stderr] 192 |     pub fn from_map(map: &Vec<Vec<(u8, u8, u8, u8)>>,
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec<(u8, u8, u8, u8)>]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (8/7)
[INFO] [stderr]    --> src/model/heightmap/simpleheightmap.rs:192:2
[INFO] [stderr]     |
[INFO] [stderr] 192 |       pub fn from_map(map: &Vec<Vec<(u8, u8, u8, u8)>>,
[INFO] [stderr]     |  _____^
[INFO] [stderr] 193 | |             lowest: f32,
[INFO] [stderr] 194 | |             highest: f32,
[INFO] [stderr] 195 | |             x_offset: f32,
[INFO] [stderr] ...   |
[INFO] [stderr] 211 | |         heightmap
[INFO] [stderr] 212 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::too_many_arguments)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change
[INFO] [stderr]    --> src/model/heightmap/simpleheightmap.rs:206:23
[INFO] [stderr]     |
[INFO] [stderr] 206 |                 let mut height = (cell.0 as f32 + cell.1 as f32 + cell.2 as f32) / 768.0;
[INFO] [stderr]     |                                   ^^^^^^^^^^^^^ help: try: `f32::from(cell.0)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change
[INFO] [stderr]    --> src/model/heightmap/simpleheightmap.rs:206:39
[INFO] [stderr]     |
[INFO] [stderr] 206 |                 let mut height = (cell.0 as f32 + cell.1 as f32 + cell.2 as f32) / 768.0;
[INFO] [stderr]     |                                                   ^^^^^^^^^^^^^ help: try: `f32::from(cell.1)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change
[INFO] [stderr]    --> src/model/heightmap/simpleheightmap.rs:206:55
[INFO] [stderr]     |
[INFO] [stderr] 206 |                 let mut height = (cell.0 as f32 + cell.1 as f32 + cell.2 as f32) / 768.0;
[INFO] [stderr]     |                                                                   ^^^^^^^^^^^^^ help: try: `f32::from(cell.2)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/model/heightmap/simpleheightmap.rs:331:12
[INFO] [stderr]     |
[INFO] [stderr] 331 |         let mi = indices.iter().max().unwrap().clone() as usize;
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*indices.iter().max().unwrap()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `model::mem::ModelLibrary`
[INFO] [stderr]   --> src/model/mem.rs:70:2
[INFO] [stderr]    |
[INFO] [stderr] 70 |       pub fn new() -> ModelLibrary {
[INFO] [stderr]    |  _____^
[INFO] [stderr] 71 | |         ModelLibrary {
[INFO] [stderr] 72 | |             geoms: RefCell::new(Vec::new()),
[INFO] [stderr] 73 | |             mats: RefCell::new(Vec::new()),
[INFO] [stderr] 74 | |             models: RefCell::new(Vec::new()),
[INFO] [stderr] 75 | |         }
[INFO] [stderr] 76 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 61 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/renderable.rs:84:27
[INFO] [stderr]    |
[INFO] [stderr] 84 |         let chars_high = (256 / chars_wide as u16) as u8;
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^^^^^ help: try: `u16::from(chars_wide)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/renderable.rs:85:35
[INFO] [stderr]    |
[INFO] [stderr] 85 |         let char_width = font.width() / chars_wide as u32;
[INFO] [stderr]    |                                         ^^^^^^^^^^^^^^^^^ help: try: `u32::from(chars_wide)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/renderable.rs:86:37
[INFO] [stderr]    |
[INFO] [stderr] 86 |         let char_height = font.height() / chars_high as u32;
[INFO] [stderr]    |                                           ^^^^^^^^^^^^^^^^^ help: try: `u32::from(chars_high)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `idx` is used as a loop counter. Consider using `for (idx, item) in self.text.iter().enumerate()` or similar iterators
[INFO] [stderr]    --> src/renderable.rs:102:20
[INFO] [stderr]     |
[INFO] [stderr] 102 |         for character in self.text.iter() {
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::explicit_counter_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/renderable.rs:103:24
[INFO] [stderr]     |
[INFO] [stderr] 103 |             let char_origin_x = (character % self.chars_wide) as u32 * self.char_width;
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(character % self.chars_wide)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/renderable.rs:104:24
[INFO] [stderr]     |
[INFO] [stderr] 104 |             let char_origin_y = (self.chars_high - character / self.chars_high - 1) as u32 *
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.chars_high - character / self.chars_high - 1)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:119:5
[INFO] [stderr]     |
[INFO] [stderr] 119 |             .ok_or(Error::from("Floor material library missing floor material (\"Floor\")")) };
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from("Floor material library missing floor material (\"Floor\")"))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:171:13
[INFO] [stderr]     |
[INFO] [stderr] 171 |         let obx = x as f32 * 1.5;
[INFO] [stderr]     |                   ^^^^^^^^ help: try: `f32::from(x)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:172:13
[INFO] [stderr]     |
[INFO] [stderr] 172 |         let oby = y as f32 * 1.5;
[INFO] [stderr]     |                   ^^^^^^^^ help: try: `f32::from(y)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:173:13
[INFO] [stderr]     |
[INFO] [stderr] 173 |         let obz = z as f32 * 1.5;
[INFO] [stderr]     |                   ^^^^^^^^ help: try: `f32::from(z)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/main.rs:213:8
[INFO] [stderr]     |
[INFO] [stderr] 213 |         loc: character.loc().clone(),
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*character.loc()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/main.rs:302:16
[INFO] [stderr]     |
[INFO] [stderr] 302 |         camera.loc = character.loc().clone();
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*character.loc()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:354:8
[INFO] [stderr]     |
[INFO] [stderr] 354 |                         .unwrap_or("unknown source line".to_string()),
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "unknown source line".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/display_math.rs:76:27
[INFO] [stderr]    |
[INFO] [stderr] 76 |         window.get_inner_size().ok_or(Error::from("Could not get window size"))
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from("Could not get window size"))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/model/disk.rs:25:14
[INFO] [stderr]    |
[INFO] [stderr] 25 |         obj::parse(object_str.into())
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `object_str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/model/disk.rs:31:5
[INFO] [stderr]    |
[INFO] [stderr] 31 |             .ok_or(Error::from("Object lacks material specification (usemtl)"))
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from("Object lacks material specification (usemtl)"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/model/disk.rs:44:5
[INFO] [stderr]    |
[INFO] [stderr] 44 |             .ok_or(Error::from("No objects in object file"))
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from("No objects in object file"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/model/disk.rs:104:14
[INFO] [stderr]     |
[INFO] [stderr] 104 |         mtl::parse(mat_str.into())
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^ help: consider removing `.into()`: `mat_str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/model/disk.rs:111:6
[INFO] [stderr]     |
[INFO] [stderr] 111 |                 .ok_or(Error::from("Material lacks texture specification (map_Kd)"))
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from("Material lacks texture specification (map_Kd)"))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]    --> src/model/disk.rs:135:41
[INFO] [stderr]     |
[INFO] [stderr] 135 | pub fn load_texture<T>(read: &mut T) -> Result<Vec<Vec<(u8, u8, u8, u8)>>>
[INFO] [stderr]     |                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::type_complexity)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: float has excessive precision
[INFO] [stderr]   --> src/model/heightmap/simpleheightmap.rs:14:26
[INFO] [stderr]    |
[INFO] [stderr] 14 | const ROW_SPACING: f32 = 0.8660254037844386;
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.866_025_4`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::excessive_precision)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/model/heightmap/simpleheightmap.rs:192:23
[INFO] [stderr]     |
[INFO] [stderr] 192 |     pub fn from_map(map: &Vec<Vec<(u8, u8, u8, u8)>>,
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec<(u8, u8, u8, u8)>]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (8/7)
[INFO] [stderr]    --> src/model/heightmap/simpleheightmap.rs:192:2
[INFO] [stderr]     |
[INFO] [stderr] 192 |       pub fn from_map(map: &Vec<Vec<(u8, u8, u8, u8)>>,
[INFO] [stderr]     |  _____^
[INFO] [stderr] 193 | |             lowest: f32,
[INFO] [stderr] 194 | |             highest: f32,
[INFO] [stderr] 195 | |             x_offset: f32,
[INFO] [stderr] ...   |
[INFO] [stderr] 211 | |         heightmap
[INFO] [stderr] 212 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::too_many_arguments)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change
[INFO] [stderr]    --> src/model/heightmap/simpleheightmap.rs:206:23
[INFO] [stderr]     |
[INFO] [stderr] 206 |                 let mut height = (cell.0 as f32 + cell.1 as f32 + cell.2 as f32) / 768.0;
[INFO] [stderr]     |                                   ^^^^^^^^^^^^^ help: try: `f32::from(cell.0)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change
[INFO] [stderr]    --> src/model/heightmap/simpleheightmap.rs:206:39
[INFO] [stderr]     |
[INFO] [stderr] 206 |                 let mut height = (cell.0 as f32 + cell.1 as f32 + cell.2 as f32) / 768.0;
[INFO] [stderr]     |                                                   ^^^^^^^^^^^^^ help: try: `f32::from(cell.1)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change
[INFO] [stderr]    --> src/model/heightmap/simpleheightmap.rs:206:55
[INFO] [stderr]     |
[INFO] [stderr] 206 |                 let mut height = (cell.0 as f32 + cell.1 as f32 + cell.2 as f32) / 768.0;
[INFO] [stderr]     |                                                                   ^^^^^^^^^^^^^ help: try: `f32::from(cell.2)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/model/heightmap/simpleheightmap.rs:331:12
[INFO] [stderr]     |
[INFO] [stderr] 331 |         let mi = indices.iter().max().unwrap().clone() as usize;
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*indices.iter().max().unwrap()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `model::mem::ModelLibrary`
[INFO] [stderr]   --> src/model/mem.rs:70:2
[INFO] [stderr]    |
[INFO] [stderr] 70 |       pub fn new() -> ModelLibrary {
[INFO] [stderr]    |  _____^
[INFO] [stderr] 71 | |         ModelLibrary {
[INFO] [stderr] 72 | |             geoms: RefCell::new(Vec::new()),
[INFO] [stderr] 73 | |             mats: RefCell::new(Vec::new()),
[INFO] [stderr] 74 | |             models: RefCell::new(Vec::new()),
[INFO] [stderr] 75 | |         }
[INFO] [stderr] 76 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 61 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/renderable.rs:84:27
[INFO] [stderr]    |
[INFO] [stderr] 84 |         let chars_high = (256 / chars_wide as u16) as u8;
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^^^^^ help: try: `u16::from(chars_wide)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/renderable.rs:85:35
[INFO] [stderr]    |
[INFO] [stderr] 85 |         let char_width = font.width() / chars_wide as u32;
[INFO] [stderr]    |                                         ^^^^^^^^^^^^^^^^^ help: try: `u32::from(chars_wide)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/renderable.rs:86:37
[INFO] [stderr]    |
[INFO] [stderr] 86 |         let char_height = font.height() / chars_high as u32;
[INFO] [stderr]    |                                           ^^^^^^^^^^^^^^^^^ help: try: `u32::from(chars_high)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `idx` is used as a loop counter. Consider using `for (idx, item) in self.text.iter().enumerate()` or similar iterators
[INFO] [stderr]    --> src/renderable.rs:102:20
[INFO] [stderr]     |
[INFO] [stderr] 102 |         for character in self.text.iter() {
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::explicit_counter_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/renderable.rs:103:24
[INFO] [stderr]     |
[INFO] [stderr] 103 |             let char_origin_x = (character % self.chars_wide) as u32 * self.char_width;
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(character % self.chars_wide)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/renderable.rs:104:24
[INFO] [stderr]     |
[INFO] [stderr] 104 |             let char_origin_y = (self.chars_high - character / self.chars_high - 1) as u32 *
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.chars_high - character / self.chars_high - 1)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:119:5
[INFO] [stderr]     |
[INFO] [stderr] 119 |             .ok_or(Error::from("Floor material library missing floor material (\"Floor\")")) };
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from("Floor material library missing floor material (\"Floor\")"))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:171:13
[INFO] [stderr]     |
[INFO] [stderr] 171 |         let obx = x as f32 * 1.5;
[INFO] [stderr]     |                   ^^^^^^^^ help: try: `f32::from(x)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:172:13
[INFO] [stderr]     |
[INFO] [stderr] 172 |         let oby = y as f32 * 1.5;
[INFO] [stderr]     |                   ^^^^^^^^ help: try: `f32::from(y)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:173:13
[INFO] [stderr]     |
[INFO] [stderr] 173 |         let obz = z as f32 * 1.5;
[INFO] [stderr]     |                   ^^^^^^^^ help: try: `f32::from(z)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/main.rs:213:8
[INFO] [stderr]     |
[INFO] [stderr] 213 |         loc: character.loc().clone(),
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*character.loc()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/main.rs:302:16
[INFO] [stderr]     |
[INFO] [stderr] 302 |         camera.loc = character.loc().clone();
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*character.loc()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:354:8
[INFO] [stderr]     |
[INFO] [stderr] 354 |                         .unwrap_or("unknown source line".to_string()),
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "unknown source line".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1m 18s
[INFO] running `"docker" "inspect" "287dfbb8a8669e1c6ae095136b9fc2e9b7da2d33fb557af8690fe44ccf9b24d4"`
[INFO] running `"docker" "rm" "-f" "287dfbb8a8669e1c6ae095136b9fc2e9b7da2d33fb557af8690fe44ccf9b24d4"`
[INFO] [stdout] 287dfbb8a8669e1c6ae095136b9fc2e9b7da2d33fb557af8690fe44ccf9b24d4