[INFO] updating cached repository whbboyd/backup [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/whbboyd/backup [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/whbboyd/backup" "work/ex/clippy-test-run/sources/stable/gh/whbboyd/backup"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/whbboyd/backup'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/whbboyd/backup" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/whbboyd/backup"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/whbboyd/backup'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9c017ef861f0861ab01f79fdbb7c05c5dc0b34b7 [INFO] sha for GitHub repo whbboyd/backup: 9c017ef861f0861ab01f79fdbb7c05c5dc0b34b7 [INFO] validating manifest of whbboyd/backup on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of whbboyd/backup on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing whbboyd/backup [INFO] finished frobbing whbboyd/backup [INFO] frobbed toml for whbboyd/backup written to work/ex/clippy-test-run/sources/stable/gh/whbboyd/backup/Cargo.toml [INFO] started frobbing whbboyd/backup [INFO] finished frobbing whbboyd/backup [INFO] frobbed toml for whbboyd/backup written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/whbboyd/backup/Cargo.toml [INFO] crate whbboyd/backup has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting whbboyd/backup against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/whbboyd/backup:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 22e2a88b3c6cb81c1aa44c9d17be96ae4016dcd616b8e950fd2befb4ac5f267e [INFO] running `"docker" "start" "-a" "22e2a88b3c6cb81c1aa44c9d17be96ae4016dcd616b8e950fd2befb4ac5f267e"` [INFO] [stderr] Checking libc v0.2.7 [INFO] [stderr] Compiling gcc v0.3.25 [INFO] [stderr] Compiling pkg-config v0.3.7 [INFO] [stderr] Checking winapi v0.2.5 [INFO] [stderr] Checking regex-syntax v0.2.5 [INFO] [stderr] Checking strsim v0.3.0 [INFO] [stderr] Checking libc v0.1.12 [INFO] [stderr] Compiling kernel32-sys v0.2.1 [INFO] [stderr] Checking memchr v0.1.10 [INFO] [stderr] Checking filetime v0.1.10 [INFO] [stderr] Checking rand v0.3.14 [INFO] [stderr] Checking time v0.1.34 [INFO] [stderr] Checking walkdir v0.1.5 [INFO] [stderr] Compiling libz-sys v1.0.1 [INFO] [stderr] Compiling rust-crypto v0.2.34 [INFO] [stderr] Checking tar v0.4.4 [INFO] [stderr] Checking aho-corasick v0.5.1 [INFO] [stderr] Checking regex v0.1.54 [INFO] [stderr] Checking flate2 v0.2.13 [INFO] [stderr] Checking docopt v0.6.78 [INFO] [stderr] Checking env_logger v0.3.5 [INFO] [stderr] Checking backup v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:23:19 [INFO] [stderr] | [INFO] [stderr] 23 | pub const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:23:19 [INFO] [stderr] | [INFO] [stderr] 23 | pub const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/operations.rs:94:8 [INFO] [stderr] | [INFO] [stderr] 94 | .unwrap_or(path.to_str().unwrap().to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| path.to_str().unwrap().to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/operations.rs:120:35 [INFO] [stderr] | [INFO] [stderr] 120 | pub fn save_checksums(checksums: &HashMap, fname:&str) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 120 | pub fn save_checksums(checksums: &HashMap, fname:&str) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/operations.rs:150:19 [INFO] [stderr] | [INFO] [stderr] 150 | new_checksums: &HashMap, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 149 | pub fn write_archive( [INFO] [stderr] 150 | new_checksums: &HashMap, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/operations.rs:151:19 [INFO] [stderr] | [INFO] [stderr] 151 | old_checksums: &HashMap, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 149 | pub fn write_archive( [INFO] [stderr] 150 | new_checksums: &HashMap, [INFO] [stderr] 151 | old_checksums: &HashMap, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/operations.rs:94:8 [INFO] [stderr] | [INFO] [stderr] 94 | .unwrap_or(path.to_str().unwrap().to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| path.to_str().unwrap().to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/operations.rs:120:35 [INFO] [stderr] | [INFO] [stderr] 120 | pub fn save_checksums(checksums: &HashMap, fname:&str) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 120 | pub fn save_checksums(checksums: &HashMap, fname:&str) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/operations.rs:150:19 [INFO] [stderr] | [INFO] [stderr] 150 | new_checksums: &HashMap, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 149 | pub fn write_archive( [INFO] [stderr] 150 | new_checksums: &HashMap, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/operations.rs:151:19 [INFO] [stderr] | [INFO] [stderr] 151 | old_checksums: &HashMap, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 149 | pub fn write_archive( [INFO] [stderr] 150 | new_checksums: &HashMap, [INFO] [stderr] 151 | old_checksums: &HashMap, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 20.60s [INFO] running `"docker" "inspect" "22e2a88b3c6cb81c1aa44c9d17be96ae4016dcd616b8e950fd2befb4ac5f267e"` [INFO] running `"docker" "rm" "-f" "22e2a88b3c6cb81c1aa44c9d17be96ae4016dcd616b8e950fd2befb4ac5f267e"` [INFO] [stdout] 22e2a88b3c6cb81c1aa44c9d17be96ae4016dcd616b8e950fd2befb4ac5f267e