[INFO] updating cached repository wfraser/zsnapmgr_rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/wfraser/zsnapmgr_rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/wfraser/zsnapmgr_rust" "work/ex/clippy-test-run/sources/stable/gh/wfraser/zsnapmgr_rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/wfraser/zsnapmgr_rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/wfraser/zsnapmgr_rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wfraser/zsnapmgr_rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wfraser/zsnapmgr_rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 209a96100a86b3271d65e5d81800afaf30481a25 [INFO] sha for GitHub repo wfraser/zsnapmgr_rust: 209a96100a86b3271d65e5d81800afaf30481a25 [INFO] validating manifest of wfraser/zsnapmgr_rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wfraser/zsnapmgr_rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wfraser/zsnapmgr_rust [INFO] finished frobbing wfraser/zsnapmgr_rust [INFO] frobbed toml for wfraser/zsnapmgr_rust written to work/ex/clippy-test-run/sources/stable/gh/wfraser/zsnapmgr_rust/Cargo.toml [INFO] started frobbing wfraser/zsnapmgr_rust [INFO] finished frobbing wfraser/zsnapmgr_rust [INFO] frobbed toml for wfraser/zsnapmgr_rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wfraser/zsnapmgr_rust/Cargo.toml [INFO] crate wfraser/zsnapmgr_rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wfraser/zsnapmgr_rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/wfraser/zsnapmgr_rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e865e64296e6411ece6d5b9645b4728e89d0218ad75b026e26c802fd3a361ca5 [INFO] running `"docker" "start" "-a" "e865e64296e6411ece6d5b9645b4728e89d0218ad75b026e26c802fd3a361ca5"` [INFO] [stderr] Checking termios v0.3.1 [INFO] [stderr] Compiling ring v0.13.2 [INFO] [stderr] Checking memchr v2.1.0 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Checking aho-corasick v0.6.8 [INFO] [stderr] Checking regex v1.0.5 [INFO] [stderr] Checking zsnapmgr v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/zfs_error.rs:99:13 [INFO] [stderr] | [INFO] [stderr] 99 | descr: descr, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `descr` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/zfs_error.rs:99:13 [INFO] [stderr] | [INFO] [stderr] 99 | descr: descr, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `descr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hash_stream.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/zfs.rs:87:1 [INFO] [stderr] | [INFO] [stderr] 87 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:106:31 [INFO] [stderr] | [INFO] [stderr] 106 | ZSnapMgr { zfs: ZFS { use_sudo: use_sudo } } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `use_sudo` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hash_stream.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/zfs.rs:87:1 [INFO] [stderr] | [INFO] [stderr] 87 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/lib.rs:227:17 [INFO] [stderr] | [INFO] [stderr] 227 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:106:31 [INFO] [stderr] | [INFO] [stderr] 106 | ZSnapMgr { zfs: ZFS { use_sudo: use_sudo } } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `use_sudo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/lib.rs:227:17 [INFO] [stderr] | [INFO] [stderr] 227 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/zfs.rs:93:36 [INFO] [stderr] | [INFO] [stderr] 93 | assert_eq!(human_number( 999900, 1), "999.9 k"); [INFO] [stderr] | ^^^^^^ help: consider: `999_900` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/zfs.rs:94:35 [INFO] [stderr] | [INFO] [stderr] 94 | assert_eq!(human_number( 1000000, 1), "1.0 M"); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/zfs.rs:95:32 [INFO] [stderr] | [INFO] [stderr] 95 | assert_eq!(human_number( 1000000000, 1), "1.0 G"); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/zfs.rs:96:29 [INFO] [stderr] | [INFO] [stderr] 96 | assert_eq!(human_number(1000000000000, 1), "1.0 T"); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `1_000_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: use as_ref() instead [INFO] [stderr] --> src/zfs_error.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | / match self.io_error { [INFO] [stderr] 30 | | Some(ref e) => Some(e), [INFO] [stderr] 31 | | None => None, [INFO] [stderr] 32 | | } [INFO] [stderr] | |_________^ help: try this: `self.io_error.as_ref()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_as_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_as_ref [INFO] [stderr] [INFO] [stderr] warning: use as_ref() instead [INFO] [stderr] --> src/zfs_error.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | / match self.io_error { [INFO] [stderr] 30 | | Some(ref e) => Some(e), [INFO] [stderr] 31 | | None => None, [INFO] [stderr] 32 | | } [INFO] [stderr] | |_________^ help: try this: `self.io_error.as_ref()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_as_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_as_ref [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/table.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | write!(f, "\n") [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/backups.rs:56:21 [INFO] [stderr] | [INFO] [stderr] 56 | filename_base: filename_base, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `filename_base` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/backups.rs:57:21 [INFO] [stderr] | [INFO] [stderr] 57 | volume: volume, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `volume` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/backups.rs:58:21 [INFO] [stderr] | [INFO] [stderr] 58 | start_snapshot: start_snapshot, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `start_snapshot` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint name `for_kv_map` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/backups.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | #[allow(for_kv_map)] [INFO] [stderr] | ^^^^^^^^^^ help: change it to: `clippy::for_kv_map` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:241:25 [INFO] [stderr] | [INFO] [stderr] 241 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/table.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | write!(f, "\n") [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/backups.rs:56:21 [INFO] [stderr] | [INFO] [stderr] 56 | filename_base: filename_base, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `filename_base` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/backups.rs:57:21 [INFO] [stderr] | [INFO] [stderr] 57 | volume: volume, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `volume` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/backups.rs:58:21 [INFO] [stderr] | [INFO] [stderr] 58 | start_snapshot: start_snapshot, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `start_snapshot` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint name `for_kv_map` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/backups.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | #[allow(for_kv_map)] [INFO] [stderr] | ^^^^^^^^^^ help: change it to: `clippy::for_kv_map` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:241:25 [INFO] [stderr] | [INFO] [stderr] 241 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: lint name `for_kv_map` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/backups.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | #[allow(for_kv_map)] [INFO] [stderr] | ^^^^^^^^^^ help: change it to: `clippy::for_kv_map` [INFO] [stderr] [INFO] [stderr] warning: lint name `for_kv_map` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/backups.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | #[allow(for_kv_map)] [INFO] [stderr] | ^^^^^^^^^^ help: change it to: `clippy::for_kv_map` [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:192:16 [INFO] [stderr] | [INFO] [stderr] 192 | if !volume_snaps.binary_search(&start_snapshot.deref()).is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `volume_snaps.binary_search(&start_snapshot.deref()).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:192:16 [INFO] [stderr] | [INFO] [stderr] 192 | if !volume_snaps.binary_search(&start_snapshot.deref()).is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `volume_snaps.binary_search(&start_snapshot.deref()).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.92s [INFO] running `"docker" "inspect" "e865e64296e6411ece6d5b9645b4728e89d0218ad75b026e26c802fd3a361ca5"` [INFO] running `"docker" "rm" "-f" "e865e64296e6411ece6d5b9645b4728e89d0218ad75b026e26c802fd3a361ca5"` [INFO] [stdout] e865e64296e6411ece6d5b9645b4728e89d0218ad75b026e26c802fd3a361ca5