[INFO] updating cached repository wfraser/stget [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/wfraser/stget [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/wfraser/stget" "work/ex/clippy-test-run/sources/stable/gh/wfraser/stget"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/wfraser/stget'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/wfraser/stget" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wfraser/stget"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wfraser/stget'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ce2c0968b5d0ed71575ecd8c95d5f43f3dab25ef [INFO] sha for GitHub repo wfraser/stget: ce2c0968b5d0ed71575ecd8c95d5f43f3dab25ef [INFO] validating manifest of wfraser/stget on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wfraser/stget on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wfraser/stget [INFO] finished frobbing wfraser/stget [INFO] frobbed toml for wfraser/stget written to work/ex/clippy-test-run/sources/stable/gh/wfraser/stget/Cargo.toml [INFO] started frobbing wfraser/stget [INFO] finished frobbing wfraser/stget [INFO] frobbed toml for wfraser/stget written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wfraser/stget/Cargo.toml [INFO] crate wfraser/stget has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wfraser/stget against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/wfraser/stget:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e13f30cdcecb30b38ea72b41bb2336f01511fc65eb2c2be074cf16d5730fc577 [INFO] running `"docker" "start" "-a" "e13f30cdcecb30b38ea72b41bb2336f01511fc65eb2c2be074cf16d5730fc577"` [INFO] [stderr] Compiling regex v1.0.1 [INFO] [stderr] Compiling protobuf v2.0.3 [INFO] [stderr] Checking base32 v0.3.1 [INFO] [stderr] Checking bufstream v0.1.3 [INFO] [stderr] Compiling ring v0.13.0-alpha5 [INFO] [stderr] Checking memchr v2.0.1 [INFO] [stderr] Checking regex-syntax v0.6.1 [INFO] [stderr] Checking log v0.4.3 [INFO] [stderr] Checking lz4-compress v0.1.1 [INFO] [stderr] Checking thread_local v0.3.5 [INFO] [stderr] Checking clap v2.32.0 [INFO] [stderr] Checking aho-corasick v0.6.5 [INFO] [stderr] Checking backtrace v0.3.9 [INFO] [stderr] Checking error-chain v0.12.0 [INFO] [stderr] Checking sct v0.3.0 [INFO] [stderr] Checking webpki v0.18.0-alpha4 [INFO] [stderr] Checking rustls v0.12.0 [INFO] [stderr] Checking env_logger v0.5.10 [INFO] [stderr] Checking stget v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/syncthing_proto.rs:6:10 [INFO] [stderr] | [INFO] [stderr] 6 | #![allow(clippy)] [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `many_single_char_names` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/util.rs:7:9 [INFO] [stderr] | [INFO] [stderr] 7 | #[allow(many_single_char_names)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::many_single_char_names` [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/syncthing_proto.rs:6:10 [INFO] [stderr] | [INFO] [stderr] 6 | #![allow(clippy)] [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `many_single_char_names` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/util.rs:7:9 [INFO] [stderr] | [INFO] [stderr] 7 | #[allow(many_single_char_names)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::many_single_char_names` [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/syncthing_proto.rs:6:10 [INFO] [stderr] | [INFO] [stderr] 6 | #![allow(clippy)] [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/syncthing_proto.rs:6:10 [INFO] [stderr] | [INFO] [stderr] 6 | #![allow(clippy)] [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/bin/stget.rs:562:14 [INFO] [stderr] | [INFO] [stderr] 562 | for i in 0 .. ((data.len() / 16) + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=(data.len() / 16)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/bin/stget.rs:562:14 [INFO] [stderr] | [INFO] [stderr] 562 | for i in 0 .. ((data.len() / 16) + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=(data.len() / 16)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 24.34s [INFO] running `"docker" "inspect" "e13f30cdcecb30b38ea72b41bb2336f01511fc65eb2c2be074cf16d5730fc577"` [INFO] running `"docker" "rm" "-f" "e13f30cdcecb30b38ea72b41bb2336f01511fc65eb2c2be074cf16d5730fc577"` [INFO] [stdout] e13f30cdcecb30b38ea72b41bb2336f01511fc65eb2c2be074cf16d5730fc577