[INFO] updating cached repository wfraser/slowpty [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/wfraser/slowpty [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/wfraser/slowpty" "work/ex/clippy-test-run/sources/stable/gh/wfraser/slowpty"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/wfraser/slowpty'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/wfraser/slowpty" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wfraser/slowpty"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wfraser/slowpty'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e9a12514756083077974b3bc5c48c5e691fbf03f [INFO] sha for GitHub repo wfraser/slowpty: e9a12514756083077974b3bc5c48c5e691fbf03f [INFO] validating manifest of wfraser/slowpty on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wfraser/slowpty on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wfraser/slowpty [INFO] finished frobbing wfraser/slowpty [INFO] frobbed toml for wfraser/slowpty written to work/ex/clippy-test-run/sources/stable/gh/wfraser/slowpty/Cargo.toml [INFO] started frobbing wfraser/slowpty [INFO] finished frobbing wfraser/slowpty [INFO] frobbed toml for wfraser/slowpty written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wfraser/slowpty/Cargo.toml [INFO] crate wfraser/slowpty has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wfraser/slowpty against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/wfraser/slowpty:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 484e851ccba979cf589b10def2f69d00fab0e134f2e17c1f381ce53b07fab16f [INFO] running `"docker" "start" "-a" "484e851ccba979cf589b10def2f69d00fab0e134f2e17c1f381ce53b07fab16f"` [INFO] [stderr] Checking termcolor v1.0.4 [INFO] [stderr] Compiling memchr v2.1.0 [INFO] [stderr] Checking log v0.4.5 [INFO] [stderr] Checking errno v0.2.4 [INFO] [stderr] Checking exec v0.3.1 [INFO] [stderr] Checking mio v0.6.16 [INFO] [stderr] Checking aho-corasick v0.6.8 [INFO] [stderr] Checking regex v1.0.5 [INFO] [stderr] Checking env_logger v0.5.13 [INFO] [stderr] Checking slowpty v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/delay.rs:13:28 [INFO] [stderr] | [INFO] [stderr] 13 | let delay_nanos = (SEC_NS as f64 / rate) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(SEC_NS)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/delay.rs:13:28 [INFO] [stderr] | [INFO] [stderr] 13 | let delay_nanos = (SEC_NS as f64 / rate) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(SEC_NS)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/term.rs:52:39 [INFO] [stderr] | [INFO] [stderr] 52 | checkerr(unsafe { libc::ioctl(fd, libc::c_ulong::from(libc::TIOCSCTTY), 1) }, "ioctl(TIOCSCTTY)") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `libc::c_ulong::from()`: `libc::TIOCSCTTY` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/term.rs:52:39 [INFO] [stderr] | [INFO] [stderr] 52 | checkerr(unsafe { libc::ioctl(fd, libc::c_ulong::from(libc::TIOCSCTTY), 1) }, "ioctl(TIOCSCTTY)") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `libc::c_ulong::from()`: `libc::TIOCSCTTY` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:72:38 [INFO] [stderr] | [INFO] [stderr] 72 | assert!(!signal_name(9).contains("9")); [INFO] [stderr] | ^^^ help: try using a char instead: `'9'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:74:37 [INFO] [stderr] | [INFO] [stderr] 74 | assert!(signal_name(0).contains("0")); [INFO] [stderr] | ^^^ help: try using a char instead: `'0'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/main.rs:147:1 [INFO] [stderr] | [INFO] [stderr] 147 | / fn main() { [INFO] [stderr] 148 | | env_logger::init(); [INFO] [stderr] 149 | | [INFO] [stderr] 150 | | let args: Vec = std::env::args().collect(); [INFO] [stderr] ... | [INFO] [stderr] 277 | | debug!("returning from main"); [INFO] [stderr] 278 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/main.rs:147:1 [INFO] [stderr] | [INFO] [stderr] 147 | / fn main() { [INFO] [stderr] 148 | | env_logger::init(); [INFO] [stderr] 149 | | [INFO] [stderr] 150 | | let args: Vec = std::env::args().collect(); [INFO] [stderr] ... | [INFO] [stderr] 277 | | debug!("returning from main"); [INFO] [stderr] 278 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.74s [INFO] running `"docker" "inspect" "484e851ccba979cf589b10def2f69d00fab0e134f2e17c1f381ce53b07fab16f"` [INFO] running `"docker" "rm" "-f" "484e851ccba979cf589b10def2f69d00fab0e134f2e17c1f381ce53b07fab16f"` [INFO] [stdout] 484e851ccba979cf589b10def2f69d00fab0e134f2e17c1f381ce53b07fab16f