[INFO] updating cached repository wfraser/goto [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/wfraser/goto [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/wfraser/goto" "work/ex/clippy-test-run/sources/stable/gh/wfraser/goto"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/wfraser/goto'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/wfraser/goto" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wfraser/goto"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wfraser/goto'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 48229d1fbba748b534b91395389df4415ac0e6de [INFO] sha for GitHub repo wfraser/goto: 48229d1fbba748b534b91395389df4415ac0e6de [INFO] validating manifest of wfraser/goto on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wfraser/goto on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wfraser/goto [INFO] finished frobbing wfraser/goto [INFO] frobbed toml for wfraser/goto written to work/ex/clippy-test-run/sources/stable/gh/wfraser/goto/Cargo.toml [INFO] started frobbing wfraser/goto [INFO] finished frobbing wfraser/goto [INFO] frobbed toml for wfraser/goto written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wfraser/goto/Cargo.toml [INFO] crate wfraser/goto has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wfraser/goto against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/wfraser/goto:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8cb9666833f4dfcd0c4a4b9a8f8881cbbc129485e4b86a9bcf6a03943ab60cbf [INFO] running `"docker" "start" "-a" "8cb9666833f4dfcd0c4a4b9a8f8881cbbc129485e4b86a9bcf6a03943ab60cbf"` [INFO] [stderr] Checking strsim v0.5.2 [INFO] [stderr] Checking toml v0.1.30 [INFO] [stderr] Checking docopt v0.6.86 [INFO] [stderr] Checking goto v2.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:16:25 [INFO] [stderr] | [INFO] [stderr] 16 | const CONFIG_FILENAME: &'static str = ".goto.toml"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:17:26 [INFO] [stderr] | [INFO] [stderr] 17 | const DEFAULT_SHELLCMD: &'static str = "pushd"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:21:15 [INFO] [stderr] | [INFO] [stderr] 21 | const USAGE: &'static str = r#" [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:16:25 [INFO] [stderr] | [INFO] [stderr] 16 | const CONFIG_FILENAME: &'static str = ".goto.toml"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:17:26 [INFO] [stderr] | [INFO] [stderr] 17 | const DEFAULT_SHELLCMD: &'static str = "pushd"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:21:15 [INFO] [stderr] | [INFO] [stderr] 21 | const USAGE: &'static str = r#" [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | env::home_dir().unwrap().join(&Path::new(&s[2..])) [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:193:16 [INFO] [stderr] | [INFO] [stderr] 193 | let home = env::home_dir().unwrap_or_else(|| { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | env::home_dir().unwrap().join(&Path::new(&s[2..])) [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:193:16 [INFO] [stderr] | [INFO] [stderr] 193 | let home = env::home_dir().unwrap_or_else(|| { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:198:15 [INFO] [stderr] | [INFO] [stderr] 198 | let cwd = PathBuf::from(env::current_dir().unwrap_or_else(|e| { [INFO] [stderr] | _______________^ [INFO] [stderr] 199 | | exit(&format!("unable to get current working directory: {}", e), true); [INFO] [stderr] 200 | | })); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `PathBuf::from()` [INFO] [stderr] | [INFO] [stderr] 198 | let cwd = env::current_dir().unwrap_or_else(|e| { [INFO] [stderr] 199 | exit(&format!("unable to get current working directory: {}", e), true); [INFO] [stderr] 200 | }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/main.rs:242:13 [INFO] [stderr] | [INFO] [stderr] 242 | writeln!(io::stderr(), "{} → {:?}", k, v).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:198:15 [INFO] [stderr] | [INFO] [stderr] 198 | let cwd = PathBuf::from(env::current_dir().unwrap_or_else(|e| { [INFO] [stderr] | _______________^ [INFO] [stderr] 199 | | exit(&format!("unable to get current working directory: {}", e), true); [INFO] [stderr] 200 | | })); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `PathBuf::from()` [INFO] [stderr] | [INFO] [stderr] 198 | let cwd = env::current_dir().unwrap_or_else(|e| { [INFO] [stderr] 199 | exit(&format!("unable to get current working directory: {}", e), true); [INFO] [stderr] 200 | }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/main.rs:242:13 [INFO] [stderr] | [INFO] [stderr] 242 | writeln!(io::stderr(), "{} → {:?}", k, v).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.18s [INFO] running `"docker" "inspect" "8cb9666833f4dfcd0c4a4b9a8f8881cbbc129485e4b86a9bcf6a03943ab60cbf"` [INFO] running `"docker" "rm" "-f" "8cb9666833f4dfcd0c4a4b9a8f8881cbbc129485e4b86a9bcf6a03943ab60cbf"` [INFO] [stdout] 8cb9666833f4dfcd0c4a4b9a8f8881cbbc129485e4b86a9bcf6a03943ab60cbf