[INFO] updating cached repository wfraser/dc4 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/wfraser/dc4 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/wfraser/dc4" "work/ex/clippy-test-run/sources/stable/gh/wfraser/dc4"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/wfraser/dc4'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/wfraser/dc4" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wfraser/dc4"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wfraser/dc4'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ca53057eb6305f8ceb56c1dda5ae383475b9a2a0 [INFO] sha for GitHub repo wfraser/dc4: ca53057eb6305f8ceb56c1dda5ae383475b9a2a0 [INFO] validating manifest of wfraser/dc4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wfraser/dc4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wfraser/dc4 [INFO] finished frobbing wfraser/dc4 [INFO] frobbed toml for wfraser/dc4 written to work/ex/clippy-test-run/sources/stable/gh/wfraser/dc4/Cargo.toml [INFO] started frobbing wfraser/dc4 [INFO] finished frobbing wfraser/dc4 [INFO] frobbed toml for wfraser/dc4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wfraser/dc4/Cargo.toml [INFO] crate wfraser/dc4 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wfraser/dc4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/wfraser/dc4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7deb968ccbed1bf7c6bb43bdc22b50c2f2131d24afe02f7e989349c9fa6dad07 [INFO] running `"docker" "start" "-a" "7deb968ccbed1bf7c6bb43bdc22b50c2f2131d24afe02f7e989349c9fa6dad07"` [INFO] [stderr] Compiling num-complex v0.2.1 [INFO] [stderr] Compiling dc4 v1.1.1 (/opt/crater/workdir) [INFO] [stderr] Checking num v0.2.0 [INFO] [stderr] warning: lint name `redundant_closure_call` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:7:25 [INFO] [stderr] | [INFO] [stderr] 7 | #![allow(unknown_lints, redundant_closure_call)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::redundant_closure_call` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `suspicious_arithmetic_impl` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/big_real.rs:483:17 [INFO] [stderr] | [INFO] [stderr] 483 | #[allow(suspicious_arithmetic_impl)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::suspicious_arithmetic_impl` [INFO] [stderr] [INFO] [stderr] warning: lint name `redundant_closure_call` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:7:25 [INFO] [stderr] | [INFO] [stderr] 7 | #![allow(unknown_lints, redundant_closure_call)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::redundant_closure_call` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `suspicious_arithmetic_impl` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/big_real.rs:483:17 [INFO] [stderr] | [INFO] [stderr] 483 | #[allow(suspicious_arithmetic_impl)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::suspicious_arithmetic_impl` [INFO] [stderr] [INFO] [stderr] warning: lint name `redundant_closure_call` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:7:25 [INFO] [stderr] | [INFO] [stderr] 7 | #![allow(unknown_lints, redundant_closure_call)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::redundant_closure_call` [INFO] [stderr] [INFO] [stderr] warning: lint name `redundant_closure_call` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:7:25 [INFO] [stderr] | [INFO] [stderr] 7 | #![allow(unknown_lints, redundant_closure_call)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::redundant_closure_call` [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/dcregisters.rs:22:18 [INFO] [stderr] | [INFO] [stderr] 22 | for _ in 0 .. MAX_REGISTER + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=MAX_REGISTER` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/big_real.rs:511:13 [INFO] [stderr] | [INFO] [stderr] 511 | assert!(!(a < b)); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::neg_cmp_op_on_partial_ord)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/big_real.rs:512:13 [INFO] [stderr] | [INFO] [stderr] 512 | assert!(!(a <= b)); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: lint name `match_same_arms` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:181:17 [INFO] [stderr] | [INFO] [stderr] 181 | #[allow(match_same_arms)] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::match_same_arms` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/dcregisters.rs:22:18 [INFO] [stderr] | [INFO] [stderr] 22 | for _ in 0 .. MAX_REGISTER + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=MAX_REGISTER` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: lint name `match_same_arms` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:181:17 [INFO] [stderr] | [INFO] [stderr] 181 | #[allow(match_same_arms)] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::match_same_arms` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `match_same_arms` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:181:17 [INFO] [stderr] | [INFO] [stderr] 181 | #[allow(match_same_arms)] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::match_same_arms` [INFO] [stderr] [INFO] [stderr] warning: lint name `match_same_arms` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:181:17 [INFO] [stderr] | [INFO] [stderr] 181 | #[allow(match_same_arms)] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::match_same_arms` [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:69:21 [INFO] [stderr] | [INFO] [stderr] 69 | for (i, arg) in args.iter().map(|x| *x).enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `args.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:69:21 [INFO] [stderr] | [INFO] [stderr] 69 | for (i, arg) in args.iter().map(|x| *x).enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `args.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.95s [INFO] running `"docker" "inspect" "7deb968ccbed1bf7c6bb43bdc22b50c2f2131d24afe02f7e989349c9fa6dad07"` [INFO] running `"docker" "rm" "-f" "7deb968ccbed1bf7c6bb43bdc22b50c2f2131d24afe02f7e989349c9fa6dad07"` [INFO] [stdout] 7deb968ccbed1bf7c6bb43bdc22b50c2f2131d24afe02f7e989349c9fa6dad07