[INFO] updating cached repository wfraser/CribbagePractice-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/wfraser/CribbagePractice-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/wfraser/CribbagePractice-rust" "work/ex/clippy-test-run/sources/stable/gh/wfraser/CribbagePractice-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/wfraser/CribbagePractice-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/wfraser/CribbagePractice-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wfraser/CribbagePractice-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wfraser/CribbagePractice-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 96119ac1029b664643f7ab3da6bc411eaeb8277d [INFO] sha for GitHub repo wfraser/CribbagePractice-rust: 96119ac1029b664643f7ab3da6bc411eaeb8277d [INFO] validating manifest of wfraser/CribbagePractice-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wfraser/CribbagePractice-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wfraser/CribbagePractice-rust [INFO] finished frobbing wfraser/CribbagePractice-rust [INFO] frobbed toml for wfraser/CribbagePractice-rust written to work/ex/clippy-test-run/sources/stable/gh/wfraser/CribbagePractice-rust/Cargo.toml [INFO] started frobbing wfraser/CribbagePractice-rust [INFO] finished frobbing wfraser/CribbagePractice-rust [INFO] frobbed toml for wfraser/CribbagePractice-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wfraser/CribbagePractice-rust/Cargo.toml [INFO] crate wfraser/CribbagePractice-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wfraser/CribbagePractice-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/wfraser/CribbagePractice-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c7e5357c4c7d23b74b4bc5543cafb27a0f089b483b38718818d8d7960a0c6553 [INFO] running `"docker" "start" "-a" "c7e5357c4c7d23b74b4bc5543cafb27a0f089b483b38718818d8d7960a0c6553"` [INFO] [stderr] Checking rand v0.6.0 [INFO] [stderr] Checking cribbagepractice v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/util.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | let mut c = 1; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/util.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | let mut c = 1; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/util.rs:74:16 [INFO] [stderr] | [INFO] [stderr] 74 | assert_eq!(by_tens.get(&0).unwrap(), &vec![&1, &2, &3]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&by_tens[&0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/util.rs:75:16 [INFO] [stderr] | [INFO] [stderr] 75 | assert_eq!(by_tens.get(&1).unwrap(), &vec![&10, &11]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&by_tens[&1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/util.rs:76:16 [INFO] [stderr] | [INFO] [stderr] 76 | assert_eq!(by_tens.get(&2).unwrap(), &vec![&20]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&by_tens[&2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.19s [INFO] running `"docker" "inspect" "c7e5357c4c7d23b74b4bc5543cafb27a0f089b483b38718818d8d7960a0c6553"` [INFO] running `"docker" "rm" "-f" "c7e5357c4c7d23b74b4bc5543cafb27a0f089b483b38718818d8d7960a0c6553"` [INFO] [stdout] c7e5357c4c7d23b74b4bc5543cafb27a0f089b483b38718818d8d7960a0c6553