[INFO] updating cached repository wezm/ensure-hosts-have-env-tags [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/wezm/ensure-hosts-have-env-tags [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/wezm/ensure-hosts-have-env-tags" "work/ex/clippy-test-run/sources/stable/gh/wezm/ensure-hosts-have-env-tags"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/wezm/ensure-hosts-have-env-tags'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/wezm/ensure-hosts-have-env-tags" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wezm/ensure-hosts-have-env-tags"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wezm/ensure-hosts-have-env-tags'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b407f79cdfd3d521aca9b9ed80ab34b88aa9f870 [INFO] sha for GitHub repo wezm/ensure-hosts-have-env-tags: b407f79cdfd3d521aca9b9ed80ab34b88aa9f870 [INFO] validating manifest of wezm/ensure-hosts-have-env-tags on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wezm/ensure-hosts-have-env-tags on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wezm/ensure-hosts-have-env-tags [INFO] finished frobbing wezm/ensure-hosts-have-env-tags [INFO] frobbed toml for wezm/ensure-hosts-have-env-tags written to work/ex/clippy-test-run/sources/stable/gh/wezm/ensure-hosts-have-env-tags/Cargo.toml [INFO] started frobbing wezm/ensure-hosts-have-env-tags [INFO] finished frobbing wezm/ensure-hosts-have-env-tags [INFO] frobbed toml for wezm/ensure-hosts-have-env-tags written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wezm/ensure-hosts-have-env-tags/Cargo.toml [INFO] crate wezm/ensure-hosts-have-env-tags has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wezm/ensure-hosts-have-env-tags against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/wezm/ensure-hosts-have-env-tags:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 19b75a8e7929e932ad72dd17760f608ee750bb155fd4ea1ca79720f9a9c84583 [INFO] running `"docker" "start" "-a" "19b75a8e7929e932ad72dd17760f608ee750bb155fd4ea1ca79720f9a9c84583"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] [stderr] Compiling libc v0.2.40 [INFO] [stderr] Compiling cc v1.0.9 [INFO] [stderr] Compiling build_const v0.2.0 [INFO] [stderr] Checking itoa v0.3.4 [INFO] [stderr] Checking serde v1.0.37 [INFO] [stderr] Checking encoding_rs v0.7.2 [INFO] [stderr] Checking relay v0.1.1 [INFO] [stderr] Compiling proc-macro2 v0.3.6 [INFO] [stderr] Checking base64 v0.9.0 [INFO] [stderr] Checking futures-cpupool v0.1.8 [INFO] [stderr] Checking uuid v0.5.1 [INFO] [stderr] Compiling crc v1.7.0 [INFO] [stderr] Compiling rand v0.4.2 [INFO] [stderr] Compiling phf_shared v0.7.21 [INFO] [stderr] Checking phf v0.7.21 [INFO] [stderr] Compiling openssl-sys v0.9.28 [INFO] [stderr] Compiling backtrace-sys v0.1.16 [INFO] [stderr] Compiling quote v0.5.1 [INFO] [stderr] Checking libflate v0.1.14 [INFO] [stderr] Checking hyper v0.11.25 [INFO] [stderr] Compiling syn v0.13.1 [INFO] [stderr] Compiling rand v0.3.22 [INFO] [stderr] Compiling openssl v0.9.24 [INFO] [stderr] Compiling phf_generator v0.7.21 [INFO] [stderr] Compiling phf_codegen v0.7.21 [INFO] [stderr] Compiling mime_guess v2.0.0-alpha.4 [INFO] [stderr] Compiling serde_derive_internals v0.23.0 [INFO] [stderr] Checking native-tls v0.1.5 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking hyper-tls v0.1.3 [INFO] [stderr] Compiling serde_derive v1.0.37 [INFO] [stderr] Checking backtrace v0.3.5 [INFO] [stderr] Checking failure v0.1.1 [INFO] [stderr] Checking serde_json v1.0.13 [INFO] [stderr] Checking serde_urlencoded v0.5.1 [INFO] [stderr] Checking reqwest v0.8.5 [INFO] [stderr] Checking ensure-hosts-have-env-tags v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | ENVIRONMENTS.iter().find(|&env| hostname.contains(env)).map(|env| *env) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `ENVIRONMENTS.iter().find(|&env| hostname.contains(env)).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/main.rs:28:28 [INFO] [stderr] | [INFO] [stderr] 28 | map.entry(env).or_insert(vec![]).push(host); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| vec![])` [INFO] [stderr] --> src/main.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | ENVIRONMENTS.iter().find(|&env| hostname.contains(env)).map(|env| *env) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `ENVIRONMENTS.iter().find(|&env| hostname.contains(env)).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | / match run() { [INFO] [stderr] 39 | | Err(error) => { [INFO] [stderr] 40 | | println!("{}, {}", error.cause(), error.backtrace()); [INFO] [stderr] 41 | | std::process::exit(1); [INFO] [stderr] 42 | | } [INFO] [stderr] 43 | | Ok(_) => {} [INFO] [stderr] 44 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 38 | if let Err(error) = run() { [INFO] [stderr] 39 | println!("{}, {}", error.cause(), error.backtrace()); [INFO] [stderr] 40 | std::process::exit(1); [INFO] [stderr] 41 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/main.rs:28:28 [INFO] [stderr] | [INFO] [stderr] 28 | map.entry(env).or_insert(vec![]).push(host); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | / match run() { [INFO] [stderr] 39 | | Err(error) => { [INFO] [stderr] 40 | | println!("{}, {}", error.cause(), error.backtrace()); [INFO] [stderr] 41 | | std::process::exit(1); [INFO] [stderr] 42 | | } [INFO] [stderr] 43 | | Ok(_) => {} [INFO] [stderr] 44 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 38 | if let Err(error) = run() { [INFO] [stderr] 39 | println!("{}, {}", error.cause(), error.backtrace()); [INFO] [stderr] 40 | std::process::exit(1); [INFO] [stderr] 41 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 58.91s [INFO] running `"docker" "inspect" "19b75a8e7929e932ad72dd17760f608ee750bb155fd4ea1ca79720f9a9c84583"` [INFO] running `"docker" "rm" "-f" "19b75a8e7929e932ad72dd17760f608ee750bb155fd4ea1ca79720f9a9c84583"` [INFO] [stdout] 19b75a8e7929e932ad72dd17760f608ee750bb155fd4ea1ca79720f9a9c84583