[INFO] updating cached repository wehjin/ddnsimple
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/wehjin/ddnsimple
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/wehjin/ddnsimple" "work/ex/clippy-test-run/sources/stable/gh/wehjin/ddnsimple"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/wehjin/ddnsimple'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/wehjin/ddnsimple" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wehjin/ddnsimple"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wehjin/ddnsimple'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] cff7998fb52988303f75e287a6d6ac9049c6493e
[INFO] sha for GitHub repo wehjin/ddnsimple: cff7998fb52988303f75e287a6d6ac9049c6493e
[INFO] validating manifest of wehjin/ddnsimple on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of wehjin/ddnsimple on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing wehjin/ddnsimple
[INFO] finished frobbing wehjin/ddnsimple
[INFO] frobbed toml for wehjin/ddnsimple written to work/ex/clippy-test-run/sources/stable/gh/wehjin/ddnsimple/Cargo.toml
[INFO] started frobbing wehjin/ddnsimple
[INFO] finished frobbing wehjin/ddnsimple
[INFO] frobbed toml for wehjin/ddnsimple written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wehjin/ddnsimple/Cargo.toml
[INFO] crate wehjin/ddnsimple has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting wehjin/ddnsimple against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/wehjin/ddnsimple:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] a97403556cd72408ec230d0720f8ee532cd57a52e816b256f03fc9f5161976ba
[INFO] running `"docker" "start" "-a" "a97403556cd72408ec230d0720f8ee532cd57a52e816b256f03fc9f5161976ba"`
[INFO] [stderr]     Checking serde v1.0.35
[INFO] [stderr]    Compiling regex v0.2.10
[INFO] [stderr]     Checking atty v0.2.8
[INFO] [stderr]     Checking tokio-executor v0.1.1
[INFO] [stderr]    Compiling openssl-sys v0.9.27
[INFO] [stderr]     Checking regex-syntax v0.5.3
[INFO] [stderr]     Checking bytes v0.4.6
[INFO] [stderr]     Checking futures-cpupool v0.1.8
[INFO] [stderr]     Checking clap v2.31.2
[INFO] [stderr]     Checking libflate v0.1.14
[INFO] [stderr]     Checking chrono v0.4.0
[INFO] [stderr]     Checking tokio-threadpool v0.1.1
[INFO] [stderr]     Checking tokio-io v0.1.6
[INFO] [stderr]    Compiling openssl v0.9.24
[INFO] [stderr]     Checking tokio-reactor v0.1.1
[INFO] [stderr]     Checking tokio-udp v0.1.0
[INFO] [stderr]     Checking tokio-tcp v0.1.0
[INFO] [stderr]     Checking tokio v0.1.4
[INFO] [stderr]     Checking tokio-core v0.1.16
[INFO] [stderr]     Checking tokio-proto v0.1.1
[INFO] [stderr]     Checking native-tls v0.1.5
[INFO] [stderr]     Checking tokio-tls v0.1.4
[INFO] [stderr]     Checking hyper v0.11.24
[INFO] [stderr]     Checking serde_urlencoded v0.5.1
[INFO] [stderr]     Checking serde_json v1.0.13
[INFO] [stderr]     Checking hyper-tls v0.1.3
[INFO] [stderr]     Checking reqwest v0.8.5
[INFO] [stderr]     Checking ddnsimple v0.3.0 (/opt/crater/workdir)
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/settings.rs:58:26
[INFO] [stderr]    |
[INFO] [stderr] 58 |             let folder = env::home_dir().unwrap_or(PathBuf::from("."));
[INFO] [stderr]    |                          ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/settings.rs:58:26
[INFO] [stderr]    |
[INFO] [stderr] 58 |             let folder = env::home_dir().unwrap_or(PathBuf::from("."));
[INFO] [stderr]    |                          ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/current_ip.rs:10:19
[INFO] [stderr]    |
[INFO] [stderr] 10 |         .and_then(|text| check_ip_in_text(text))
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `check_ip_in_text`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]  --> src/current_ip.rs:9:19
[INFO] [stderr]   |
[INFO] [stderr] 9 |         .and_then(|response| read_text_from_response(response))
[INFO] [stderr]   |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `read_text_from_response`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/settings.rs:58:42
[INFO] [stderr]    |
[INFO] [stderr] 58 |             let folder = env::home_dir().unwrap_or(PathBuf::from("."));
[INFO] [stderr]    |                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| PathBuf::from("."))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/dnsimple.rs:28:67
[INFO] [stderr]    |
[INFO] [stderr] 28 |                                 value["data"]["content"].as_str().unwrap_or(text.as_str()).to_owned()
[INFO] [stderr]    |                                                                   ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| text.as_str())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/main.rs:60:9
[INFO] [stderr]    |
[INFO] [stderr] 60 | /         match self {
[INFO] [stderr] 61 | |             &Count::None => Count::None,
[INFO] [stderr] 62 | |             &Count::One => Count::None,
[INFO] [stderr] 63 | |             &Count::Infinity => Count::Infinity,
[INFO] [stderr] 64 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 60 |         match *self {
[INFO] [stderr] 61 |             Count::None => Count::None,
[INFO] [stderr] 62 |             Count::One => Count::None,
[INFO] [stderr] 63 |             Count::Infinity => Count::Infinity,
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/main.rs:126:18
[INFO] [stderr]     |
[INFO] [stderr] 126 |             .map(|response| Outcome::Completed(response))
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Outcome::Completed`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/current_ip.rs:10:19
[INFO] [stderr]    |
[INFO] [stderr] 10 |         .and_then(|text| check_ip_in_text(text))
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `check_ip_in_text`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]  --> src/current_ip.rs:9:19
[INFO] [stderr]   |
[INFO] [stderr] 9 |         .and_then(|response| read_text_from_response(response))
[INFO] [stderr]   |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `read_text_from_response`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/settings.rs:58:42
[INFO] [stderr]    |
[INFO] [stderr] 58 |             let folder = env::home_dir().unwrap_or(PathBuf::from("."));
[INFO] [stderr]    |                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| PathBuf::from("."))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/dnsimple.rs:28:67
[INFO] [stderr]    |
[INFO] [stderr] 28 |                                 value["data"]["content"].as_str().unwrap_or(text.as_str()).to_owned()
[INFO] [stderr]    |                                                                   ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| text.as_str())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/main.rs:60:9
[INFO] [stderr]    |
[INFO] [stderr] 60 | /         match self {
[INFO] [stderr] 61 | |             &Count::None => Count::None,
[INFO] [stderr] 62 | |             &Count::One => Count::None,
[INFO] [stderr] 63 | |             &Count::Infinity => Count::Infinity,
[INFO] [stderr] 64 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 60 |         match *self {
[INFO] [stderr] 61 |             Count::None => Count::None,
[INFO] [stderr] 62 |             Count::One => Count::None,
[INFO] [stderr] 63 |             Count::Infinity => Count::Infinity,
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/main.rs:126:18
[INFO] [stderr]     |
[INFO] [stderr] 126 |             .map(|response| Outcome::Completed(response))
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Outcome::Completed`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 49.70s
[INFO] running `"docker" "inspect" "a97403556cd72408ec230d0720f8ee532cd57a52e816b256f03fc9f5161976ba"`
[INFO] running `"docker" "rm" "-f" "a97403556cd72408ec230d0720f8ee532cd57a52e816b256f03fc9f5161976ba"`
[INFO] [stdout] a97403556cd72408ec230d0720f8ee532cd57a52e816b256f03fc9f5161976ba