[INFO] updating cached repository wehjin/bittrex_dl [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/wehjin/bittrex_dl [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/wehjin/bittrex_dl" "work/ex/clippy-test-run/sources/stable/gh/wehjin/bittrex_dl"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/wehjin/bittrex_dl'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/wehjin/bittrex_dl" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wehjin/bittrex_dl"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wehjin/bittrex_dl'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] cb142b2f0635e68315f689682e512b8fd0333e67 [INFO] sha for GitHub repo wehjin/bittrex_dl: cb142b2f0635e68315f689682e512b8fd0333e67 [INFO] validating manifest of wehjin/bittrex_dl on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wehjin/bittrex_dl on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wehjin/bittrex_dl [INFO] finished frobbing wehjin/bittrex_dl [INFO] frobbed toml for wehjin/bittrex_dl written to work/ex/clippy-test-run/sources/stable/gh/wehjin/bittrex_dl/Cargo.toml [INFO] started frobbing wehjin/bittrex_dl [INFO] finished frobbing wehjin/bittrex_dl [INFO] frobbed toml for wehjin/bittrex_dl written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wehjin/bittrex_dl/Cargo.toml [INFO] crate wehjin/bittrex_dl has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wehjin/bittrex_dl against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/wehjin/bittrex_dl:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7c636d50b25f3fb63277e22fa5f9da93a78bb1a9483f1fd4cd710320a8396124 [INFO] running `"docker" "start" "-a" "7c636d50b25f3fb63277e22fa5f9da93a78bb1a9483f1fd4cd710320a8396124"` [INFO] [stderr] Compiling cc v1.0.4 [INFO] [stderr] Checking libc v0.2.36 [INFO] [stderr] Checking num-traits v0.2.0 [INFO] [stderr] Checking json v0.11.13 [INFO] [stderr] Checking generic-array v0.9.0 [INFO] [stderr] Checking serde_urlencoded v0.5.1 [INFO] [stderr] Checking crypto-mac v0.5.2 [INFO] [stderr] Checking digest v0.7.2 [INFO] [stderr] Checking sha2 v0.7.0 [INFO] [stderr] Checking hmac v0.5.0 [INFO] [stderr] Checking iovec v0.1.2 [INFO] [stderr] Checking net2 v0.2.31 [INFO] [stderr] Checking rand v0.4.2 [INFO] [stderr] Checking num_cpus v1.8.0 [INFO] [stderr] Checking time v0.1.39 [INFO] [stderr] Checking num-integer v0.1.36 [INFO] [stderr] Checking num-traits v0.1.43 [INFO] [stderr] Checking bytes v0.4.6 [INFO] [stderr] Compiling openssl-sys v0.9.26 [INFO] [stderr] Checking futures-cpupool v0.1.8 [INFO] [stderr] Checking mio v0.6.13 [INFO] [stderr] Checking serde_json v1.0.9 [INFO] [stderr] Checking num-iter v0.1.35 [INFO] [stderr] Checking rand v0.3.22 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Checking uuid v0.5.1 [INFO] [stderr] Checking tokio-io v0.1.5 [INFO] [stderr] Checking chrono v0.4.0 [INFO] [stderr] Compiling openssl v0.9.24 [INFO] [stderr] Compiling phf_generator v0.7.21 [INFO] [stderr] Checking tokio-core v0.1.12 [INFO] [stderr] Compiling phf_codegen v0.7.21 [INFO] [stderr] Compiling mime_guess v2.0.0-alpha.4 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking native-tls v0.1.5 [INFO] [stderr] Checking hyper v0.11.19 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking hyper-tls v0.1.2 [INFO] [stderr] Checking reqwest v0.8.5 [INFO] [stderr] Checking bittrex_dl v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/setup.rs:42:29 [INFO] [stderr] | [INFO] [stderr] 42 | if let Some(path_buf) = std::env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/setup.rs:42:29 [INFO] [stderr] | [INFO] [stderr] 42 | if let Some(path_buf) = std::env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/api.rs:6:15 [INFO] [stderr] | [INFO] [stderr] 6 | let uri = match report_type { [INFO] [stderr] | _______________^ [INFO] [stderr] 7 | | &ReportType::Deposits => DEPOSITS_URI_STRING, [INFO] [stderr] 8 | | &ReportType::Withdrawals => WITHDRAWALS_URI_STRING, [INFO] [stderr] 9 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 6 | let uri = match *report_type { [INFO] [stderr] 7 | ReportType::Deposits => DEPOSITS_URI_STRING, [INFO] [stderr] 8 | ReportType::Withdrawals => WITHDRAWALS_URI_STRING, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/convert.rs:11:36 [INFO] [stderr] | [INFO] [stderr] 11 | fn json_values_to_csv(json_values: &Vec, report_type: &ReportType) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[JsonValue]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/convert.rs:12:23 [INFO] [stderr] | [INFO] [stderr] 12 | let field_names = match report_type { [INFO] [stderr] | _______________________^ [INFO] [stderr] 13 | | &ReportType::Deposits => vec!["Id", "Amount", "Currency", "Confirmations", "LastUpdated", "TxId", "CryptoAddress"], [INFO] [stderr] 14 | | &ReportType::Withdrawals => vec!["PaymentUuid", "Currency", "Amount", "Address", "Opened", "Authorized", "PendingPayment", "TxCost", "TxId", "Canceled", "InvalidAddress"], [INFO] [stderr] 15 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/api.rs:6:15 [INFO] [stderr] | [INFO] [stderr] 6 | let uri = match report_type { [INFO] [stderr] | _______________^ [INFO] [stderr] 7 | | &ReportType::Deposits => DEPOSITS_URI_STRING, [INFO] [stderr] 8 | | &ReportType::Withdrawals => WITHDRAWALS_URI_STRING, [INFO] [stderr] 9 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 12 | let field_names = match *report_type { [INFO] [stderr] 13 | ReportType::Deposits => vec!["Id", "Amount", "Currency", "Confirmations", "LastUpdated", "TxId", "CryptoAddress"], [INFO] [stderr] 14 | ReportType::Withdrawals => vec!["PaymentUuid", "Currency", "Amount", "Address", "Opened", "Authorized", "PendingPayment", "TxCost", "TxId", "Canceled", "InvalidAddress"], [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/convert.rs:26:63 [INFO] [stderr] | [INFO] [stderr] 26 | fn json_value_to_csv_row(json_value: &JsonValue, field_names: &Vec<&str>) -> Result { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/convert.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | / match json_value { [INFO] [stderr] 35 | | &JsonValue::String(ref string) => Ok(string.to_owned()), [INFO] [stderr] 36 | | &JsonValue::Short(ref short) => Ok(short.as_str().to_owned()), [INFO] [stderr] 37 | | &JsonValue::Number(ref number) => Ok(number.to_string()), [INFO] [stderr] 38 | | &JsonValue::Boolean(ref boolean) => Ok(boolean.to_string()), [INFO] [stderr] 39 | | _ => Err(AppError::InvalidJsonField(json_value.dump())), [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 6 | let uri = match *report_type { [INFO] [stderr] 7 | ReportType::Deposits => DEPOSITS_URI_STRING, [INFO] [stderr] 8 | ReportType::Withdrawals => WITHDRAWALS_URI_STRING, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 34 | match *json_value { [INFO] [stderr] 35 | JsonValue::String(ref string) => Ok(string.to_owned()), [INFO] [stderr] 36 | JsonValue::Short(ref short) => Ok(short.as_str().to_owned()), [INFO] [stderr] 37 | JsonValue::Number(ref number) => Ok(number.to_string()), [INFO] [stderr] 38 | JsonValue::Boolean(ref boolean) => Ok(boolean.to_string()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/convert.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | / if let &JsonValue::Array(ref results) = &result_holder["result"] { [INFO] [stderr] 45 | | Ok(results.to_owned()) [INFO] [stderr] 46 | | } else { [INFO] [stderr] 47 | | Err(AppError::NoResultInJsonRoot(result_holder.dump())) [INFO] [stderr] 48 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 44 | if let JsonValue::Array(ref results) = result_holder["result"] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/convert.rs:11:36 [INFO] [stderr] | [INFO] [stderr] 11 | fn json_values_to_csv(json_values: &Vec, report_type: &ReportType) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[JsonValue]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/convert.rs:12:23 [INFO] [stderr] | [INFO] [stderr] 12 | let field_names = match report_type { [INFO] [stderr] | _______________________^ [INFO] [stderr] 13 | | &ReportType::Deposits => vec!["Id", "Amount", "Currency", "Confirmations", "LastUpdated", "TxId", "CryptoAddress"], [INFO] [stderr] 14 | | &ReportType::Withdrawals => vec!["PaymentUuid", "Currency", "Amount", "Address", "Opened", "Authorized", "PendingPayment", "TxCost", "TxId", "Canceled", "InvalidAddress"], [INFO] [stderr] 15 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 12 | let field_names = match *report_type { [INFO] [stderr] 13 | ReportType::Deposits => vec!["Id", "Amount", "Currency", "Confirmations", "LastUpdated", "TxId", "CryptoAddress"], [INFO] [stderr] 14 | ReportType::Withdrawals => vec!["PaymentUuid", "Currency", "Amount", "Address", "Opened", "Authorized", "PendingPayment", "TxCost", "TxId", "Canceled", "InvalidAddress"], [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/convert.rs:26:63 [INFO] [stderr] | [INFO] [stderr] 26 | fn json_value_to_csv_row(json_value: &JsonValue, field_names: &Vec<&str>) -> Result { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/convert.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | / match json_value { [INFO] [stderr] 35 | | &JsonValue::String(ref string) => Ok(string.to_owned()), [INFO] [stderr] 36 | | &JsonValue::Short(ref short) => Ok(short.as_str().to_owned()), [INFO] [stderr] 37 | | &JsonValue::Number(ref number) => Ok(number.to_string()), [INFO] [stderr] 38 | | &JsonValue::Boolean(ref boolean) => Ok(boolean.to_string()), [INFO] [stderr] 39 | | _ => Err(AppError::InvalidJsonField(json_value.dump())), [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 34 | match *json_value { [INFO] [stderr] 35 | JsonValue::String(ref string) => Ok(string.to_owned()), [INFO] [stderr] 36 | JsonValue::Short(ref short) => Ok(short.as_str().to_owned()), [INFO] [stderr] 37 | JsonValue::Number(ref number) => Ok(number.to_string()), [INFO] [stderr] 38 | JsonValue::Boolean(ref boolean) => Ok(boolean.to_string()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/convert.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | / if let &JsonValue::Array(ref results) = &result_holder["result"] { [INFO] [stderr] 45 | | Ok(results.to_owned()) [INFO] [stderr] 46 | | } else { [INFO] [stderr] 47 | | Err(AppError::NoResultInJsonRoot(result_holder.dump())) [INFO] [stderr] 48 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 44 | if let JsonValue::Array(ref results) = result_holder["result"] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 44.92s [INFO] running `"docker" "inspect" "7c636d50b25f3fb63277e22fa5f9da93a78bb1a9483f1fd4cd710320a8396124"` [INFO] running `"docker" "rm" "-f" "7c636d50b25f3fb63277e22fa5f9da93a78bb1a9483f1fd4cd710320a8396124"` [INFO] [stdout] 7c636d50b25f3fb63277e22fa5f9da93a78bb1a9483f1fd4cd710320a8396124