[INFO] updating cached repository wecohere/loom [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/wecohere/loom [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/wecohere/loom" "work/ex/clippy-test-run/sources/stable/gh/wecohere/loom"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/wecohere/loom'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/wecohere/loom" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wecohere/loom"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wecohere/loom'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ac6bbf01272cb7b7ff9fa1a41a4e9d21dc1fd099 [INFO] sha for GitHub repo wecohere/loom: ac6bbf01272cb7b7ff9fa1a41a4e9d21dc1fd099 [INFO] validating manifest of wecohere/loom on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wecohere/loom on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wecohere/loom [INFO] finished frobbing wecohere/loom [INFO] frobbed toml for wecohere/loom written to work/ex/clippy-test-run/sources/stable/gh/wecohere/loom/Cargo.toml [INFO] started frobbing wecohere/loom [INFO] finished frobbing wecohere/loom [INFO] frobbed toml for wecohere/loom written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wecohere/loom/Cargo.toml [INFO] crate wecohere/loom has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wecohere/loom against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/wecohere/loom:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 488ed5c2e6e191d634769871a1799b17b7690ac1eb4c3ae4afff8c159415399a [INFO] running `"docker" "start" "-a" "488ed5c2e6e191d634769871a1799b17b7690ac1eb4c3ae4afff8c159415399a"` [INFO] [stderr] Checking futures v0.1.17 [INFO] [stderr] Checking toml v0.4.5 [INFO] [stderr] Checking mio-uds v0.6.4 [INFO] [stderr] Checking tokio-io v0.1.4 [INFO] [stderr] Checking tokio-core v0.1.12 [INFO] [stderr] Checking tokio-signal v0.1.3 [INFO] [stderr] Checking tokio-process v0.1.5 [INFO] [stderr] Checking loom v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/runner/child_with_streams.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/runner/child_with_streams.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: field is never used: `name` [INFO] [stderr] --> src/runner/child_with_streams.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | name: &'a str, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/runner/child_with_streams.rs:15:28 [INFO] [stderr] | [INFO] [stderr] 15 | stdout_as_named_lines: Option, Lines>>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/runner/child_with_streams.rs:43:48 [INFO] [stderr] | [INFO] [stderr] 43 | pub fn stdout_as_named_lines(&mut self) -> &mut Option, Lines>>>> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: field is never used: `name` [INFO] [stderr] --> src/runner/child_with_streams.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | name: &'a str, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/runner/child_with_streams.rs:15:28 [INFO] [stderr] | [INFO] [stderr] 15 | stdout_as_named_lines: Option, Lines>>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/runner/child_with_streams.rs:43:48 [INFO] [stderr] | [INFO] [stderr] 43 | pub fn stdout_as_named_lines(&mut self) -> &mut Option, Lines>>>> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/bin/loom.rs:16:12 [INFO] [stderr] | [INFO] [stderr] 16 | writeln!(io::stderr(), "error: {:?}", err).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/bin/loom.rs:16:12 [INFO] [stderr] | [INFO] [stderr] 16 | writeln!(io::stderr(), "error: {:?}", err).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.69s [INFO] running `"docker" "inspect" "488ed5c2e6e191d634769871a1799b17b7690ac1eb4c3ae4afff8c159415399a"` [INFO] running `"docker" "rm" "-f" "488ed5c2e6e191d634769871a1799b17b7690ac1eb4c3ae4afff8c159415399a"` [INFO] [stdout] 488ed5c2e6e191d634769871a1799b17b7690ac1eb4c3ae4afff8c159415399a