[INFO] updating cached repository weclaw1/deterministic_finite_automaton [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/weclaw1/deterministic_finite_automaton [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/weclaw1/deterministic_finite_automaton" "work/ex/clippy-test-run/sources/stable/gh/weclaw1/deterministic_finite_automaton"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/weclaw1/deterministic_finite_automaton'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/weclaw1/deterministic_finite_automaton" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/weclaw1/deterministic_finite_automaton"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/weclaw1/deterministic_finite_automaton'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c351231cfe892df1b44c004af330eb676056e581 [INFO] sha for GitHub repo weclaw1/deterministic_finite_automaton: c351231cfe892df1b44c004af330eb676056e581 [INFO] validating manifest of weclaw1/deterministic_finite_automaton on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of weclaw1/deterministic_finite_automaton on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing weclaw1/deterministic_finite_automaton [INFO] finished frobbing weclaw1/deterministic_finite_automaton [INFO] frobbed toml for weclaw1/deterministic_finite_automaton written to work/ex/clippy-test-run/sources/stable/gh/weclaw1/deterministic_finite_automaton/Cargo.toml [INFO] started frobbing weclaw1/deterministic_finite_automaton [INFO] finished frobbing weclaw1/deterministic_finite_automaton [INFO] frobbed toml for weclaw1/deterministic_finite_automaton written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/weclaw1/deterministic_finite_automaton/Cargo.toml [INFO] crate weclaw1/deterministic_finite_automaton has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting weclaw1/deterministic_finite_automaton against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/weclaw1/deterministic_finite_automaton:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7cbb70cbccdb1e11b78f8ab8d14fbda480ec2448394f25a298206babebf20d92 [INFO] running `"docker" "start" "-a" "7cbb70cbccdb1e11b78f8ab8d14fbda480ec2448394f25a298206babebf20d92"` [INFO] [stderr] Checking serde v1.0.16 [INFO] [stderr] Checking either v1.3.0 [INFO] [stderr] Compiling serde_derive_internals v0.16.0 [INFO] [stderr] Checking itertools v0.7.1 [INFO] [stderr] Compiling serde_derive v1.0.16 [INFO] [stderr] Checking serde_json v1.0.4 [INFO] [stderr] Checking deterministic_finite_automaton v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | return current_state.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `current_state.clone()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | return current_state.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `current_state.clone()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lib.rs:56:12 [INFO] [stderr] | [INFO] [stderr] 56 | if !(self.state_transitions.len() == self.alphabet.len() * self.states.len()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.state_transitions.len() != self.alphabet.len() * self.states.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lib.rs:56:12 [INFO] [stderr] | [INFO] [stderr] 56 | if !(self.state_transitions.len() == self.alphabet.len() * self.states.len()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.state_transitions.len() != self.alphabet.len() * self.states.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / match dfa.correct() { [INFO] [stderr] 24 | | true => { [INFO] [stderr] 25 | | let result = dfa.run("abab"); [INFO] [stderr] 26 | | println!("{:?}", result); [INFO] [stderr] ... | [INFO] [stderr] 33 | | false => println!("DFA is not correct"), [INFO] [stderr] 34 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 23 | if dfa.correct() { [INFO] [stderr] 24 | let result = dfa.run("abab"); [INFO] [stderr] 25 | println!("{:?}", result); [INFO] [stderr] 26 | if dfa.state_accepted(&result) { [INFO] [stderr] 27 | println!("State is accepted!"); [INFO] [stderr] 28 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / match dfa.correct() { [INFO] [stderr] 24 | | true => { [INFO] [stderr] 25 | | let result = dfa.run("abab"); [INFO] [stderr] 26 | | println!("{:?}", result); [INFO] [stderr] ... | [INFO] [stderr] 33 | | false => println!("DFA is not correct"), [INFO] [stderr] 34 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 23 | if dfa.correct() { [INFO] [stderr] 24 | let result = dfa.run("abab"); [INFO] [stderr] 25 | println!("{:?}", result); [INFO] [stderr] 26 | if dfa.state_accepted(&result) { [INFO] [stderr] 27 | println!("State is accepted!"); [INFO] [stderr] 28 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 21.00s [INFO] running `"docker" "inspect" "7cbb70cbccdb1e11b78f8ab8d14fbda480ec2448394f25a298206babebf20d92"` [INFO] running `"docker" "rm" "-f" "7cbb70cbccdb1e11b78f8ab8d14fbda480ec2448394f25a298206babebf20d92"` [INFO] [stdout] 7cbb70cbccdb1e11b78f8ab8d14fbda480ec2448394f25a298206babebf20d92