[INFO] updating cached repository webbrandon/mc [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/webbrandon/mc [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/webbrandon/mc" "work/ex/clippy-test-run/sources/stable/gh/webbrandon/mc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/webbrandon/mc'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/webbrandon/mc" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/webbrandon/mc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/webbrandon/mc'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 91ab7d331bd8248ec7180d071a0db59891f591dc [INFO] sha for GitHub repo webbrandon/mc: 91ab7d331bd8248ec7180d071a0db59891f591dc [INFO] validating manifest of webbrandon/mc on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of webbrandon/mc on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing webbrandon/mc [INFO] finished frobbing webbrandon/mc [INFO] frobbed toml for webbrandon/mc written to work/ex/clippy-test-run/sources/stable/gh/webbrandon/mc/Cargo.toml [INFO] started frobbing webbrandon/mc [INFO] finished frobbing webbrandon/mc [INFO] frobbed toml for webbrandon/mc written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/webbrandon/mc/Cargo.toml [INFO] crate webbrandon/mc has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting webbrandon/mc against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/webbrandon/mc:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6ca729c359ec73c43fa3012c1b02c3c28f01c605159742d45342957d4ae24d3e [INFO] running `"docker" "start" "-a" "6ca729c359ec73c43fa3012c1b02c3c28f01c605159742d45342957d4ae24d3e"` [INFO] [stderr] Compiling libc v0.2.45 [INFO] [stderr] Compiling ucd-trie v0.1.1 [INFO] [stderr] Compiling ryu v0.2.7 [INFO] [stderr] Compiling serde v1.0.82 [INFO] [stderr] Compiling maplit v1.0.1 [INFO] [stderr] Compiling unicode-width v0.1.5 [INFO] [stderr] Compiling bitflags v1.0.4 [INFO] [stderr] Checking ucd-util v0.1.3 [INFO] [stderr] Compiling ansi_term v0.11.0 [INFO] [stderr] Compiling vec_map v0.8.1 [INFO] [stderr] Compiling strsim v0.7.0 [INFO] [stderr] Compiling regex v1.1.0 [INFO] [stderr] Checking same-file v1.0.4 [INFO] [stderr] Checking utf8-ranges v1.0.2 [INFO] [stderr] Compiling memchr v2.1.2 [INFO] [stderr] Checking log v0.4.6 [INFO] [stderr] Compiling textwrap v0.10.0 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_xorshift v0.1.0 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking regex-syntax v0.6.4 [INFO] [stderr] Compiling pest v2.0.2 [INFO] [stderr] Checking walkdir v2.2.7 [INFO] [stderr] Compiling rand_chacha v0.1.0 [INFO] [stderr] Compiling rand_pcg v0.1.1 [INFO] [stderr] Compiling rand v0.6.1 [INFO] [stderr] Compiling syn v0.14.9 [INFO] [stderr] Checking atty v0.2.11 [INFO] [stderr] Checking users v0.8.1 [INFO] [stderr] Checking clap v2.32.0 [INFO] [stderr] Checking aho-corasick v0.6.9 [INFO] [stderr] Compiling pest_meta v2.0.3 [INFO] [stderr] Checking run_script v0.2.3 [INFO] [stderr] Compiling pest_generator v2.0.0 [INFO] [stderr] Compiling pest_derive v2.0.1 [INFO] [stderr] Checking serde_json v1.0.33 [INFO] [stderr] Compiling mc v0.2.1 (/opt/crater/workdir) [INFO] [stderr] Checking handlebars v1.2.0 [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/file/error/mod.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | r#"Format of files is not accepted."# [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/file/error/mod.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | r#"Format of files is not accepted."# [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/handler/configs/mod.rs:31:38 [INFO] [stderr] | [INFO] [stderr] 31 | if param_location == "Url".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `"Url"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/handler/configs/mod.rs:40:45 [INFO] [stderr] | [INFO] [stderr] 40 | } else if param_location == "File".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `"File"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/handler/scripts/mod.rs:6:27 [INFO] [stderr] | [INFO] [stderr] 6 | pub fn run_script(script: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/file/input/mod.rs:14:25 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn parse_json(text: &String) -> Json { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/file/output/mod.rs:4:26 [INFO] [stderr] | [INFO] [stderr] 4 | pub fn outfile(filepath: &String, text: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/file/output/mod.rs:4:41 [INFO] [stderr] | [INFO] [stderr] 4 | pub fn outfile(filepath: &String, text: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/file/output/mod.rs:10:23 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn out_term(text: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/handler/configs/mod.rs:31:38 [INFO] [stderr] | [INFO] [stderr] 31 | if param_location == "Url".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `"Url"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/handler/configs/mod.rs:40:45 [INFO] [stderr] | [INFO] [stderr] 40 | } else if param_location == "File".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `"File"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/handler/scripts/mod.rs:6:27 [INFO] [stderr] | [INFO] [stderr] 6 | pub fn run_script(script: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/file/input/mod.rs:14:25 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn parse_json(text: &String) -> Json { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/file/output/mod.rs:4:26 [INFO] [stderr] | [INFO] [stderr] 4 | pub fn outfile(filepath: &String, text: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/file/output/mod.rs:4:41 [INFO] [stderr] | [INFO] [stderr] 4 | pub fn outfile(filepath: &String, text: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/file/output/mod.rs:10:23 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn out_term(text: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 17s [INFO] running `"docker" "inspect" "6ca729c359ec73c43fa3012c1b02c3c28f01c605159742d45342957d4ae24d3e"` [INFO] running `"docker" "rm" "-f" "6ca729c359ec73c43fa3012c1b02c3c28f01c605159742d45342957d4ae24d3e"` [INFO] [stdout] 6ca729c359ec73c43fa3012c1b02c3c28f01c605159742d45342957d4ae24d3e