[INFO] updating cached repository weaming/rtree [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/weaming/rtree [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/weaming/rtree" "work/ex/clippy-test-run/sources/stable/gh/weaming/rtree"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/weaming/rtree'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/weaming/rtree" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/weaming/rtree"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/weaming/rtree'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 34ce11a440ce0e842b16f4c51cf8c484edb065e2 [INFO] sha for GitHub repo weaming/rtree: 34ce11a440ce0e842b16f4c51cf8c484edb065e2 [INFO] validating manifest of weaming/rtree on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of weaming/rtree on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing weaming/rtree [INFO] finished frobbing weaming/rtree [INFO] frobbed toml for weaming/rtree written to work/ex/clippy-test-run/sources/stable/gh/weaming/rtree/Cargo.toml [INFO] started frobbing weaming/rtree [INFO] finished frobbing weaming/rtree [INFO] frobbed toml for weaming/rtree written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/weaming/rtree/Cargo.toml [INFO] crate weaming/rtree has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting weaming/rtree against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/weaming/rtree:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 61d71495e4d05e72d5cd7d8a81024b0652839e4ea3570b5297e353188c0eb87e [INFO] running `"docker" "start" "-a" "61d71495e4d05e72d5cd7d8a81024b0652839e4ea3570b5297e353188c0eb87e"` [INFO] [stderr] Checking clap v2.32.0 [INFO] [stderr] Checking rtree v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/filetree/fs.rs:3:21 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn is_dir(path: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/filetree/fs.rs:8:22 [INFO] [stderr] | [INFO] [stderr] 8 | pub fn is_file(path: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/filetree/fs.rs:13:25 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn exist_path(path: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/filetree/node.rs:32:32 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn new_file_node(path_str: &String, root: &String) -> Option> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/filetree/node.rs:32:47 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn new_file_node(path_str: &String, root: &String) -> Option> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/filetree/node.rs:52:14 [INFO] [stderr] | [INFO] [stderr] 52 | .unwrap_or(OsStr::new("")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| OsStr::new(""))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/filetree/node.rs:59:14 [INFO] [stderr] | [INFO] [stderr] 59 | .unwrap_or(Path::new("")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| Path::new(""))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/filetree/node.rs:93:21 [INFO] [stderr] | [INFO] [stderr] 93 | / match new_file_node(&abs_path, root) { [INFO] [stderr] 94 | | Some(child_node) => { [INFO] [stderr] 95 | | let child_node_arc = Arc::new(child_node); [INFO] [stderr] 96 | | [INFO] [stderr] ... | [INFO] [stderr] 118 | | None => {} [INFO] [stderr] 119 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 93 | if let Some(child_node) = new_file_node(&abs_path, root) { [INFO] [stderr] 94 | let child_node_arc = Arc::new(child_node); [INFO] [stderr] 95 | [INFO] [stderr] 96 | if is_dir(&abs_path) { [INFO] [stderr] 97 | rv_rc [INFO] [stderr] 98 | .children [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/filetree/fs.rs:3:21 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn is_dir(path: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/filetree/fs.rs:8:22 [INFO] [stderr] | [INFO] [stderr] 8 | pub fn is_file(path: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/filetree/fs.rs:13:25 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn exist_path(path: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/filetree/node.rs:32:32 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn new_file_node(path_str: &String, root: &String) -> Option> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/filetree/node.rs:32:47 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn new_file_node(path_str: &String, root: &String) -> Option> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you should use the `starts_with` method [INFO] [stderr] --> src/filetree/print.rs:42:16 [INFO] [stderr] | [INFO] [stderr] 42 | if x.name.chars().next().unwrap() == '.' { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `x.name.starts_with('.')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::chars_next_cmp)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_next_cmp [INFO] [stderr] [INFO] [stderr] warning: you should use the `starts_with` method [INFO] [stderr] --> src/filetree/print.rs:80:16 [INFO] [stderr] | [INFO] [stderr] 80 | if x.name.chars().next().unwrap() == '.' { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `x.name.starts_with('.')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_next_cmp [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/filetree/size.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / let mut unit = "B"; [INFO] [stderr] 16 | | if s > factor { [INFO] [stderr] 17 | | s /= factor; [INFO] [stderr] 18 | | unit = "KB"; [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let unit = if s > factor { ..; "KB" } else { "B" };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/filetree/node.rs:52:14 [INFO] [stderr] | [INFO] [stderr] 52 | .unwrap_or(OsStr::new("")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| OsStr::new(""))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/filetree/node.rs:59:14 [INFO] [stderr] | [INFO] [stderr] 59 | .unwrap_or(Path::new("")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| Path::new(""))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/filetree/node.rs:93:21 [INFO] [stderr] | [INFO] [stderr] 93 | / match new_file_node(&abs_path, root) { [INFO] [stderr] 94 | | Some(child_node) => { [INFO] [stderr] 95 | | let child_node_arc = Arc::new(child_node); [INFO] [stderr] 96 | | [INFO] [stderr] ... | [INFO] [stderr] 118 | | None => {} [INFO] [stderr] 119 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 93 | if let Some(child_node) = new_file_node(&abs_path, root) { [INFO] [stderr] 94 | let child_node_arc = Arc::new(child_node); [INFO] [stderr] 95 | [INFO] [stderr] 96 | if is_dir(&abs_path) { [INFO] [stderr] 97 | rv_rc [INFO] [stderr] 98 | .children [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you should use the `starts_with` method [INFO] [stderr] --> src/filetree/print.rs:42:16 [INFO] [stderr] | [INFO] [stderr] 42 | if x.name.chars().next().unwrap() == '.' { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `x.name.starts_with('.')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::chars_next_cmp)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_next_cmp [INFO] [stderr] [INFO] [stderr] warning: you should use the `starts_with` method [INFO] [stderr] --> src/filetree/print.rs:80:16 [INFO] [stderr] | [INFO] [stderr] 80 | if x.name.chars().next().unwrap() == '.' { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `x.name.starts_with('.')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_next_cmp [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/filetree/size.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / let mut unit = "B"; [INFO] [stderr] 16 | | if s > factor { [INFO] [stderr] 17 | | s /= factor; [INFO] [stderr] 18 | | unit = "KB"; [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let unit = if s > factor { ..; "KB" } else { "B" };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | / match env::var("DEBUG") { [INFO] [stderr] 44 | | Ok(_) => { [INFO] [stderr] 45 | | println!("path {}", path); [INFO] [stderr] 46 | | println!("root {}", root); [INFO] [stderr] ... | [INFO] [stderr] 49 | | Err(_) => {} [INFO] [stderr] 50 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 43 | if let Ok(_) = env::var("DEBUG") { [INFO] [stderr] 44 | println!("path {}", path); [INFO] [stderr] 45 | println!("root {}", root); [INFO] [stderr] 46 | println!("human {}", human); [INFO] [stderr] 47 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | / match indent { [INFO] [stderr] 52 | | true => print::print_file_node_simplely(&root_node, 1, level, human), [INFO] [stderr] 53 | | false => print::print_file_node_tree(&root_node, &mut vec![], 1, level, human), [INFO] [stderr] 54 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if indent { print::print_file_node_simplely(&root_node, 1, level, human) } else { print::print_file_node_tree(&root_node, &mut vec![], 1, level, human) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | / match env::var("DEBUG") { [INFO] [stderr] 44 | | Ok(_) => { [INFO] [stderr] 45 | | println!("path {}", path); [INFO] [stderr] 46 | | println!("root {}", root); [INFO] [stderr] ... | [INFO] [stderr] 49 | | Err(_) => {} [INFO] [stderr] 50 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 43 | if let Ok(_) = env::var("DEBUG") { [INFO] [stderr] 44 | println!("path {}", path); [INFO] [stderr] 45 | println!("root {}", root); [INFO] [stderr] 46 | println!("human {}", human); [INFO] [stderr] 47 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | / match indent { [INFO] [stderr] 52 | | true => print::print_file_node_simplely(&root_node, 1, level, human), [INFO] [stderr] 53 | | false => print::print_file_node_tree(&root_node, &mut vec![], 1, level, human), [INFO] [stderr] 54 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if indent { print::print_file_node_simplely(&root_node, 1, level, human) } else { print::print_file_node_tree(&root_node, &mut vec![], 1, level, human) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.69s [INFO] running `"docker" "inspect" "61d71495e4d05e72d5cd7d8a81024b0652839e4ea3570b5297e353188c0eb87e"` [INFO] running `"docker" "rm" "-f" "61d71495e4d05e72d5cd7d8a81024b0652839e4ea3570b5297e353188c0eb87e"` [INFO] [stdout] 61d71495e4d05e72d5cd7d8a81024b0652839e4ea3570b5297e353188c0eb87e