[INFO] updating cached repository wdv4758h/rimger [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/wdv4758h/rimger [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/wdv4758h/rimger" "work/ex/clippy-test-run/sources/stable/gh/wdv4758h/rimger"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/wdv4758h/rimger'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/wdv4758h/rimger" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wdv4758h/rimger"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wdv4758h/rimger'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0fbd554ecd06e600b0ad9fde10956d7b1821604c [INFO] sha for GitHub repo wdv4758h/rimger: 0fbd554ecd06e600b0ad9fde10956d7b1821604c [INFO] validating manifest of wdv4758h/rimger on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wdv4758h/rimger on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wdv4758h/rimger [INFO] finished frobbing wdv4758h/rimger [INFO] frobbed toml for wdv4758h/rimger written to work/ex/clippy-test-run/sources/stable/gh/wdv4758h/rimger/Cargo.toml [INFO] started frobbing wdv4758h/rimger [INFO] finished frobbing wdv4758h/rimger [INFO] frobbed toml for wdv4758h/rimger written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wdv4758h/rimger/Cargo.toml [INFO] crate wdv4758h/rimger has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wdv4758h/rimger against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/wdv4758h/rimger:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 43992e225e8c9961a7015ba4d08160a4d9f3758e69fb46dea383858c04d7b39b [INFO] running `"docker" "start" "-a" "43992e225e8c9961a7015ba4d08160a4d9f3758e69fb46dea383858c04d7b39b"` [INFO] [stderr] Checking lazy_static v0.2.10 [INFO] [stderr] Compiling bitflags v1.0.1 [INFO] [stderr] Compiling khronos_api v2.0.0 [INFO] [stderr] Checking byteorder v0.4.2 [INFO] [stderr] Checking fixedbitset v0.1.8 [INFO] [stderr] Checking linked-hash-map v0.5.0 [INFO] [stderr] Checking serde v1.0.21 [INFO] [stderr] Compiling rand v0.3.18 [INFO] [stderr] Checking atty v0.2.3 [INFO] [stderr] Checking num-complex v0.1.40 [INFO] [stderr] Checking arrayvec v0.4.6 [INFO] [stderr] Checking deflate v0.7.17 [INFO] [stderr] Checking shared_library v0.1.7 [INFO] [stderr] Checking tempfile v2.2.0 [INFO] [stderr] Compiling xml-rs v0.7.0 [INFO] [stderr] Checking rayon-core v1.3.0 [INFO] [stderr] Checking num-bigint v0.1.40 [INFO] [stderr] Checking petgraph v0.4.10 [INFO] [stderr] Checking stb_truetype v0.2.1 [INFO] [stderr] Checking clap v2.27.1 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking x11-dl v2.16.0 [INFO] [stderr] Compiling conrod_derive v0.1.0 [INFO] [stderr] Checking png v0.11.0 [INFO] [stderr] Checking rayon v0.8.2 [INFO] [stderr] Checking rusttype v0.2.3 [INFO] [stderr] Checking backtrace v0.3.4 [INFO] [stderr] Compiling serde_derive v1.0.21 [INFO] [stderr] Compiling phf_generator v0.7.21 [INFO] [stderr] Checking num-rational v0.1.40 [INFO] [stderr] Compiling gl_generator v0.6.1 [INFO] [stderr] Checking daggy v0.5.0 [INFO] [stderr] Compiling phf_codegen v0.7.21 [INFO] [stderr] Checking num v0.1.40 [INFO] [stderr] Checking jpeg-decoder v0.1.13 [INFO] [stderr] Compiling target_build_utils v0.3.1 [INFO] [stderr] Compiling glutin v0.10.1 [INFO] [stderr] Compiling glium v0.18.1 [INFO] [stderr] Checking image v0.17.0 [INFO] [stderr] Checking pistoncore-input v0.20.0 [INFO] [stderr] Compiling libloading v0.3.4 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.9.10 [INFO] [stderr] Checking wayland-client v0.9.10 [INFO] [stderr] Checking wayland-protocols v0.9.10 [INFO] [stderr] Checking wayland-kbd v0.9.1 [INFO] [stderr] Checking wayland-window v0.8.0 [INFO] [stderr] Checking winit v0.8.3 [INFO] [stderr] Checking conrod v0.56.0 [INFO] [stderr] Checking rimger v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:186:5 [INFO] [stderr] | [INFO] [stderr] 186 | texture [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:185:19 [INFO] [stderr] | [INFO] [stderr] 185 | let texture = glium::texture::Texture2d::new(display, raw_image).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:186:5 [INFO] [stderr] | [INFO] [stderr] 186 | texture [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:185:19 [INFO] [stderr] | [INFO] [stderr] 185 | let texture = glium::texture::Texture2d::new(display, raw_image).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `EventLoop` [INFO] [stderr] --> src/main.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / pub fn new() -> Self { [INFO] [stderr] 30 | | EventLoop { [INFO] [stderr] 31 | | last_update: std::time::Instant::now(), [INFO] [stderr] 32 | | ui_needs_update: true, [INFO] [stderr] 33 | | } [INFO] [stderr] 34 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 27 | impl Default for EventLoop { [INFO] [stderr] 28 | fn default() -> Self { [INFO] [stderr] 29 | Self::new() [INFO] [stderr] 30 | } [INFO] [stderr] 31 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:109:42 [INFO] [stderr] | [INFO] [stderr] 109 | let mut ui = conrod::UiBuilder::new([WIDTH as f64, HEIGHT as f64]).build(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(WIDTH)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:109:56 [INFO] [stderr] | [INFO] [stderr] 109 | let mut ui = conrod::UiBuilder::new([WIDTH as f64, HEIGHT as f64]).build(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:143:13 [INFO] [stderr] | [INFO] [stderr] 143 | / match event { [INFO] [stderr] 144 | | glium::glutin::Event::WindowEvent { event, .. } => match event { [INFO] [stderr] 145 | | // Break from the loop upon `Escape`. [INFO] [stderr] 146 | | glium::glutin::WindowEvent::Closed | [INFO] [stderr] ... | [INFO] [stderr] 156 | | _ => (), [INFO] [stderr] 157 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 143 | if let glium::glutin::Event::WindowEvent { event, .. } = event { match event { [INFO] [stderr] 144 | // Break from the loop upon `Escape`. [INFO] [stderr] 145 | glium::glutin::WindowEvent::Closed | [INFO] [stderr] 146 | glium::glutin::WindowEvent::KeyboardInput { [INFO] [stderr] 147 | input: glium::glutin::KeyboardInput { [INFO] [stderr] 148 | virtual_keycode: Some(glium::glutin::VirtualKeyCode::Escape), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:166:43 [INFO] [stderr] | [INFO] [stderr] 166 | widget::Image::new(image).w_h(w as f64, h as f64).middle().set(ids.image, ui); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:166:53 [INFO] [stderr] | [INFO] [stderr] 166 | widget::Image::new(image).w_h(w as f64, h as f64).middle().set(ids.image, ui); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `EventLoop` [INFO] [stderr] --> src/main.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / pub fn new() -> Self { [INFO] [stderr] 30 | | EventLoop { [INFO] [stderr] 31 | | last_update: std::time::Instant::now(), [INFO] [stderr] 32 | | ui_needs_update: true, [INFO] [stderr] 33 | | } [INFO] [stderr] 34 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 27 | impl Default for EventLoop { [INFO] [stderr] 28 | fn default() -> Self { [INFO] [stderr] 29 | Self::new() [INFO] [stderr] 30 | } [INFO] [stderr] 31 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:109:42 [INFO] [stderr] | [INFO] [stderr] 109 | let mut ui = conrod::UiBuilder::new([WIDTH as f64, HEIGHT as f64]).build(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(WIDTH)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:109:56 [INFO] [stderr] | [INFO] [stderr] 109 | let mut ui = conrod::UiBuilder::new([WIDTH as f64, HEIGHT as f64]).build(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:143:13 [INFO] [stderr] | [INFO] [stderr] 143 | / match event { [INFO] [stderr] 144 | | glium::glutin::Event::WindowEvent { event, .. } => match event { [INFO] [stderr] 145 | | // Break from the loop upon `Escape`. [INFO] [stderr] 146 | | glium::glutin::WindowEvent::Closed | [INFO] [stderr] ... | [INFO] [stderr] 156 | | _ => (), [INFO] [stderr] 157 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 143 | if let glium::glutin::Event::WindowEvent { event, .. } = event { match event { [INFO] [stderr] 144 | // Break from the loop upon `Escape`. [INFO] [stderr] 145 | glium::glutin::WindowEvent::Closed | [INFO] [stderr] 146 | glium::glutin::WindowEvent::KeyboardInput { [INFO] [stderr] 147 | input: glium::glutin::KeyboardInput { [INFO] [stderr] 148 | virtual_keycode: Some(glium::glutin::VirtualKeyCode::Escape), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:166:43 [INFO] [stderr] | [INFO] [stderr] 166 | widget::Image::new(image).w_h(w as f64, h as f64).middle().set(ids.image, ui); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:166:53 [INFO] [stderr] | [INFO] [stderr] 166 | widget::Image::new(image).w_h(w as f64, h as f64).middle().set(ids.image, ui); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 30s [INFO] running `"docker" "inspect" "43992e225e8c9961a7015ba4d08160a4d9f3758e69fb46dea383858c04d7b39b"` [INFO] running `"docker" "rm" "-f" "43992e225e8c9961a7015ba4d08160a4d9f3758e69fb46dea383858c04d7b39b"` [INFO] [stdout] 43992e225e8c9961a7015ba4d08160a4d9f3758e69fb46dea383858c04d7b39b