[INFO] updating cached repository wdv4758h/clapcomp
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/wdv4758h/clapcomp
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/wdv4758h/clapcomp" "work/ex/clippy-test-run/sources/stable/gh/wdv4758h/clapcomp"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/wdv4758h/clapcomp'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/wdv4758h/clapcomp" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wdv4758h/clapcomp"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wdv4758h/clapcomp'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] edd822e3c78d3e9340c92d8a0dcb8b28474ee074
[INFO] sha for GitHub repo wdv4758h/clapcomp: edd822e3c78d3e9340c92d8a0dcb8b28474ee074
[INFO] validating manifest of wdv4758h/clapcomp on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of wdv4758h/clapcomp on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing wdv4758h/clapcomp
[INFO] finished frobbing wdv4758h/clapcomp
[INFO] frobbed toml for wdv4758h/clapcomp written to work/ex/clippy-test-run/sources/stable/gh/wdv4758h/clapcomp/Cargo.toml
[INFO] started frobbing wdv4758h/clapcomp
[INFO] finished frobbing wdv4758h/clapcomp
[INFO] frobbed toml for wdv4758h/clapcomp written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wdv4758h/clapcomp/Cargo.toml
[INFO] crate wdv4758h/clapcomp has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting wdv4758h/clapcomp against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/wdv4758h/clapcomp:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] cabf5e2f022c365758d736123dfc11790750108be7645aa0f7963346a11f837f
[INFO] running `"docker" "start" "-a" "cabf5e2f022c365758d736123dfc11790750108be7645aa0f7963346a11f837f"`
[INFO] [stderr]     Checking libc v0.2.22
[INFO] [stderr]     Checking yaml-rust v0.3.5
[INFO] [stderr]     Checking term_size v0.3.0
[INFO] [stderr]     Checking atty v0.2.2
[INFO] [stderr]     Checking clap v2.24.2
[INFO] [stderr]     Checking clapcomp v0.1.5 (/opt/crater/workdir)
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/main.rs:52:24
[INFO] [stderr]    |
[INFO] [stderr] 52 |                 .map(|s| match s {
[INFO] [stderr]    |  ________________________^
[INFO] [stderr] 53 | |                     &"bash" => Shell::Bash,
[INFO] [stderr] 54 | |                     &"fish" => Shell::Fish,
[INFO] [stderr] 55 | |                     &"zsh" => Shell::Zsh,
[INFO] [stderr] 56 | |                     &"powershell" => Shell::PowerShell,
[INFO] [stderr] 57 | |                     _ => unreachable!(),
[INFO] [stderr] 58 | |                  })
[INFO] [stderr]    | |__________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 52 |               .map(|s| match *s {
[INFO] [stderr] 53 |                     "bash" => Shell::Bash,
[INFO] [stderr] 54 |                     "fish" => Shell::Fish,
[INFO] [stderr] 55 |                     "zsh" => Shell::Zsh,
[INFO] [stderr] 56 |                     "powershell" => Shell::PowerShell,
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:74:44
[INFO] [stderr]    |
[INFO] [stderr] 74 |     let name = app.p.meta.bin_name.clone().unwrap_or(app.p.meta.name.clone());
[INFO] [stderr]    |                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| app.p.meta.name.clone())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/main.rs:52:24
[INFO] [stderr]    |
[INFO] [stderr] 52 |                 .map(|s| match s {
[INFO] [stderr]    |  ________________________^
[INFO] [stderr] 53 | |                     &"bash" => Shell::Bash,
[INFO] [stderr] 54 | |                     &"fish" => Shell::Fish,
[INFO] [stderr] 55 | |                     &"zsh" => Shell::Zsh,
[INFO] [stderr] 56 | |                     &"powershell" => Shell::PowerShell,
[INFO] [stderr] 57 | |                     _ => unreachable!(),
[INFO] [stderr] 58 | |                  })
[INFO] [stderr]    | |__________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 52 |               .map(|s| match *s {
[INFO] [stderr] 53 |                     "bash" => Shell::Bash,
[INFO] [stderr] 54 |                     "fish" => Shell::Fish,
[INFO] [stderr] 55 |                     "zsh" => Shell::Zsh,
[INFO] [stderr] 56 |                     "powershell" => Shell::PowerShell,
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:74:44
[INFO] [stderr]    |
[INFO] [stderr] 74 |     let name = app.p.meta.bin_name.clone().unwrap_or(app.p.meta.name.clone());
[INFO] [stderr]    |                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| app.p.meta.name.clone())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 11.80s
[INFO] running `"docker" "inspect" "cabf5e2f022c365758d736123dfc11790750108be7645aa0f7963346a11f837f"`
[INFO] running `"docker" "rm" "-f" "cabf5e2f022c365758d736123dfc11790750108be7645aa0f7963346a11f837f"`
[INFO] [stdout] cabf5e2f022c365758d736123dfc11790750108be7645aa0f7963346a11f837f