[INFO] updating cached repository wcauchois/wheel [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/wcauchois/wheel [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/wcauchois/wheel" "work/ex/clippy-test-run/sources/stable/gh/wcauchois/wheel"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/wcauchois/wheel'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/wcauchois/wheel" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wcauchois/wheel"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wcauchois/wheel'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 525ffc4d04d76aa732e2e1f36946d41f821e58b3 [INFO] sha for GitHub repo wcauchois/wheel: 525ffc4d04d76aa732e2e1f36946d41f821e58b3 [INFO] validating manifest of wcauchois/wheel on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wcauchois/wheel on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wcauchois/wheel [INFO] finished frobbing wcauchois/wheel [INFO] frobbed toml for wcauchois/wheel written to work/ex/clippy-test-run/sources/stable/gh/wcauchois/wheel/Cargo.toml [INFO] started frobbing wcauchois/wheel [INFO] finished frobbing wcauchois/wheel [INFO] frobbed toml for wcauchois/wheel written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wcauchois/wheel/Cargo.toml [INFO] crate wcauchois/wheel has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wcauchois/wheel against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/wcauchois/wheel:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e9c7b2e7d50b5c83596178e2ab6fcbb8f1a2b1ec8a42150db42d98a017ffc827 [INFO] running `"docker" "start" "-a" "e9c7b2e7d50b5c83596178e2ab6fcbb8f1a2b1ec8a42150db42d98a017ffc827"` [INFO] [stderr] Checking wheel v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:76:28 [INFO] [stderr] | [INFO] [stderr] 76 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 77 | | if let Some(idx) = buffer.find(':') { [INFO] [stderr] 78 | | let (key, value) = buffer.split_at(idx); [INFO] [stderr] 79 | | let value = &value[1..].trim_left(); [INFO] [stderr] 80 | | request_info.headers.insert(key.to_string(), value.to_string()); [INFO] [stderr] 81 | | } [INFO] [stderr] 82 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 76 | } else if let Some(idx) = buffer.find(':') { [INFO] [stderr] 77 | let (key, value) = buffer.split_at(idx); [INFO] [stderr] 78 | let value = &value[1..].trim_left(); [INFO] [stderr] 79 | request_info.headers.insert(key.to_string(), value.to_string()); [INFO] [stderr] 80 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unreachable statement [INFO] [stderr] --> src/main.rs:109:5 [INFO] [stderr] | [INFO] [stderr] 109 | println!("{}", Green.paint(format!("Listening on port {}", port))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:76:28 [INFO] [stderr] | [INFO] [stderr] 76 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 77 | | if let Some(idx) = buffer.find(':') { [INFO] [stderr] 78 | | let (key, value) = buffer.split_at(idx); [INFO] [stderr] 79 | | let value = &value[1..].trim_left(); [INFO] [stderr] 80 | | request_info.headers.insert(key.to_string(), value.to_string()); [INFO] [stderr] 81 | | } [INFO] [stderr] 82 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 76 | } else if let Some(idx) = buffer.find(':') { [INFO] [stderr] 77 | let (key, value) = buffer.split_at(idx); [INFO] [stderr] 78 | let value = &value[1..].trim_left(); [INFO] [stderr] 79 | request_info.headers.insert(key.to_string(), value.to_string()); [INFO] [stderr] 80 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused variable: `listener` [INFO] [stderr] --> src/main.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | let listener = TcpListener::bind( [INFO] [stderr] | ^^^^^^^^ help: consider using `_listener` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/template/tokenizer.rs:18:15 [INFO] [stderr] | [INFO] [stderr] 18 | match s.as_ref() { [INFO] [stderr] | ^^^^^^^^^^ help: try this: `s` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/template/tokenizer.rs:190:42 [INFO] [stderr] | [INFO] [stderr] 190 | .map(|k| Token::Keyword(k)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Token::Keyword` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: unreachable statement [INFO] [stderr] --> src/main.rs:109:5 [INFO] [stderr] | [INFO] [stderr] 109 | println!("{}", Green.paint(format!("Listening on port {}", port))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused variable: `listener` [INFO] [stderr] --> src/main.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | let listener = TcpListener::bind( [INFO] [stderr] | ^^^^^^^^ help: consider using `_listener` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/template/tokenizer.rs:18:15 [INFO] [stderr] | [INFO] [stderr] 18 | match s.as_ref() { [INFO] [stderr] | ^^^^^^^^^^ help: try this: `s` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/template/tokenizer.rs:190:42 [INFO] [stderr] | [INFO] [stderr] 190 | .map(|k| Token::Keyword(k)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Token::Keyword` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.80s [INFO] running `"docker" "inspect" "e9c7b2e7d50b5c83596178e2ab6fcbb8f1a2b1ec8a42150db42d98a017ffc827"` [INFO] running `"docker" "rm" "-f" "e9c7b2e7d50b5c83596178e2ab6fcbb8f1a2b1ec8a42150db42d98a017ffc827"` [INFO] [stdout] e9c7b2e7d50b5c83596178e2ab6fcbb8f1a2b1ec8a42150db42d98a017ffc827