[INFO] updating cached repository wbowling/cryptopals-rust
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/wbowling/cryptopals-rust
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/wbowling/cryptopals-rust" "work/ex/clippy-test-run/sources/stable/gh/wbowling/cryptopals-rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/wbowling/cryptopals-rust'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/wbowling/cryptopals-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wbowling/cryptopals-rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wbowling/cryptopals-rust'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 24e8f455d396fd6435e9d7290a7ff2b78d8590f8
[INFO] sha for GitHub repo wbowling/cryptopals-rust: 24e8f455d396fd6435e9d7290a7ff2b78d8590f8
[INFO] validating manifest of wbowling/cryptopals-rust on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of wbowling/cryptopals-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing wbowling/cryptopals-rust
[INFO] finished frobbing wbowling/cryptopals-rust
[INFO] frobbed toml for wbowling/cryptopals-rust written to work/ex/clippy-test-run/sources/stable/gh/wbowling/cryptopals-rust/Cargo.toml
[INFO] started frobbing wbowling/cryptopals-rust
[INFO] finished frobbing wbowling/cryptopals-rust
[INFO] frobbed toml for wbowling/cryptopals-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wbowling/cryptopals-rust/Cargo.toml
[INFO] crate wbowling/cryptopals-rust has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting wbowling/cryptopals-rust against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/wbowling/cryptopals-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] d4cd891c8ba4d1a582cb5bac86c85dfecfc7b909186424bbb8712c6e8f4ee997
[INFO] running `"docker" "start" "-a" "d4cd891c8ba4d1a582cb5bac86c85dfecfc7b909186424bbb8712c6e8f4ee997"`
[INFO] [stderr]     Checking base64 v0.10.0
[INFO] [stderr]     Checking cryptopals v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/crypto/xor.rs:36:5
[INFO] [stderr]    |
[INFO] [stderr] 36 |     return tot as i32;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `tot as i32`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/crypto/xor.rs:36:5
[INFO] [stderr]    |
[INFO] [stderr] 36 |     return tot as i32;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `tot as i32`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/crypto/xor.rs:33:21
[INFO] [stderr]    |
[INFO] [stderr] 33 | fn get_score(plain: &Vec<u8>) -> i32 {
[INFO] [stderr]    |                     ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]   --> src/set1/challenge3.rs:17:9
[INFO] [stderr]    |
[INFO] [stderr] 17 |         "Cooking MC's like a pound of bacon".as_bytes()
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"Cooking MC's like a pound of bacon"`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::string_lit_as_bytes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/set1/challenge4.rs:18:20
[INFO] [stderr]    |
[INFO] [stderr] 18 |     contents.split("\n").map(|s| s.to_string()).collect()
[INFO] [stderr]    |                    ^^^^ help: try using a char instead: `'\n'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/crypto/xor.rs:33:21
[INFO] [stderr]    |
[INFO] [stderr] 33 | fn get_score(plain: &Vec<u8>) -> i32 {
[INFO] [stderr]    |                     ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]   --> src/set1/challenge3.rs:17:9
[INFO] [stderr]    |
[INFO] [stderr] 17 |         "Cooking MC's like a pound of bacon".as_bytes()
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"Cooking MC's like a pound of bacon"`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::string_lit_as_bytes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/set1/challenge4.rs:18:20
[INFO] [stderr]    |
[INFO] [stderr] 18 |     contents.split("\n").map(|s| s.to_string()).collect()
[INFO] [stderr]    |                    ^^^^ help: try using a char instead: `'\n'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.92s
[INFO] running `"docker" "inspect" "d4cd891c8ba4d1a582cb5bac86c85dfecfc7b909186424bbb8712c6e8f4ee997"`
[INFO] running `"docker" "rm" "-f" "d4cd891c8ba4d1a582cb5bac86c85dfecfc7b909186424bbb8712c6e8f4ee997"`
[INFO] [stdout] d4cd891c8ba4d1a582cb5bac86c85dfecfc7b909186424bbb8712c6e8f4ee997