[INFO] updating cached repository wayslog/raven-rs
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/wayslog/raven-rs
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/wayslog/raven-rs" "work/ex/clippy-test-run/sources/stable/gh/wayslog/raven-rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/wayslog/raven-rs'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/wayslog/raven-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wayslog/raven-rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wayslog/raven-rs'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 68960938a0f70f3b7e71e4fff46780ac0f86cc55
[INFO] sha for GitHub repo wayslog/raven-rs: 68960938a0f70f3b7e71e4fff46780ac0f86cc55
[INFO] validating manifest of wayslog/raven-rs on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of wayslog/raven-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing wayslog/raven-rs
[INFO] finished frobbing wayslog/raven-rs
[INFO] frobbed toml for wayslog/raven-rs written to work/ex/clippy-test-run/sources/stable/gh/wayslog/raven-rs/Cargo.toml
[INFO] started frobbing wayslog/raven-rs
[INFO] finished frobbing wayslog/raven-rs
[INFO] frobbed toml for wayslog/raven-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wayslog/raven-rs/Cargo.toml
[INFO] crate wayslog/raven-rs has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting wayslog/raven-rs against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/wayslog/raven-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 5c4d4bd958254ed7316c6275ec61d392a2b52f880815db9af8bad99a06da48b9
[INFO] running `"docker" "start" "-a" "5c4d4bd958254ed7316c6275ec61d392a2b52f880815db9af8bad99a06da48b9"`
[INFO] [stderr]     Checking raven v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/resp/consts.rs:2:18
[INFO] [stderr]   |
[INFO] [stderr] 2 | pub const CRLF: &'static [u8]= b"\r\n";
[INFO] [stderr]   |                 -^^^^^^^----- help: consider removing `'static`: `&[u8]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/resp/consts.rs:2:18
[INFO] [stderr]   |
[INFO] [stderr] 2 | pub const CRLF: &'static [u8]= b"\r\n";
[INFO] [stderr]   |                 -^^^^^^^----- help: consider removing `'static`: `&[u8]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]  --> src/resp/consts.rs:4:38
[INFO] [stderr]   |
[INFO] [stderr] 4 | pub const PREFIX_SIMPLE_STRING: u8 = '+' as u8;
[INFO] [stderr]   |                                      ^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::char_lit_as_u8)] on by default
[INFO] [stderr]   = help: Consider using a byte literal instead:
[INFO] [stderr]           b'+'
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]  --> src/resp/consts.rs:5:30
[INFO] [stderr]   |
[INFO] [stderr] 5 | pub const PREFIX_ERROR: u8 = '-' as u8;
[INFO] [stderr]   |                              ^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = help: Consider using a byte literal instead:
[INFO] [stderr]           b'-'
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]  --> src/resp/consts.rs:6:32
[INFO] [stderr]   |
[INFO] [stderr] 6 | pub const PREFIX_INTEGER: u8 = ':' as u8;
[INFO] [stderr]   |                                ^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = help: Consider using a byte literal instead:
[INFO] [stderr]           b':'
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]  --> src/resp/consts.rs:7:36
[INFO] [stderr]   |
[INFO] [stderr] 7 | pub const PREFIX_BULK_STRING: u8 = '$' as u8;
[INFO] [stderr]   |                                    ^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = help: Consider using a byte literal instead:
[INFO] [stderr]           b'$'
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]  --> src/resp/consts.rs:8:30
[INFO] [stderr]   |
[INFO] [stderr] 8 | pub const PREFIX_ARRAY: u8 = '*' as u8;
[INFO] [stderr]   |                              ^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = help: Consider using a byte literal instead:
[INFO] [stderr]           b'*'
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/resp/mod.rs:129:9
[INFO] [stderr]     |
[INFO] [stderr] 129 | /         match self {
[INFO] [stderr] 130 | |             &SimpleString(ref data) => 1 + data.len() + 2,
[INFO] [stderr] 131 | |             &RedisError(ref data) => 1 + data.len() + 2,
[INFO] [stderr] 132 | |             &Integer(ref data) => 1 + data.len() + 2,
[INFO] [stderr] ...   |
[INFO] [stderr] 142 | |             }
[INFO] [stderr] 143 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 129 |         match *self {
[INFO] [stderr] 130 |             SimpleString(ref data) => 1 + data.len() + 2,
[INFO] [stderr] 131 |             RedisError(ref data) => 1 + data.len() + 2,
[INFO] [stderr] 132 |             Integer(ref data) => 1 + data.len() + 2,
[INFO] [stderr] 133 |             BulkString { ref count, ref data } => {
[INFO] [stderr] 134 |                 let mut len = 1 + count.shift() + data.len();
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: this `.fold` can be written more succinctly using another method
[INFO] [stderr]    --> src/resp/mod.rs:141:68
[INFO] [stderr]     |
[INFO] [stderr] 141 |                 1 + count.shift() + items.iter().map(|x| x.shift()).fold(0, |sum, acc| sum + acc)
[INFO] [stderr]     |                                                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unnecessary_fold)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]  --> src/resp/consts.rs:4:38
[INFO] [stderr]   |
[INFO] [stderr] 4 | pub const PREFIX_SIMPLE_STRING: u8 = '+' as u8;
[INFO] [stderr]   |                                      ^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::char_lit_as_u8)] on by default
[INFO] [stderr]   = help: Consider using a byte literal instead:
[INFO] [stderr]           b'+'
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]  --> src/resp/consts.rs:5:30
[INFO] [stderr]   |
[INFO] [stderr] 5 | pub const PREFIX_ERROR: u8 = '-' as u8;
[INFO] [stderr]   |                              ^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = help: Consider using a byte literal instead:
[INFO] [stderr]           b'-'
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]  --> src/resp/consts.rs:6:32
[INFO] [stderr]   |
[INFO] [stderr] 6 | pub const PREFIX_INTEGER: u8 = ':' as u8;
[INFO] [stderr]   |                                ^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = help: Consider using a byte literal instead:
[INFO] [stderr]           b':'
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]  --> src/resp/consts.rs:7:36
[INFO] [stderr]   |
[INFO] [stderr] 7 | pub const PREFIX_BULK_STRING: u8 = '$' as u8;
[INFO] [stderr]   |                                    ^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = help: Consider using a byte literal instead:
[INFO] [stderr]           b'$'
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]  --> src/resp/consts.rs:8:30
[INFO] [stderr]   |
[INFO] [stderr] 8 | pub const PREFIX_ARRAY: u8 = '*' as u8;
[INFO] [stderr]   |                              ^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = help: Consider using a byte literal instead:
[INFO] [stderr]           b'*'
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/resp/mod.rs:129:9
[INFO] [stderr]     |
[INFO] [stderr] 129 | /         match self {
[INFO] [stderr] 130 | |             &SimpleString(ref data) => 1 + data.len() + 2,
[INFO] [stderr] 131 | |             &RedisError(ref data) => 1 + data.len() + 2,
[INFO] [stderr] 132 | |             &Integer(ref data) => 1 + data.len() + 2,
[INFO] [stderr] ...   |
[INFO] [stderr] 142 | |             }
[INFO] [stderr] 143 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 129 |         match *self {
[INFO] [stderr] 130 |             SimpleString(ref data) => 1 + data.len() + 2,
[INFO] [stderr] 131 |             RedisError(ref data) => 1 + data.len() + 2,
[INFO] [stderr] 132 |             Integer(ref data) => 1 + data.len() + 2,
[INFO] [stderr] 133 |             BulkString { ref count, ref data } => {
[INFO] [stderr] 134 |                 let mut len = 1 + count.shift() + data.len();
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: this `.fold` can be written more succinctly using another method
[INFO] [stderr]    --> src/resp/mod.rs:141:68
[INFO] [stderr]     |
[INFO] [stderr] 141 |                 1 + count.shift() + items.iter().map(|x| x.shift()).fold(0, |sum, acc| sum + acc)
[INFO] [stderr]     |                                                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unnecessary_fold)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.31s
[INFO] running `"docker" "inspect" "5c4d4bd958254ed7316c6275ec61d392a2b52f880815db9af8bad99a06da48b9"`
[INFO] running `"docker" "rm" "-f" "5c4d4bd958254ed7316c6275ec61d392a2b52f880815db9af8bad99a06da48b9"`
[INFO] [stdout] 5c4d4bd958254ed7316c6275ec61d392a2b52f880815db9af8bad99a06da48b9