[INFO] updating cached repository wathiede/pbrt [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/wathiede/pbrt [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/wathiede/pbrt" "work/ex/clippy-test-run/sources/stable/gh/wathiede/pbrt"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/wathiede/pbrt'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/wathiede/pbrt" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wathiede/pbrt"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wathiede/pbrt'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 50c5c3025b59dbc1183bf9fad4ad673be5559ea4 [INFO] sha for GitHub repo wathiede/pbrt: 50c5c3025b59dbc1183bf9fad4ad673be5559ea4 [INFO] validating manifest of wathiede/pbrt on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wathiede/pbrt on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wathiede/pbrt [INFO] finished frobbing wathiede/pbrt [INFO] frobbed toml for wathiede/pbrt written to work/ex/clippy-test-run/sources/stable/gh/wathiede/pbrt/Cargo.toml [INFO] started frobbing wathiede/pbrt [INFO] finished frobbing wathiede/pbrt [INFO] frobbed toml for wathiede/pbrt written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wathiede/pbrt/Cargo.toml [INFO] crate wathiede/pbrt has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wathiede/pbrt against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/wathiede/pbrt:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c7a22c05c55ddc34d2ccd74ce5083f5aadad5dfd4e9b3219638d0229cd5ec29b [INFO] running `"docker" "start" "-a" "c7a22c05c55ddc34d2ccd74ce5083f5aadad5dfd4e9b3219638d0229cd5ec29b"` [INFO] [stderr] Checking libc v0.2.35 [INFO] [stderr] Checking regex-syntax v0.4.2 [INFO] [stderr] Checking difference v2.0.0 [INFO] [stderr] Checking log v0.4.1 [INFO] [stderr] Checking pretty_assertions v0.5.0 [INFO] [stderr] Checking memchr v2.0.1 [INFO] [stderr] Checking memchr v1.0.2 [INFO] [stderr] Checking nom v3.2.1 [INFO] [stderr] Checking aho-corasick v0.6.4 [INFO] [stderr] Checking regex v0.2.5 [INFO] [stderr] Checking pbrt v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/core/parser.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/core/parser.rs:79:1 [INFO] [stderr] | [INFO] [stderr] 79 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/core/parser.rs:133:1 [INFO] [stderr] | [INFO] [stderr] 133 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/core/parser.rs:151:1 [INFO] [stderr] | [INFO] [stderr] 151 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/core/parser.rs:163:1 [INFO] [stderr] | [INFO] [stderr] 163 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/core/parser.rs:174:1 [INFO] [stderr] | [INFO] [stderr] 174 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/core/parser.rs:185:1 [INFO] [stderr] | [INFO] [stderr] 185 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/core/parser.rs:196:1 [INFO] [stderr] | [INFO] [stderr] 196 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/core/parser.rs:218:1 [INFO] [stderr] | [INFO] [stderr] 218 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/core/parser.rs:232:1 [INFO] [stderr] | [INFO] [stderr] 232 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/core/parser.rs:263:1 [INFO] [stderr] | [INFO] [stderr] 263 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/core/parser.rs:277:1 [INFO] [stderr] | [INFO] [stderr] 277 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/core/parser.rs:282:1 [INFO] [stderr] | [INFO] [stderr] 282 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/core/parser.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/core/parser.rs:79:1 [INFO] [stderr] | [INFO] [stderr] 79 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/core/parser.rs:133:1 [INFO] [stderr] | [INFO] [stderr] 133 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/core/parser.rs:151:1 [INFO] [stderr] | [INFO] [stderr] 151 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/core/parser.rs:163:1 [INFO] [stderr] | [INFO] [stderr] 163 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/core/parser.rs:174:1 [INFO] [stderr] | [INFO] [stderr] 174 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/core/parser.rs:185:1 [INFO] [stderr] | [INFO] [stderr] 185 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/core/parser.rs:196:1 [INFO] [stderr] | [INFO] [stderr] 196 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/core/parser.rs:218:1 [INFO] [stderr] | [INFO] [stderr] 218 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/core/parser.rs:232:1 [INFO] [stderr] | [INFO] [stderr] 232 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/core/parser.rs:263:1 [INFO] [stderr] | [INFO] [stderr] 263 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/core/parser.rs:277:1 [INFO] [stderr] | [INFO] [stderr] 277 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/core/parser.rs:282:1 [INFO] [stderr] | [INFO] [stderr] 282 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/core/parser.rs:335:1 [INFO] [stderr] | [INFO] [stderr] 335 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/core/parser.rs:349:1 [INFO] [stderr] | [INFO] [stderr] 349 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/core/parser.rs:364:1 [INFO] [stderr] | [INFO] [stderr] 364 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/core/parser.rs:335:1 [INFO] [stderr] | [INFO] [stderr] 335 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/core/parser.rs:378:1 [INFO] [stderr] | [INFO] [stderr] 378 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/core/parser.rs:405:1 [INFO] [stderr] | [INFO] [stderr] 405 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/core/parser.rs:444:1 [INFO] [stderr] | [INFO] [stderr] 444 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/core/parser.rs:349:1 [INFO] [stderr] | [INFO] [stderr] 349 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/core/parser.rs:364:1 [INFO] [stderr] | [INFO] [stderr] 364 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/core/parser.rs:378:1 [INFO] [stderr] | [INFO] [stderr] 378 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/core/parser.rs:405:1 [INFO] [stderr] | [INFO] [stderr] 405 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/core/parser.rs:444:1 [INFO] [stderr] | [INFO] [stderr] 444 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: lint name `manual_swap` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/core/transform.rs:87:60 [INFO] [stderr] | [INFO] [stderr] 87 | #[cfg_attr(feature = "cargo-clippy", allow(manual_swap))] [INFO] [stderr] | ^^^^^^^^^^^ help: change it to: `clippy::manual_swap` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `cyclomatic_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/core/parser.rs:96:44 [INFO] [stderr] | [INFO] [stderr] 96 | #[cfg_attr(feature = "cargo-clippy", allow(cyclomatic_complexity))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::cyclomatic_complexity` [INFO] [stderr] [INFO] [stderr] warning: lint name `manual_swap` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/core/transform.rs:87:60 [INFO] [stderr] | [INFO] [stderr] 87 | #[cfg_attr(feature = "cargo-clippy", allow(manual_swap))] [INFO] [stderr] | ^^^^^^^^^^^ help: change it to: `clippy::manual_swap` [INFO] [stderr] [INFO] [stderr] warning: lint name `manual_swap` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/core/transform.rs:87:60 [INFO] [stderr] | [INFO] [stderr] 87 | #[cfg_attr(feature = "cargo-clippy", allow(manual_swap))] [INFO] [stderr] | ^^^^^^^^^^^ help: change it to: `clippy::manual_swap` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `cyclomatic_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/core/parser.rs:96:44 [INFO] [stderr] | [INFO] [stderr] 96 | #[cfg_attr(feature = "cargo-clippy", allow(cyclomatic_complexity))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::cyclomatic_complexity` [INFO] [stderr] [INFO] [stderr] warning: lint name `manual_swap` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/core/transform.rs:87:60 [INFO] [stderr] | [INFO] [stderr] 87 | #[cfg_attr(feature = "cargo-clippy", allow(manual_swap))] [INFO] [stderr] | ^^^^^^^^^^^ help: change it to: `clippy::manual_swap` [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/core/api.rs:594:9 [INFO] [stderr] | [INFO] [stderr] 594 | assert_eq!(pbrt.current_transform.t[0].matrix().m[0][0], 2.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/core/api.rs:594:9 [INFO] [stderr] | [INFO] [stderr] 594 | assert_eq!(pbrt.current_transform.t[0].matrix().m[0][0], 2.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/core/api.rs:596:32 [INFO] [stderr] | [INFO] [stderr] 596 | pbrt.coordinate_system("two".into()); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider removing `.into()`: `"two"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/core/api.rs:599:9 [INFO] [stderr] | [INFO] [stderr] 599 | assert_eq!(pbrt.current_transform.t[0].matrix().m[0][0], 3.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/core/api.rs:599:9 [INFO] [stderr] | [INFO] [stderr] 599 | assert_eq!(pbrt.current_transform.t[0].matrix().m[0][0], 3.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/core/api.rs:601:42 [INFO] [stderr] | [INFO] [stderr] 601 | pbrt.coordinate_system_transform("two".into()); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider removing `.into()`: `"two"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/core/api.rs:602:9 [INFO] [stderr] | [INFO] [stderr] 602 | assert_eq!(pbrt.current_transform.t[0].matrix().m[0][0], 2.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/core/api.rs:602:9 [INFO] [stderr] | [INFO] [stderr] 602 | assert_eq!(pbrt.current_transform.t[0].matrix().m[0][0], 2.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/core/geometry.rs:143:9 [INFO] [stderr] | [INFO] [stderr] 143 | assert_eq!(v3f.length(), 1.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/core/geometry.rs:143:9 [INFO] [stderr] | [INFO] [stderr] 143 | assert_eq!(v3f.length(), 1.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/core/geometry.rs:158:9 [INFO] [stderr] | [INFO] [stderr] 158 | assert_eq!(v3f.length(), 1.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/core/geometry.rs:158:9 [INFO] [stderr] | [INFO] [stderr] 158 | assert_eq!(v3f.length(), 1.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/core/geometry.rs:173:9 [INFO] [stderr] | [INFO] [stderr] 173 | assert_eq!(v3f.length(), 1.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/core/geometry.rs:173:9 [INFO] [stderr] | [INFO] [stderr] 173 | assert_eq!(v3f.length(), 1.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/core/geometry.rs:184:9 [INFO] [stderr] | [INFO] [stderr] 184 | assert_eq!(v3i.length(), 1.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/core/geometry.rs:184:9 [INFO] [stderr] | [INFO] [stderr] 184 | assert_eq!(v3i.length(), 1.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/core/paramset.rs:183:18 [INFO] [stderr] | [INFO] [stderr] 183 | .unwrap_or(Value::Float(ParamList(vec![1., 2.]))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Value::Float(ParamList(vec![1., 2.])))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/core/parser.rs:468:9 [INFO] [stderr] | [INFO] [stderr] 468 | / match res { [INFO] [stderr] 469 | | &IResult::Done(ref i, ref o) => println!("i: {:?} | o: {:?}", str::from_utf8(i), o), [INFO] [stderr] 470 | | &IResult::Error(ref e) => panic!("e: {:#?}", e), [INFO] [stderr] 471 | | &IResult::Incomplete(n) => panic!("need: {:?}", n), [INFO] [stderr] 472 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 468 | match *res { [INFO] [stderr] 469 | IResult::Done(ref i, ref o) => println!("i: {:?} | o: {:?}", str::from_utf8(i), o), [INFO] [stderr] 470 | IResult::Error(ref e) => panic!("e: {:#?}", e), [INFO] [stderr] 471 | IResult::Incomplete(n) => panic!("need: {:?}", n), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/core/parser.rs:497:66 [INFO] [stderr] | [INFO] [stderr] 497 | assert_eq!(number(&b"3.14"[..]), IResult::Done(&b""[..], 3.14)); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/core/parser.rs:507:17 [INFO] [stderr] | [INFO] [stderr] 507 | let ref res = param_set_item_values_float(&input); [INFO] [stderr] | ----^^^^^^^--------------------------------------- help: try: `let res = ¶m_set_item_values_float(&input);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/core/parser.rs:518:13 [INFO] [stderr] | [INFO] [stderr] 518 | let ref res = param_set_item_values_point(&input); [INFO] [stderr] | ----^^^^^^^--------------------------------------- help: try: `let res = ¶m_set_item_values_point(&input);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/core/parser.rs:544:13 [INFO] [stderr] | [INFO] [stderr] 544 | let ref res = param_set_item_values_float(&input); [INFO] [stderr] | ----^^^^^^^--------------------------------------- help: try: `let res = ¶m_set_item_values_float(&input);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/core/parser.rs:551:13 [INFO] [stderr] | [INFO] [stderr] 551 | let ref res = param_set_item_values_float(input); [INFO] [stderr] | ----^^^^^^^-------------------------------------- help: try: `let res = ¶m_set_item_values_float(input);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/core/parser.rs:558:13 [INFO] [stderr] | [INFO] [stderr] 558 | let ref res = param_set_item_values_float(input); [INFO] [stderr] | ----^^^^^^^-------------------------------------- help: try: `let res = ¶m_set_item_values_float(input);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/core/parser.rs:568:13 [INFO] [stderr] | [INFO] [stderr] 568 | let ref res = param_set_item_values_integer(&input); [INFO] [stderr] | ----^^^^^^^----------------------------------------- help: try: `let res = ¶m_set_item_values_integer(&input);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/core/parser.rs:575:13 [INFO] [stderr] | [INFO] [stderr] 575 | let ref res = param_set_item_values_integer(&input); [INFO] [stderr] | ----^^^^^^^----------------------------------------- help: try: `let res = ¶m_set_item_values_integer(&input);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/core/parser.rs:585:13 [INFO] [stderr] | [INFO] [stderr] 585 | let ref res = param_set_item_values_string(&input); [INFO] [stderr] | ----^^^^^^^---------------------------------------- help: try: `let res = ¶m_set_item_values_string(&input);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/core/parser.rs:592:13 [INFO] [stderr] | [INFO] [stderr] 592 | let ref res = param_set_item_values_string(&input); [INFO] [stderr] | ----^^^^^^^---------------------------------------- help: try: `let res = ¶m_set_item_values_string(&input);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/core/parser.rs:602:13 [INFO] [stderr] | [INFO] [stderr] 602 | let ref res = param_set_item_values_texture(&input); [INFO] [stderr] | ----^^^^^^^----------------------------------------- help: try: `let res = ¶m_set_item_values_texture(&input);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/core/parser.rs:609:13 [INFO] [stderr] | [INFO] [stderr] 609 | let ref res = param_set_item_values_texture(&input); [INFO] [stderr] | ----^^^^^^^----------------------------------------- help: try: `let res = ¶m_set_item_values_texture(&input);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/core/parser.rs:619:13 [INFO] [stderr] | [INFO] [stderr] 619 | let ref res = param_set_item(input); [INFO] [stderr] | ----^^^^^^^------------------------- help: try: `let res = ¶m_set_item(input);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/core/parser.rs:632:13 [INFO] [stderr] | [INFO] [stderr] 632 | let ref res = param_set_item(input); [INFO] [stderr] | ----^^^^^^^------------------------- help: try: `let res = ¶m_set_item(input);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/core/parser.rs:645:13 [INFO] [stderr] | [INFO] [stderr] 645 | let ref res = param_set_item(input); [INFO] [stderr] | ----^^^^^^^------------------------- help: try: `let res = ¶m_set_item(input);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/core/parser.rs:663:13 [INFO] [stderr] | [INFO] [stderr] 663 | let ref res = param_set(input); [INFO] [stderr] | ----^^^^^^^-------------------- help: try: `let res = ¶m_set(input);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/core/parser.rs:681:13 [INFO] [stderr] | [INFO] [stderr] 681 | let ref res = param_set(input); [INFO] [stderr] | ----^^^^^^^-------------------- help: try: `let res = ¶m_set(input);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/core/parser.rs:698:13 [INFO] [stderr] | [INFO] [stderr] 698 | let ref res = param_set(input); [INFO] [stderr] | ----^^^^^^^-------------------- help: try: `let res = ¶m_set(input);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/core/parser.rs:722:17 [INFO] [stderr] | [INFO] [stderr] 722 | let ref mut res = look_at(&input); [INFO] [stderr] | ----^^^^^^^^^^^------------------- help: try: `let res = &mut look_at(&input);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/core/parser.rs:737:17 [INFO] [stderr] | [INFO] [stderr] 737 | let ref mut res = camera(&input); [INFO] [stderr] | ----^^^^^^^^^^^------------------ help: try: `let res = &mut camera(&input);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/core/parser.rs:755:17 [INFO] [stderr] | [INFO] [stderr] 755 | let ref mut res = sampler(&input); [INFO] [stderr] | ----^^^^^^^^^^^------------------- help: try: `let res = &mut sampler(&input);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/core/parser.rs:776:17 [INFO] [stderr] | [INFO] [stderr] 776 | let ref mut res = integrator(&input); [INFO] [stderr] | ----^^^^^^^^^^^---------------------- help: try: `let res = &mut integrator(&input);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/core/parser.rs:791:13 [INFO] [stderr] | [INFO] [stderr] 791 | let ref mut res = film(&input); [INFO] [stderr] | ----^^^^^^^^^^^---------------- help: try: `let res = &mut film(&input);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/core/parser.rs:815:13 [INFO] [stderr] | [INFO] [stderr] 815 | let ref mut res = directives(&input); [INFO] [stderr] | ----^^^^^^^^^^^---------------------- help: try: `let res = &mut directives(&input);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/core/parser.rs:835:13 [INFO] [stderr] | [INFO] [stderr] 835 | let ref mut res = directives(&input); [INFO] [stderr] | ----^^^^^^^^^^^---------------------- help: try: `let res = &mut directives(&input);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/core/parser.rs:849:13 [INFO] [stderr] | [INFO] [stderr] 849 | let ref mut res = directives(&input); [INFO] [stderr] | ----^^^^^^^^^^^---------------------- help: try: `let res = &mut directives(&input);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/core/parser.rs:854:17 [INFO] [stderr] | [INFO] [stderr] 854 | / vec![ [INFO] [stderr] 855 | | Directive::AttributeBegin, [INFO] [stderr] 856 | | Directive::Shape( [INFO] [stderr] 857 | | "sphere".into(), [INFO] [stderr] ... | [INFO] [stderr] 860 | | Directive::AttributeEnd, [INFO] [stderr] 861 | | ].into(), [INFO] [stderr] | |________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into()` [INFO] [stderr] | [INFO] [stderr] 854 | vec![ [INFO] [stderr] 855 | Directive::AttributeBegin, [INFO] [stderr] 856 | Directive::Shape( [INFO] [stderr] 857 | "sphere".into(), [INFO] [stderr] 858 | vec![ParamSetItem::new("radius", &Value::Float(vec![1.].into()))].into(), [INFO] [stderr] 859 | ), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/core/parser.rs:866:13 [INFO] [stderr] | [INFO] [stderr] 866 | let ref mut res = directives(&input); [INFO] [stderr] | ----^^^^^^^^^^^---------------------- help: try: `let res = &mut directives(&input);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/core/parser.rs:871:17 [INFO] [stderr] | [INFO] [stderr] 871 | / vec![ [INFO] [stderr] 872 | | Directive::AttributeBegin, [INFO] [stderr] 873 | | Directive::Material("mirror".into(), vec![].into()), [INFO] [stderr] 874 | | Directive::Shape( [INFO] [stderr] ... | [INFO] [stderr] 878 | | Directive::AttributeEnd, [INFO] [stderr] 879 | | ].into(), [INFO] [stderr] | |________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into()` [INFO] [stderr] | [INFO] [stderr] 871 | vec![ [INFO] [stderr] 872 | Directive::AttributeBegin, [INFO] [stderr] 873 | Directive::Material("mirror".into(), vec![].into()), [INFO] [stderr] 874 | Directive::Shape( [INFO] [stderr] 875 | "sphere".into(), [INFO] [stderr] 876 | vec![ParamSetItem::new("radius", &Value::Float(vec![1.].into()))].into(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/core/parser.rs:887:13 [INFO] [stderr] | [INFO] [stderr] 887 | let ref mut res = light_source(&input); [INFO] [stderr] | ----^^^^^^^^^^^------------------------ help: try: `let res = &mut light_source(&input);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/core/parser.rs:906:13 [INFO] [stderr] | [INFO] [stderr] 906 | let ref mut res = material(&input); [INFO] [stderr] | ----^^^^^^^^^^^-------------------- help: try: `let res = &mut material(&input);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/core/parser.rs:919:13 [INFO] [stderr] | [INFO] [stderr] 919 | let ref mut res = shape(&input); [INFO] [stderr] | ----^^^^^^^^^^^----------------- help: try: `let res = &mut shape(&input);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/core/parser.rs:935:13 [INFO] [stderr] | [INFO] [stderr] 935 | let ref mut res = translate(&input); [INFO] [stderr] | ----^^^^^^^^^^^--------------------- help: try: `let res = &mut translate(&input);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/core/parser.rs:945:13 [INFO] [stderr] | [INFO] [stderr] 945 | let ref mut res = scale(&input); [INFO] [stderr] | ----^^^^^^^^^^^----------------- help: try: `let res = &mut scale(&input);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/core/parser.rs:952:13 [INFO] [stderr] | [INFO] [stderr] 952 | let ref mut res = rotate(&input); [INFO] [stderr] | ----^^^^^^^^^^^------------------ help: try: `let res = &mut rotate(&input);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to 8 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `pbrt`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "c7a22c05c55ddc34d2ccd74ce5083f5aadad5dfd4e9b3219638d0229cd5ec29b"` [INFO] running `"docker" "rm" "-f" "c7a22c05c55ddc34d2ccd74ce5083f5aadad5dfd4e9b3219638d0229cd5ec29b"` [INFO] [stdout] c7a22c05c55ddc34d2ccd74ce5083f5aadad5dfd4e9b3219638d0229cd5ec29b