[INFO] updating cached repository watanabe-kts/http-server-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/watanabe-kts/http-server-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/watanabe-kts/http-server-rust" "work/ex/clippy-test-run/sources/stable/gh/watanabe-kts/http-server-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/watanabe-kts/http-server-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/watanabe-kts/http-server-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/watanabe-kts/http-server-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/watanabe-kts/http-server-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 95287a31114d648d007c8a02994256b04b6a06b4 [INFO] sha for GitHub repo watanabe-kts/http-server-rust: 95287a31114d648d007c8a02994256b04b6a06b4 [INFO] validating manifest of watanabe-kts/http-server-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of watanabe-kts/http-server-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing watanabe-kts/http-server-rust [INFO] finished frobbing watanabe-kts/http-server-rust [INFO] frobbed toml for watanabe-kts/http-server-rust written to work/ex/clippy-test-run/sources/stable/gh/watanabe-kts/http-server-rust/Cargo.toml [INFO] started frobbing watanabe-kts/http-server-rust [INFO] finished frobbing watanabe-kts/http-server-rust [INFO] frobbed toml for watanabe-kts/http-server-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/watanabe-kts/http-server-rust/Cargo.toml [INFO] crate watanabe-kts/http-server-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting watanabe-kts/http-server-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/watanabe-kts/http-server-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 31f45250c73b35258895282dafbe6cdd7effcabb9a772848b980e4ac879d22b7 [INFO] running `"docker" "start" "-a" "31f45250c73b35258895282dafbe6cdd7effcabb9a772848b980e4ac879d22b7"` [INFO] [stderr] Checking memchr v2.1.0 [INFO] [stderr] Checking aho-corasick v0.6.8 [INFO] [stderr] Checking regex v1.0.5 [INFO] [stderr] Checking env_logger v0.5.13 [INFO] [stderr] Checking http v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/response.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | / write!(&mut bw, "{} {} {}\r\n", [INFO] [stderr] 45 | | self.http_version, self.status_code, self.status_message)?; [INFO] [stderr] | |________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/response.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | write!(&mut bw, "{}: {}\r\n", name, value); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/response.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | write!(&mut bw, "\r\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/response.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | / write!(&mut bw, "{} {} {}\r\n", [INFO] [stderr] 45 | | self.http_version, self.status_code, self.status_message)?; [INFO] [stderr] | |________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/response.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | write!(&mut bw, "{}: {}\r\n", name, value); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/response.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | write!(&mut bw, "\r\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] error[E0308]: mismatched types [INFO] [stderr] --> src/request.rs:135:13 [INFO] [stderr] | [INFO] [stderr] 135 | b"Host: example.com:7777", [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ expected an array with a fixed size of 27 elements, found one with 22 elements [INFO] [stderr] | [INFO] [stderr] = note: expected type `&[u8; 27]` [INFO] [stderr] found type `&'static [u8; 22]` [INFO] [stderr] [INFO] [stderr] error[E0308]: mismatched types [INFO] [stderr] --> src/request.rs:152:34 [INFO] [stderr] | [INFO] [stderr] 152 | let req = Request::parse(msg); [INFO] [stderr] | ^^^ expected &[u8], found struct `std::iter::Map` [INFO] [stderr] | [INFO] [stderr] = note: expected type `&[u8]` [INFO] [stderr] found type `std::iter::Map, [closure@src/request.rs:150:22: 150:39]>` [INFO] [stderr] [INFO] [stderr] error[E0308]: mismatched types [INFO] [stderr] --> src/request.rs:165:34 [INFO] [stderr] | [INFO] [stderr] 165 | let req = Request::parse(msg); [INFO] [stderr] | ^^^ expected &[u8], found struct `std::iter::Map` [INFO] [stderr] | [INFO] [stderr] = note: expected type `&[u8]` [INFO] [stderr] found type `std::iter::Map, [closure@src/request.rs:163:22: 163:39]>` [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0308`. [INFO] [stderr] error: Could not compile `http`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: method is never used: `method` [INFO] [stderr] --> src/request.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn method(&self) -> &Method { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `http_version` [INFO] [stderr] --> src/request.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn http_version(&self) -> &str { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `raw_headers` [INFO] [stderr] --> src/request.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn raw_headers(&self) -> &[String] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `kind` [INFO] [stderr] --> src/request.rs:106:5 [INFO] [stderr] | [INFO] [stderr] 106 | pub fn kind(&self) -> ErrorKind { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/server.rs:62:21 [INFO] [stderr] | [INFO] [stderr] 62 | io::stdout().write(&self.buf[prev_pos .. self.pos])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/server.rs:67:25 [INFO] [stderr] | [INFO] [stderr] 67 | / match req_result { [INFO] [stderr] 68 | | Ok(req) => { [INFO] [stderr] 69 | | self.state = ConnectionState::Sending; [INFO] [stderr] 70 | | poll.reregister( [INFO] [stderr] ... | [INFO] [stderr] 74 | | Err(_) => {/*todo: bad request*/} [INFO] [stderr] 75 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 67 | if let Ok(req) = req_result { [INFO] [stderr] 68 | self.state = ConnectionState::Sending; [INFO] [stderr] 69 | poll.reregister( [INFO] [stderr] 70 | &self.socket, self.token, Ready::writable(), PollOpt::edge())?; [INFO] [stderr] 71 | self.request = Some(req); [INFO] [stderr] 72 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/request.rs:77:41 [INFO] [stderr] | [INFO] [stderr] 77 | let mut tokens = line.split(":"); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/response.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | write!(&mut bw, "{}: {}\r\n", name, value); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/response.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | bw.write(&self.body)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `http`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "31f45250c73b35258895282dafbe6cdd7effcabb9a772848b980e4ac879d22b7"` [INFO] running `"docker" "rm" "-f" "31f45250c73b35258895282dafbe6cdd7effcabb9a772848b980e4ac879d22b7"` [INFO] [stdout] 31f45250c73b35258895282dafbe6cdd7effcabb9a772848b980e4ac879d22b7