[INFO] updating cached repository warnp/vision_rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/warnp/vision_rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/warnp/vision_rs" "work/ex/clippy-test-run/sources/stable/gh/warnp/vision_rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/warnp/vision_rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/warnp/vision_rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/warnp/vision_rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/warnp/vision_rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1e5c6af594fbde0bd4f5102bc41e0e1933ba0fd2 [INFO] sha for GitHub repo warnp/vision_rs: 1e5c6af594fbde0bd4f5102bc41e0e1933ba0fd2 [INFO] validating manifest of warnp/vision_rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of warnp/vision_rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing warnp/vision_rs [INFO] finished frobbing warnp/vision_rs [INFO] frobbed toml for warnp/vision_rs written to work/ex/clippy-test-run/sources/stable/gh/warnp/vision_rs/Cargo.toml [INFO] started frobbing warnp/vision_rs [INFO] finished frobbing warnp/vision_rs [INFO] frobbed toml for warnp/vision_rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/warnp/vision_rs/Cargo.toml [INFO] crate warnp/vision_rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting warnp/vision_rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/warnp/vision_rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ff22bf50ec068c640161b9b3c4d9ce3afddc31f497814f3bff103bf22e59a8fe [INFO] running `"docker" "start" "-a" "ff22bf50ec068c640161b9b3c4d9ce3afddc31f497814f3bff103bf22e59a8fe"` [INFO] [stderr] Checking remove_dir_all v0.5.0 [INFO] [stderr] Checking chunked_transfer v0.3.1 [INFO] [stderr] Checking ascii v0.7.1 [INFO] [stderr] Compiling pest v1.0.6 [INFO] [stderr] Checking quick-error v1.2.1 [INFO] [stderr] Checking num-integer v0.1.36 [INFO] [stderr] Checking memchr v1.0.2 [INFO] [stderr] Checking time v0.1.39 [INFO] [stderr] Checking memchr v2.0.1 [INFO] [stderr] Checking filetime v0.1.15 [INFO] [stderr] Compiling brotli-sys v0.2.1 [INFO] [stderr] Checking base64 v0.7.0 [INFO] [stderr] Checking serde_json v1.0.13 [INFO] [stderr] Checking tempdir v0.3.7 [INFO] [stderr] Checking threadpool v1.7.1 [INFO] [stderr] Checking buf_redux v0.6.3 [INFO] [stderr] Checking num-iter v0.1.35 [INFO] [stderr] Checking twoway v0.1.8 [INFO] [stderr] Checking aho-corasick v0.6.4 [INFO] [stderr] Checking uuid v0.1.18 [INFO] [stderr] Checking chrono v0.4.2 [INFO] [stderr] Compiling pest_derive v1.0.7 [INFO] [stderr] Checking gzip-header v0.1.2 [INFO] [stderr] Checking term v0.2.14 [INFO] [stderr] Compiling phf_generator v0.7.21 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Checking url v0.2.38 [INFO] [stderr] Checking regex v0.2.10 [INFO] [stderr] Compiling phf_codegen v0.7.21 [INFO] [stderr] Checking deflate v0.7.18 [INFO] [stderr] Checking chrono v0.2.25 [INFO] [stderr] Compiling mime_guess v1.8.4 [INFO] [stderr] Checking tiny_http v0.5.9 [INFO] [stderr] Checking handlebars v0.32.0 [INFO] [stderr] Checking multipart v0.13.6 [INFO] [stderr] Checking brotli2 v0.2.2 [INFO] [stderr] Checking rouille v2.1.0 [INFO] [stderr] Checking vision v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `handlebars` [INFO] [stderr] --> src/controller/mod.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use handlebars; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `TemplateContext`, `TemplateWrapper` [INFO] [stderr] --> src/controller/mod.rs:5:17 [INFO] [stderr] | [INFO] [stderr] 5 | use data_type::{TemplateWrapper, DayTemplate, TemplateContext, Trip}; [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `PathBuf` [INFO] [stderr] --> src/controller/mod.rs:6:23 [INFO] [stderr] | [INFO] [stderr] 6 | use std::path::{Path, PathBuf}; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `serde_json::Value` [INFO] [stderr] --> src/controller/mod.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use serde_json::Value; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller/mod.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | return response; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `response` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller/mod.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | return Response::text("Erreur 404, fichier non trouvé").with_status_code(404); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Response::text("Erreur 404, fichier non trouvé").with_status_code(404)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused imports: `PathBuf`, `Path` [INFO] [stderr] --> src/main.rs:12:17 [INFO] [stderr] | [INFO] [stderr] 12 | use std::path::{Path, PathBuf}; [INFO] [stderr] | ^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fs::File` [INFO] [stderr] --> src/main.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | use std::fs::File; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::prelude::*` [INFO] [stderr] --> src/main.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | use std::io::prelude::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `handlebars::Handlebars` [INFO] [stderr] --> src/main.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | use handlebars::Handlebars; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `DayTemplate`, `TemplateContext`, `TemplateWrapper`, `Trip` [INFO] [stderr] --> src/main.rs:16:17 [INFO] [stderr] | [INFO] [stderr] 16 | use data_type::{TemplateContext, DayTemplate, TemplateWrapper, Trip}; [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^^^^^^ ^^^^^^^^^^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:19:15 [INFO] [stderr] | [INFO] [stderr] 19 | const HOST : &'static str = "localhost:8000"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `handlebars` [INFO] [stderr] --> src/controller/mod.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use handlebars; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `TemplateContext`, `TemplateWrapper` [INFO] [stderr] --> src/controller/mod.rs:5:17 [INFO] [stderr] | [INFO] [stderr] 5 | use data_type::{TemplateWrapper, DayTemplate, TemplateContext, Trip}; [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `PathBuf` [INFO] [stderr] --> src/controller/mod.rs:6:23 [INFO] [stderr] | [INFO] [stderr] 6 | use std::path::{Path, PathBuf}; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `serde_json::Value` [INFO] [stderr] --> src/controller/mod.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use serde_json::Value; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller/mod.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | return response; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `response` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller/mod.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | return Response::text("Erreur 404, fichier non trouvé").with_status_code(404); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Response::text("Erreur 404, fichier non trouvé").with_status_code(404)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused imports: `PathBuf`, `Path` [INFO] [stderr] --> src/main.rs:12:17 [INFO] [stderr] | [INFO] [stderr] 12 | use std::path::{Path, PathBuf}; [INFO] [stderr] | ^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fs::File` [INFO] [stderr] --> src/main.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | use std::fs::File; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::prelude::*` [INFO] [stderr] --> src/main.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | use std::io::prelude::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `handlebars::Handlebars` [INFO] [stderr] --> src/main.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | use handlebars::Handlebars; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `DayTemplate`, `TemplateContext`, `TemplateWrapper`, `Trip` [INFO] [stderr] --> src/main.rs:16:17 [INFO] [stderr] | [INFO] [stderr] 16 | use data_type::{TemplateContext, DayTemplate, TemplateWrapper, Trip}; [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^^^^^^ ^^^^^^^^^^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:19:15 [INFO] [stderr] | [INFO] [stderr] 19 | const HOST : &'static str = "localhost:8000"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused variable: `req` [INFO] [stderr] --> src/controller/mod.rs:21:20 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn serve_index(req: &Request) -> Response { [INFO] [stderr] | ^^^ help: consider using `_req` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `req` [INFO] [stderr] --> src/controller/mod.rs:33:22 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn serve_article(req: &Request, id : &i32) -> Response { [INFO] [stderr] | ^^^ help: consider using `_req` instead [INFO] [stderr] [INFO] [stderr] warning: function is never used: `serve_static_files` [INFO] [stderr] --> src/controller/mod.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | pub fn serve_static_files(req: &Request) -> Response { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/controller/mod.rs:33:42 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn serve_article(req: &Request, id : &i32) -> Response { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/controller/mod.rs:75:33 [INFO] [stderr] | [INFO] [stderr] 75 | fn generate_article_content(id: &i32) -> DayTemplate { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/controller/mod.rs:81:15 [INFO] [stderr] | [INFO] [stderr] 81 | let day = trip.data.iter().filter(|x| x.id == *id as u32).map(|x| x.clone()).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `trip.data.iter().filter(|x| x.id == *id as u32).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: unused variable: `req` [INFO] [stderr] --> src/controller/mod.rs:21:20 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn serve_index(req: &Request) -> Response { [INFO] [stderr] | ^^^ help: consider using `_req` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `req` [INFO] [stderr] --> src/controller/mod.rs:33:22 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn serve_article(req: &Request, id : &i32) -> Response { [INFO] [stderr] | ^^^ help: consider using `_req` instead [INFO] [stderr] [INFO] [stderr] warning: function is never used: `serve_static_files` [INFO] [stderr] --> src/controller/mod.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | pub fn serve_static_files(req: &Request) -> Response { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/controller/mod.rs:33:42 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn serve_article(req: &Request, id : &i32) -> Response { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/controller/mod.rs:75:33 [INFO] [stderr] | [INFO] [stderr] 75 | fn generate_article_content(id: &i32) -> DayTemplate { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/controller/mod.rs:81:15 [INFO] [stderr] | [INFO] [stderr] 81 | let day = trip.data.iter().filter(|x| x.id == *id as u32).map(|x| x.clone()).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `trip.data.iter().filter(|x| x.id == *id as u32).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 31.11s [INFO] running `"docker" "inspect" "ff22bf50ec068c640161b9b3c4d9ce3afddc31f497814f3bff103bf22e59a8fe"` [INFO] running `"docker" "rm" "-f" "ff22bf50ec068c640161b9b3c4d9ce3afddc31f497814f3bff103bf22e59a8fe"` [INFO] [stdout] ff22bf50ec068c640161b9b3c4d9ce3afddc31f497814f3bff103bf22e59a8fe